summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDuda Dornelles <ddornell@thoughtworks.com>2014-09-09 15:07:41 -0300
committerDuda Dornelles <ddornell@thoughtworks.com>2014-09-09 15:07:41 -0300
commitf072f75dc4ae0bcb2dbf57f1d374a1e53913eed4 (patch)
treedb5418b40f129e864e9e4a5bba7a7ef72690e9f4
parent7e7db492bc1ea5f130d167ce55c9c63348d213d6 (diff)
addMailbox shouldn't accept empty names since it makes it impossible to retrieve it later
-rw-r--r--mail/changes/prevent-mailbox-with-blank-name3
-rw-r--r--mail/src/leap/mail/imap/account.py2
2 files changed, 5 insertions, 0 deletions
diff --git a/mail/changes/prevent-mailbox-with-blank-name b/mail/changes/prevent-mailbox-with-blank-name
new file mode 100644
index 0000000..c676fb6
--- /dev/null
+++ b/mail/changes/prevent-mailbox-with-blank-name
@@ -0,0 +1,3 @@
+ o account#addMailbox can't allow empty mailbox names since it makes it
+impossible to create it later (mailbox#__init__ will throw an error), which makes
+it impossible to getMailbox or even delete it
diff --git a/mail/src/leap/mail/imap/account.py b/mail/src/leap/mail/imap/account.py
index 74ec11e..70ed13b 100644
--- a/mail/src/leap/mail/imap/account.py
+++ b/mail/src/leap/mail/imap/account.py
@@ -187,6 +187,8 @@ class SoledadBackedAccount(WithMsgFields, IndexedDB, MBoxParser):
"""
name = self._parse_mailbox_name(name)
+ leap_assert(name, "Need a mailbox name to create a mailbox")
+
if name in self.mailboxes:
raise imap4.MailboxCollision(repr(name))