summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJeff McCune <jeff@puppetlabs.com>2012-01-11 19:15:04 -0800
committerJeff McCune <jeff@puppetlabs.com>2012-01-11 19:17:03 -0800
commit501bcba719d636e851668ac208d1c623dfaaf931 (patch)
treec9cc6f17e6c9b93c60e8b58a95ed063a0192a60b
parent39d28497a3abd981da76ffb7535b825473afbcad (diff)
Add additional domain name tests
Without this patch some valid domain names are not covered in the spec tests as Stig Sandbeck Mathisen <ssm@debian.org> points out. This patch adds spec tests for the domains "." and "x.com" which are both valid.
-rw-r--r--spec/unit/puppet/parser/functions/is_domain_name_spec.rb15
1 files changed, 15 insertions, 0 deletions
diff --git a/spec/unit/puppet/parser/functions/is_domain_name_spec.rb b/spec/unit/puppet/parser/functions/is_domain_name_spec.rb
index b419231..ccd3276 100644
--- a/spec/unit/puppet/parser/functions/is_domain_name_spec.rb
+++ b/spec/unit/puppet/parser/functions/is_domain_name_spec.rb
@@ -16,6 +16,21 @@ describe "the is_domain_name function" do
lambda { scope.function_is_domain_name([]) }.should( raise_error(Puppet::ParseError))
end
+ it "should return true if a valid short domain name" do
+ result = scope.function_is_domain_name(["x.com"])
+ result.should(be_true)
+ end
+
+ it "should return true if the domain is ." do
+ result = scope.function_is_domain_name(["."])
+ result.should(be_true)
+ end
+
+ it "should return true if the domain is x.com." do
+ result = scope.function_is_domain_name(["x.com."])
+ result.should(be_true)
+ end
+
it "should return true if a valid domain name" do
result = scope.function_is_domain_name(["foo.bar.com"])
result.should(be_true)