From 501bcba719d636e851668ac208d1c623dfaaf931 Mon Sep 17 00:00:00 2001 From: Jeff McCune Date: Wed, 11 Jan 2012 19:15:04 -0800 Subject: Add additional domain name tests Without this patch some valid domain names are not covered in the spec tests as Stig Sandbeck Mathisen points out. This patch adds spec tests for the domains "." and "x.com" which are both valid. --- spec/unit/puppet/parser/functions/is_domain_name_spec.rb | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/spec/unit/puppet/parser/functions/is_domain_name_spec.rb b/spec/unit/puppet/parser/functions/is_domain_name_spec.rb index b419231..ccd3276 100644 --- a/spec/unit/puppet/parser/functions/is_domain_name_spec.rb +++ b/spec/unit/puppet/parser/functions/is_domain_name_spec.rb @@ -16,6 +16,21 @@ describe "the is_domain_name function" do lambda { scope.function_is_domain_name([]) }.should( raise_error(Puppet::ParseError)) end + it "should return true if a valid short domain name" do + result = scope.function_is_domain_name(["x.com"]) + result.should(be_true) + end + + it "should return true if the domain is ." do + result = scope.function_is_domain_name(["."]) + result.should(be_true) + end + + it "should return true if the domain is x.com." do + result = scope.function_is_domain_name(["x.com."]) + result.should(be_true) + end + it "should return true if a valid domain name" do result = scope.function_is_domain_name(["foo.bar.com"]) result.should(be_true) -- cgit v1.2.3