Age | Commit message (Collapse) | Author |
|
otherwise, there was a very ugly bug in which the (imap) inbox kept a
reference to the first instance of soledad used during a testing
session. that made tests hang because, when that soledad instance is
shutdown, the decryption pool is no longer running.
|
|
|
|
|
|
|
|
|
|
|
|
some tests added too
- Related: #7999
|
|
To keep compatibility with soledad upgrades. It will namely cause version conflicts
to not be properly handled otherwise.
|
|
Do not initialize the openssl context on each call to get mail payload phash.
The openSSL backend should only be initialized once because it is activating the os random engine
which in turn unregister and free current engine first. This is very tricky when operations are running in threads
as it essentially momentarily unregister the openssl crypto callbacks that makes openssl thread safe.
- Resolves: #8180 with the soledad PR #324
|
|
- Resolves: #8177
|
|
|
|
|
|
It changes the way that incoming service checks if a additional
verification is needed to validate signature. The way before was
checking by the type of signature object and calling the verify
signature method if the type is different from OpenPGPKey. However it
could be more readable if we check the type of decrypted message. If
it's a multipart/signed message and not a plain/text we need to verify
the signature because keymanager couldn't do it during the decryption
process.
|
|
This change adds test to validate signature of encrypted email created
by apple mail. It's important to note that apple mail has a specific way
to encrypt signed messages. First it sign the email and then encrypt the
previous signed message. It was also added a message file with the
expected data.
|
|
- Related: #8031
|
|
The functions decryption_error_not_called and add_decrypted_header_called
were not being called on testDecryptEmail. So the asserts was not being
called as well.
This change adds the above functions as callbacks to be called after the
fetch method.
|
|
Fix verify signature on encrypted email from Apple Mail, adding a step
to verify signature after decrypt the email because the keymananger
could not verify signature when decrypting it
|
|
|
|
One of the pixelated adaptors was trying to access a non-existing
attribute in HashableMailbox, which for some reason was blocking the
operation of the imap server (uncatched exception in listeners call
maybe).
adding an attribute skips this error and therefore allows seamless use
of both pixelated and thunderbird user agents at the same time.
Resolves: #8083
|
|
This fixes a bug in which the tls transport complains about receiving
unicode. It was only made evident by running against twisted 16.
|
|
for consistency with the previous Account change.
|
|
Previously Account used user id from the store, but this attribute is
optional and None by default. This caused the collection_mapping to be
unable to distinct between multiple users message collections.
This chance adds a non optional user_id attribute to Account and use it
to index the collection_mapping.
- Resolves: https://github.com/pixelated/pixelated-user-agent/issues/674
- Releases: 0.4.0
|
|
The print statement only printed a number. Seeing the print you cannot
know what was printed. Seems that this line was left during a debug
process.
|
|
This greatly simplifies the handling of the password in the thunderbird
extension.
Related: #6041
|
|
|
|
We catch any error on SMTP delivery and format it as a bounce message
delivered to the user Inbox.
this doesn't comply with the bounce format, but it's a nice first start.
leaving proper structuring of the delivery failure report for future
iterations.
- Resolves: #7263
|
|
|
|
this one was missing after the events refactor.
the bug is that client was discarding the first parameter, assuming it
was the userid.
|
|
the mail service uses an Account object created from scratch, so it
wasn't sharing the collections mapping with the other Account object
that is created in the IMAP Service.
I make it a class attribute to allow mailbox notifications.
However, with the transition to a single service tree, this class
attribute can again become a class instance.
This is somehow related to a PR proposed recently by cz8s in pixelated
team:
https://github.com/leapcode/leap_mail/pull/228
However, I'm reluctant to re-use IMAPMailbox instances, since they
represent concurrent views over the same collection. I believe that
sharing the same underlying collection might be enough.
|
|
this was gone with the imap/cred refactor, but the client relies on it
to hide the 'congratulations!' welcome display on the mail widget.
|
|
- Resolves: #7977
|
|
- Resolves: #7898
|
|
|
|
for some reason, available_backends does not work inside a frozen
PyInstaller binary.
- Resolves: #7952
|
|
|
|
- Resolves #7861
|
|
* Resolves: #7889
|
|
|
|
|
|
- leap_mail still uses pycryptopp and therefore still needs the
dependency
- Keymanager calls to async HTTPClient had not been mocked, causing
a test to fail
- fixed a pep8 warning
|
|
- Create a new Generator that doesn't trim the headers
- Extract detached signature from message
- Convert message to the body an attachments level
- Add coment to the generator workaround and shows which python version
has the patch
|
|
- Extract message serialization to a method
- Add new condition to verify signature on plain text mail
- Return InvalidSignature if cannot verify
|
|
|
|
|
|
|
|
imap tests must be adapted, using a dummy credential checker.
|
|
|
|
It won't break anymore if the body is None, but will
return an empty body in that case
|
|
- Resolves: #7656
- Releases: 0.4.1
|
|
we were adding listeners for each mailbox instance, which was making
appends particularly slow, since the method that gets current count and
recent count is expensive and was being called way too many times.
|