summaryrefslogtreecommitdiff
path: root/spec
AgeCommit message (Collapse)Author
2014-05-08Move unit tests to spec/functionsHunter Haugen
rspec-puppet matchers are defined for tests which exist in spec/functions, but the function unit tests lived in spec/unit/puppet/parser/functions. This moves them to the correct place for using rspec-puppet
2014-05-07Add mode +x to spec .rb filesHunter Haugen
2014-05-07Move the 4 misplaced testsHunter Haugen
2014-05-07Adding more spec coverageHunter Haugen
2014-05-07Add the missing shebangs and fix the wrong ones for rpmlint to stop ↵Andrea Veri
complaining loudly
2014-05-02Update build_csv to understand contextsHunter Haugen
2014-05-02Fix the validate_augeas beaker testsHunter Haugen
2014-05-01Add more specsHunter Haugen
2014-04-28Merge pull request #243 from hunner/add_beakerAshley Penney
Add beaker tests for functions.
2014-04-24Merge pull request #222 from mfoo/fix/master/concat-primitivesAshley Penney
Allow concat to take non-array second parameters
2014-04-24Merge pull request #238 from Spredzy/add_default_ensure_packagesAshley Penney
(MODULES-603) Add defaults arguments to ensure_packages()
2014-04-22Adjust the regular expression for facts.Ashley Penney
Previously this was incorrectly handling facts that were of the form foo=1+1=2 due to the ='s in the actual fact contents. Fix this and add tests to try and prevent regressions.
2014-04-16(maint) Remove facter versions testKylo Ginsberg
This test attempts to emulate various versions of facter, but is still dependent on the version of facter it is running against. The immediate symptom was that the test breaks with facter 2.0.1 because it adds another external facts search directory. I tried a couple ways to stub this but allowing it to pretend to run against one set of facters, while actually running against one real facter (which might itself be one of several versions) eluded me. So this patch just removes the test.
2014-04-09Adding more testsHunter Haugen
2014-04-08Add build_csvHunter Haugen
2014-04-08Add success/fail groupsHunter Haugen
2014-04-03First set of testsHunter Haugen
2014-04-03Add some acceptance tests for functions.Ashley Penney
2014-03-30(MODULES-603) Add defaults arguments to ensure_packages()Yanis Guenane
Without this patch one can not specify package resource specific parameters. All the ensure_packages() function does it makes sure the named packages are installed. This patch allows one to pass default as a second argument and allow greater flexibility on packages installations. Use case like the following are now possible : * ensure_packages(['r10k', 'serverspec'], {'provider' => 'gem'}) * ensure_packages(['ntp'], {'require' => 'Exec[foobar]'})
2014-03-12Add beaker framework.Ashley Penney
This prepares the module for beaker acceptance tests.
2014-03-11Merge pull request #220 from mediatemple/fix/master/deep_merge_fixAshley Penney
PUP-1724 Don't modify the paramaters to deep_merge
2014-03-08Numerous changes to update testing gems.Ashley Penney
This work updates a number of Gems to the latest versions (rspec, rspec-puppet), and updates and tweaks a bunch of tests to work with the updated gems.
2014-02-21Allow concat to take non-array second parametersMartin Foot
Also improve and extend concat tests to lock down functionality
2014-02-17PUP-1724 Don't modify the paramaters to deep_mergeJustin Burnham
Instead of modifying the first paramater of deep_merge due to the use of the merge! function, instead use merge to return a copy of the merged object. This allows one to continue to use the original first parameter after the call to deep_merge.
2014-02-05Remove trailing whitespaceSharif Nassar
2014-01-29(PUP-638) Add a pick_default() function that always returns a value.David Schmitt
This version of pick() does not error out, instead always returning at least the last argument, even if that too has no "real" value.
2014-01-28Merge pull request #215 from blkperl/add_root_home_to_mavericksAndrew Parker
(PUP-1459) Add support for root_home on OS X 10.9
2014-01-23(PUP-1195) Fix is_numeric/is_integer when checking non-string parametersSimon Effenberg
I expect a function called "is_numeric" or "is_integer" to check if a variable is an integer or a number even if the variable passed by isn't a string nor a number at all. Otherwise we should call them is_string_a_number and is_string_an_integer and we have then to remove the check for .is_a?(Number) and .is_a?(FixNum) now checking also if it is a hex or octal number improved/corrected checking for integer * checking against Integer instead of Fixnum so that also Bignum is matching * now .is_a? Integer is done first so this is quiet fast Now many types of numerics are recognized. 1. Float/Integer values (signed or unsigned, with exponent or without) 2. octal and hex check 3. except hex numbers and the "0." in a float lower than 1 can be prefixed with a '0'. whitespaces shouldn't be allowed as prefix/suffix string representation of numbers should not contain any type of whitespace.. the user is responsible to clean a string before checking it.. fix documentation and added more checks tried to be 99.9% backward compatible * for now the decission is post poned if hex and octal numbers should be allowed or not (is_numeric) * native Bignum is now also a valid integer class fix problem with old 1.8 ruby and Hash.to_s/Array.to_s In ruby < 1.9 array and hashes would be recognized as numeric if they have a special format: 1.8: [1,2,3,4].to_s = "1234" {1=>2}.to_s = "12" 1.9: [1,2,3,4].to_s = "[1, 2, 3, 4]" {1=>2}.to_s = "{1=>2}"
2014-01-22(PUP-1459) Add support for root_home on OS X 10.9William Van Hevelingen
getent does not exist on 10.9 so this commit uses dscacheutil to query the homedir for the root user.
2014-01-15(maint) Update ensure_package specs to confirm expected behaviorAdrien Thebo
The previous behavior of the tests checked the behavior of the underlying functions library when called with no arguments; this commit updates the tests to conform to the functions API and test what happens when a function is called with no args.
2014-01-15Allow a single argument, rather than an arrayTomas Doran
2013-12-20(maint) Improve test coverage for prefix and suffixAdrien Thebo
2013-12-18(Maint) Update stubbing to work with facter 1.7.4Andrew Parker
Facter 1.7.4 changed how it decides on what directory to look in for facts.d based on the user it is running as. This stubs out that bit of code to make it think it is running as root.
2013-12-18Merge pull request #211 from jhoblitt/function_is_boolAndrew Parker
(#23381) add is_bool() function
2013-12-18Merge pull request #203 from dreamlibrarian/fix/is_function_available-ruby_cAndrew Parker
calling rspec directly makes is_function_available.rb not pass ruby -c
2013-12-09(#23381) add is_bool() functionJoshua Hoblitt
2013-11-20calling rspec directly makes this not pass ruby -c. adjusting to be in line ↵Tristan Smith
with the rest.
2013-11-19Fix the tests on osxTomas Doran
2013-10-29(#20200) Add a recursive merge function.Justin Burnham
Issue #20200 notes that the merge function does not support nested hashes. To prevent unintended side effects with changing merge, add a deep_merge function instead.
2013-10-29(Main) fix typo in pick error messageMatthew Haughton
Update pick error message "at least one non empty value"
2013-09-18Merge branch 'pull-180'Adrien Thebo
This closes GH-180
2013-09-18(maint) Simplify validate_cmd specsAdrien Thebo
2013-09-18(#22214): close content file before executing checkscriptsgzijl
Right now validation seems to be done against zero byte generated temp files. We need to close the file before executing validation against it.
2013-09-18Merge pull request #184 from lmello/fix_bug_20681_delete_undef_valuesAdrien Thebo
delete_undef_values function fix bug #20681
2013-09-18(#20681) fix behaviour of delete_undef_valuesLeonardo Rodrigues de Mello
The issue #20681 describe the error of delete() function removing the elements from the origin array/hash/string. This issue affected other delete functions. Because ruby delete and delete_if functions make destructive changes to the origin array/hash. The delete_undef_values removed elements from the origin array/hash and this is not the desired behaviour. To solve this, we should dup or clone the array/hash before using the delete or delete_if ruby functions. We should also check if args[0] is not nil before using dup, since dup on nil raises exception. This fix the problem and add unit tests, so we could enforce this behaviour and prevent regressions.
2013-09-17Merge pull request #183 from lmello/fix_bug_20681_delete_atAdrien Thebo
delete_at added spec to check against bug #20681
2013-09-17Merge pull request #182 from lmello/fix_bug_20681_delete_valuesAdrien Thebo
delete_values() fix bug #20681.
2013-09-17Merge pull request #185 from lmello/refactor_16498Adrien Thebo
(#16498) Added unit test for loadyaml function.
2013-09-17(#16498) Added unit test for loadyaml function.Leonardo Rodrigues de Mello
As stated on the issue #16498, it would be great to have unit tests for all the functions. Function loadyaml was missing a unit test. This commit added the unit test to loadyaml function.
2013-09-17Merge pull request #178 from lmello/fix_bug_20681Adrien Thebo
bug # 20681 delete() function should not remove elements from original list