diff options
author | Martin Foot <martin@modeltwozero.com> | 2014-02-21 14:32:32 +0000 |
---|---|---|
committer | Martin Foot <martin@modeltwozero.com> | 2014-02-21 15:48:27 +0000 |
commit | 35bf5fd8c93d5052ecf5284ed3194a92cab838d5 (patch) | |
tree | 7d2cfde612643014511baad8d4174841c1f14e42 /spec | |
parent | ab981422a67636441f1bfebaaade36aa690f1f25 (diff) |
Allow concat to take non-array second parameters
Also improve and extend concat tests to lock down functionality
Diffstat (limited to 'spec')
-rw-r--r-- | spec/unit/puppet/parser/functions/concat_spec.rb | 19 |
1 files changed, 17 insertions, 2 deletions
diff --git a/spec/unit/puppet/parser/functions/concat_spec.rb b/spec/unit/puppet/parser/functions/concat_spec.rb index 123188b..6e67620 100644 --- a/spec/unit/puppet/parser/functions/concat_spec.rb +++ b/spec/unit/puppet/parser/functions/concat_spec.rb @@ -4,12 +4,27 @@ require 'spec_helper' describe "the concat function" do let(:scope) { PuppetlabsSpec::PuppetInternals.scope } - it "should raise a ParseError if there is less than 1 arguments" do - lambda { scope.function_concat([]) }.should( raise_error(Puppet::ParseError)) + it "should raise a ParseError if the client does not provide two arguments" do + lambda { scope.function_concat([]) }.should(raise_error(Puppet::ParseError)) + end + + it "should raise a ParseError if the first parameter is not an array" do + lambda { scope.function_concat([1, []])}.should(raise_error(Puppet::ParseError)) end it "should be able to concat an array" do result = scope.function_concat([['1','2','3'],['4','5','6']]) result.should(eq(['1','2','3','4','5','6'])) end + + it "should be able to concat a primitive to an array" do + result = scope.function_concat([['1','2','3'],'4']) + result.should(eq(['1','2','3','4'])) + end + + it "should not accidentally flatten nested arrays" do + result = scope.function_concat([['1','2','3'],[['4','5'],'6']]) + result.should(eq(['1','2','3',['4','5'],'6'])) + end + end |