(PUP-638) Add a pick_default() function that always returns a value.

This version of pick() does not error out, instead always returning at least
the last argument, even if that too has no "real" value.

1 files changed, 58 insertions, 0 deletions

diff --git a/spec/unit/puppet/parser/functions/pick_default_spec.rb b/spec/unit/puppet/parser/functions/pick_default_spec.rb
new file mode 100644
index 0000000..c9235b5
--- /dev/null
+++ b/spec/unit/puppet/parser/functions/pick_default_spec.rb
@@ -0,0 +1,58 @@
+#!/usr/bin/env ruby -S rspec
+require 'spec_helper'
+
+describe "the pick_default function" do
+  let(:scope) { PuppetlabsSpec::PuppetInternals.scope }
+
+  it "should exist" do
+    Puppet::Parser::Functions.function("pick_default").should == "function_pick_default"
+  end
+
+  it 'should return the correct value' do
+    scope.function_pick_default(['first', 'second']).should == 'first'
+  end
+
+  it 'should return the correct value if the first value is empty' do
+    scope.function_pick_default(['', 'second']).should == 'second'
+  end
+
+  it 'should skip empty string values' do
+    scope.function_pick_default(['', 'first']).should == 'first'
+  end
+
+  it 'should skip :undef values' do
+    scope.function_pick_default([:undef, 'first']).should == 'first'
+  end
+
+  it 'should skip :undefined values' do
+    scope.function_pick_default([:undefined, 'first']).should == 'first'
+  end
+
+  it 'should return the empty string if it is the last possibility' do
+    scope.function_pick_default([:undef, :undefined, '']).should == ''
+  end
+
+  it 'should return :undef if it is the last possibility' do
+    scope.function_pick_default(['', :undefined, :undef]).should == :undef
+  end
+
+  it 'should return :undefined if it is the last possibility' do
+    scope.function_pick_default([:undef, '', :undefined]).should == :undefined
+  end
+
+  it 'should return the empty string if it is the only possibility' do
+    scope.function_pick_default(['']).should == ''
+  end
+
+  it 'should return :undef if it is the only possibility' do
+    scope.function_pick_default([:undef]).should == :undef
+  end
+
+  it 'should return :undefined if it is the only possibility' do
+    scope.function_pick_default([:undefined]).should == :undefined
+  end
+
+  it 'should error if no values are passed' do
+    expect { scope.function_pick_default([]) }.to raise_error(Puppet::Error, /Must receive at least one argument./)
+  end
+end