(MODULES-3980) Fix ipv4 regex validator

This also updates all ipv4 tests to use the same test data for better
comparability. Closes #676, #679

Fix-Originally-By: Nate Potter <nathaniel.potter@intel.com>

1 files changed, 2 insertions, 12 deletions

diff --git a/spec/aliases/ipv4_spec.rb b/spec/aliases/ipv4_spec.rb
index e767b45..210b4b1 100644
--- a/spec/aliases/ipv4_spec.rb
+++ b/spec/aliases/ipv4_spec.rb
@@ -3,12 +3,7 @@ require 'spec_helper'
 if Puppet.version.to_f >= 4.5
   describe 'test::ipv4', type: :class do
     describe 'accepts ipv4 addresses' do
-      [
-        '224.0.0.0',
-        '255.255.255.255',
-        '0.0.0.0',
-        '192.88.99.0'
-      ].each do |value|
+      SharedData::IPV4_PATTERNS.each do |value|
         describe value.inspect do
           let(:params) {{ value: value }}
           it { is_expected.to compile }
@@ -16,12 +11,7 @@ if Puppet.version.to_f >= 4.5
       end
     end
     describe 'rejects other values' do
-      [
-        'nope',
-        '77',
-        '4.4.4',
-        '2001:0db8:85a3:0000:0000:8a2e:0370:73342001:0db8:85a3:0000:0000:8a2e:0370:7334'
-      ].each do |value|
+      SharedData::IPV4_NEGATIVE_PATTERNS.each do |value|
         describe value.inspect do
           let(:params) {{ value: value }}
           it { is_expected.to compile.and_raise_error(/parameter 'value' expects a match for Stdlib::Compat::Ipv4/) }