diff options
author | Jeff McCune <jeff@puppetlabs.com> | 2011-06-21 17:03:25 -0700 |
---|---|---|
committer | Jeff McCune <jeff@puppetlabs.com> | 2011-06-21 17:03:25 -0700 |
commit | f036fbbb24c91a3f213210be42ff1e8d67615ce3 (patch) | |
tree | e84a4512f50278f704d7695bc6e9ad9efebba2a4 | |
parent | de2434255e41e043017b6a4448ab1e936f427f2e (diff) | |
parent | 08882ccd3b84eda124b56679e2885881a009ba12 (diff) |
Merge branch 'ticket/master/8010_validate_hash_function'
* ticket/master/8010_validate_hash_function:
(#8010) Add validate_hash spec tests
(#8010) Add validate_hash function
-rw-r--r-- | lib/puppet/parser/functions/validate_hash.rb | 37 | ||||
-rw-r--r-- | spec/unit/puppet/parser/functions/validate_hash_spec.rb | 63 |
2 files changed, 100 insertions, 0 deletions
diff --git a/lib/puppet/parser/functions/validate_hash.rb b/lib/puppet/parser/functions/validate_hash.rb new file mode 100644 index 0000000..1443318 --- /dev/null +++ b/lib/puppet/parser/functions/validate_hash.rb @@ -0,0 +1,37 @@ +module Puppet::Parser::Functions + + newfunction(:validate_hash, :doc => <<-'ENDHEREDOC') do |args| + Validate all passed values are a Hash data structure + value does not pass the check. + + Example: + + These values validate + + $my_hash = { 'one' => 'two' } + validate_hash($my_hash) + + These values do NOT validate + + validate_hash(true) + validate_hash('some_string') + $undefined = undef + validate_hash($undefined) + + * Jeff McCune <jeff@puppetlabs.com> + + ENDHEREDOC + + unless args.length > 0 then + raise Puppet::ParseError, ("validate_hash(): wrong number of arguments (#{args.length}; must be > 0)") + end + + args.each do |arg| + unless arg.is_a?(Hash) + raise Puppet::ParseError, ("#{arg.inspect} is not a Hash. It looks to be a #{arg.class}") + end + end + + end + +end diff --git a/spec/unit/puppet/parser/functions/validate_hash_spec.rb b/spec/unit/puppet/parser/functions/validate_hash_spec.rb new file mode 100644 index 0000000..8cc0b3d --- /dev/null +++ b/spec/unit/puppet/parser/functions/validate_hash_spec.rb @@ -0,0 +1,63 @@ +require 'puppet' + +# We don't need this for the basic tests we're doing +# require 'spec_helper' + +# Dan mentioned that Nick recommended the function method call +# to return the string value for the test description. +# this will not even try the test if the function cannot be +# loaded. +describe Puppet::Parser::Functions.function(:validate_hash) do + + # Pulled from Dan's create_resources function + def get_scope + @topscope = Puppet::Parser::Scope.new + # This is necessary so we don't try to use the compiler to discover our parent. + @topscope.parent = nil + @scope = Puppet::Parser::Scope.new + @scope.compiler = Puppet::Parser::Compiler.new(Puppet::Node.new("floppy", :environment => 'production')) + @scope.parent = @topscope + @compiler = @scope.compiler + end + + describe 'when calling validate_hash from puppet' do + + %w{ true false }.each do |the_string| + + it "should not compile when #{the_string} is a string" do + Puppet[:code] = "validate_hash('#{the_string}')" + get_scope + expect { @scope.compiler.compile }.should raise_error(Puppet::ParseError, /is not a Hash/) + end + + it "should not compile when #{the_string} is a bare word" do + Puppet[:code] = "validate_hash(#{the_string})" + get_scope + expect { @scope.compiler.compile }.should raise_error(Puppet::ParseError, /is not a Hash/) + end + + end + + it "should compile when multiple hash arguments are passed" do + Puppet[:code] = <<-'ENDofPUPPETcode' + $foo = {} + $bar = { 'one' => 'two' } + validate_hash($foo, $bar) + ENDofPUPPETcode + get_scope + @scope.compiler.compile + end + + it "should not compile when an undef variable is passed" do + Puppet[:code] = <<-'ENDofPUPPETcode' + $foo = undef + validate_hash($foo) + ENDofPUPPETcode + get_scope + expect { @scope.compiler.compile }.should raise_error(Puppet::ParseError, /is not a Hash/) + end + + end + +end + |