summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMorgan Haskel <morgan@puppetlabs.com>2015-02-19 12:01:26 -0800
committerMorgan Haskel <morgan@puppetlabs.com>2015-02-19 12:01:26 -0800
commitb693c870d20f8bf0c574b9581a92ce3842fb3c05 (patch)
tree33bd6c3c60bd725f6e41dde5ab8e5b34cb062262
parentfcd2f53908e5f4d4c3396cd56593473c3095453d (diff)
Check for string before copying
-rw-r--r--lib/puppet/parser/functions/is_domain_name.rb6
1 files changed, 3 insertions, 3 deletions
diff --git a/lib/puppet/parser/functions/is_domain_name.rb b/lib/puppet/parser/functions/is_domain_name.rb
index 24cc208..2860ded 100644
--- a/lib/puppet/parser/functions/is_domain_name.rb
+++ b/lib/puppet/parser/functions/is_domain_name.rb
@@ -13,6 +13,9 @@ Returns true if the string passed to this function is a syntactically correct do
"given #{arguments.size} for 1")
end
+ # Only allow string types
+ return false unless arguments[0].is_a?(String)
+
domain = arguments[0].dup
# Limits (rfc1035, 3.1)
@@ -20,9 +23,6 @@ Returns true if the string passed to this function is a syntactically correct do
label_min_length=1
label_max_length=63
- # Only allow string types
- return false unless domain.is_a?(String)
-
# Allow ".", it is the top level domain
return true if domain == '.'