Merge pull request #54 from raphink/dev/revert_run_user

Revert run_user change

7 files changed, 27 insertions, 19 deletions

diff --git a/manifests/config.pp b/manifests/config.pp
index ad6e7bd..dbb37cc 100644
--- a/manifests/config.pp
+++ b/manifests/config.pp
@@ -13,8 +13,8 @@
 class rsyslog::config {
   file { $rsyslog::rsyslog_d:
     ensure  => directory,
-    owner   => 0,
-    group   => 0,
+    owner   => 'root',
+    group   => $rsyslog::run_group,
     purge   => $rsyslog::purge_rsyslog_d,
     recurse => true,
     force   => true,
@@ -23,8 +23,8 @@ class rsyslog::config {
 
   file { $rsyslog::rsyslog_conf:
     ensure  => file,
-    owner   => 0,
-    group   => 0,
+    owner   => 'root',
+    group   => $rsyslog::run_group,
     content => template("${module_name}/rsyslog.conf.erb"),
     require => Class['rsyslog::install'],
     notify  => Class['rsyslog::service'],
@@ -32,8 +32,8 @@ class rsyslog::config {
 
   file { $rsyslog::rsyslog_default:
     ensure  => file,
-    owner   => 0,
-    group   => 0,
+    owner   => 'root',
+    group   => $rsyslog::run_group,
     source  => "puppet:///modules/rsyslog/${rsyslog::rsyslog_default_file}",
     require => Class['rsyslog::install'],
     notify  => Class['rsyslog::service'],
@@ -41,8 +41,8 @@ class rsyslog::config {
 
   file { $rsyslog::spool_dir:
     ensure  => directory,
-    owner   => 0,
-    group   => 0,
+    owner   => 'root',
+    group   => $rsyslog::run_group,
     require => Class['rsyslog::install'],
     notify  => Class['rsyslog::service'],
   }
diff --git a/manifests/database.pp b/manifests/database.pp
index 09c1cc5..fe6d6ac 100644
--- a/manifests/database.pp
+++ b/manifests/database.pp
@@ -46,8 +46,8 @@ class rsyslog::database (
 
   file { $db_conf:
     ensure  => present,
-    owner   => 0,
-    group   => 0,
+    owner   => 'root',
+    group   => $rsyslog::run_group,
     mode    => '0600',
     content => template("${module_name}/database.conf.erb"),
     require => Class['rsyslog::config'],
diff --git a/manifests/imfile.pp b/manifests/imfile.pp
index 4a2a2eb..a6e8216 100644
--- a/manifests/imfile.pp
+++ b/manifests/imfile.pp
@@ -34,8 +34,8 @@ define rsyslog::imfile(
 
   file { "${rsyslog::rsyslog_d}${name}.conf":
     ensure  => file,
-    owner   => 0,
-    group   => 0,
+    owner   => 'root',
+    group   => $rsyslog::run_group,
     content => template('rsyslog/imfile.erb'),
     require => Class['rsyslog::install'],
     notify  => Class['rsyslog::service'],
diff --git a/manifests/init.pp b/manifests/init.pp
index e4692ba..fbe22f6 100644
--- a/manifests/init.pp
+++ b/manifests/init.pp
@@ -11,8 +11,6 @@
 #  class { 'rsyslog': }
 #
 class rsyslog (
-  $run_user               = 0,
-  $run_group              = 0,
   $rsyslog_package_name   = $rsyslog::params::rsyslog_package_name,
   $relp_package_name      = $rsyslog::params::relp_package_name,
   $mysql_package_name     = $rsyslog::params::mysql_package_name,
@@ -24,6 +22,8 @@ class rsyslog (
   $rsyslog_conf           = $rsyslog::params::rsyslog_conf,
   $rsyslog_default        = $rsyslog::params::rsyslog_default,
   $rsyslog_default_file   = $rsyslog::params::default_config_file,
+  $run_user               = $rsyslog::params::run_user,
+  $run_group              = $rsyslog::params::run_group,
   $log_user               = $rsyslog::params::log_user,
   $log_group              = $rsyslog::params::log_group,
   $log_style              = $rsyslog::params::log_style,
diff --git a/manifests/params.pp b/manifests/params.pp
index 644eaa5..c3fc482 100644
--- a/manifests/params.pp
+++ b/manifests/params.pp
@@ -25,6 +25,8 @@ class rsyslog::params {
       $rsyslog_conf           = '/etc/rsyslog.conf'
       $rsyslog_default        = '/etc/default/rsyslog'
       $default_config_file    = 'rsyslog_default'
+      $run_user               = 'root'
+      $run_group              = 'root'
       $log_user               = 'root'
       $log_group              = 'adm'
       $log_style              = 'debian'
@@ -57,6 +59,8 @@ class rsyslog::params {
       $rsyslog_conf           = '/etc/rsyslog.conf'
       $rsyslog_default        = '/etc/sysconfig/rsyslog'
       $default_config_file    = 'rsyslog_default'
+      $run_user               = 'root'
+      $run_group              = 'root'
       $log_user               = 'root'
       $log_group              = 'root'
       $log_style              = 'redhat'
@@ -84,6 +88,8 @@ class rsyslog::params {
       $rsyslog_conf           = '/etc/syslog.conf'
       $rsyslog_default        = '/etc/defaults/syslogd'
       $default_config_file    = 'rsyslog_default'
+      $run_user               = 'root'
+      $run_group              = 'wheel'
       $log_user               = 'root'
       $log_group              = 'wheel'
       $log_style              = 'debian'
@@ -100,6 +106,7 @@ class rsyslog::params {
         '#$ModLoad immark  # provides --MARK-- message capability',
       ]
     }
+
     default: {
       case $::operatingsystem {
         gentoo: {
@@ -114,6 +121,8 @@ class rsyslog::params {
           $rsyslog_conf           = '/etc/rsyslog.conf'
           $rsyslog_default        = '/etc/conf.d/rsyslog'
           $default_config_file    = 'rsyslog_default_gentoo'
+          $run_user               = 'root'
+          $run_group              = 'root'
           $log_user               = 'root'
           $log_group              = 'adm'
           $log_style              = 'debian'
@@ -136,5 +145,4 @@ class rsyslog::params {
       }
     }
   }
-
 }
diff --git a/manifests/snippet.pp b/manifests/snippet.pp
index 6c0a756..bb0468e 100644
--- a/manifests/snippet.pp
+++ b/manifests/snippet.pp
@@ -24,8 +24,8 @@ define rsyslog::snippet(
 
   file { "${rsyslog::rsyslog_d}${name}.conf":
     ensure  => $ensure,
-    owner   => 0,
-    group   => 0,
+    owner   => $rsyslog::run_user,
+    group   => $rsyslog::run_group,
     content => "# file managed by puppet\n${content}\n",
     require => Class['rsyslog::config'],
     notify  => Class['rsyslog::service'],
diff --git a/templates/rsyslog.conf.erb b/templates/rsyslog.conf.erb
index 609aa78..f076fc4 100644
--- a/templates/rsyslog.conf.erb
+++ b/templates/rsyslog.conf.erb
@@ -20,8 +20,8 @@ $FileCreateMode <%= scope.lookupvar('rsyslog::perm_file') %>
 $DirOwner <%= scope.lookupvar('rsyslog::log_user') %>
 $DirGroup <%= scope.lookupvar('rsyslog::log_group') %>
 $DirCreateMode <%= scope.lookupvar('rsyslog::perm_dir') %>
-$PrivDropToUserID <%= scope.lookupvar('rsyslog::run_user') %>
-$PrivDropToGroupID <%= scope.lookupvar('rsyslog::run_group') %>
+$PrivDropToUser <%= scope.lookupvar('rsyslog::run_user') %>
+$PrivDropToGroup <%= scope.lookupvar('rsyslog::run_group') %>
 
 #
 # Include all config files in <%= scope.lookupvar('rsyslog::rsyslog_d') %>