summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGabriel Filion <gabster@lelutin.ca>2015-05-13 16:02:36 -0400
committerGabriel Filion <gabster@lelutin.ca>2015-05-13 16:02:36 -0400
commit1522deafdad1d34562d8daa21ba218fc8f395d83 (patch)
tree5707b2a37c4c5edd457028e7b453859c31b2c2d5
parent85514f6febcfd93766509f9c529598a7ce5c11e2 (diff)
mysql root password is leaked to the process list
Every time the root password reset is used we're leaking the password to the process list. If we use the already present /root/.my.cnf for credentials then it has the same effect for verification and we avoid leaking the password.
-rw-r--r--files/scripts/CentOS/setmysqlpass.sh2
-rw-r--r--files/scripts/CentOS/setmysqlpass.sh.52
-rw-r--r--files/scripts/CentOS/setmysqlpass.sh.62
-rw-r--r--files/scripts/Debian/setmysqlpass.sh2
4 files changed, 4 insertions, 4 deletions
diff --git a/files/scripts/CentOS/setmysqlpass.sh b/files/scripts/CentOS/setmysqlpass.sh
index 6876cb9..62b5b2f 100644
--- a/files/scripts/CentOS/setmysqlpass.sh
+++ b/files/scripts/CentOS/setmysqlpass.sh
@@ -24,7 +24,7 @@ must_have chown
rootpw=$(grep password /root/.my.cnf | sed -e 's/^[^=]*= *\(.*\) */\1/')
-/usr/bin/mysqladmin -uroot --password="${rootpw}" status > /dev/null && echo "Nothing to do as the password already works" && exit 0
+/usr/bin/mysqladmin --defaults-file=/root/.my.cnf status > /dev/null && echo "Nothing to do as the password already works" && exit 0
/usr/bin/systemctl stop mariadb
diff --git a/files/scripts/CentOS/setmysqlpass.sh.5 b/files/scripts/CentOS/setmysqlpass.sh.5
index abd0931..b904487 100644
--- a/files/scripts/CentOS/setmysqlpass.sh.5
+++ b/files/scripts/CentOS/setmysqlpass.sh.5
@@ -4,7 +4,7 @@ test -f /root/.my.cnf || exit 1
rootpw=$(grep password /root/.my.cnf | sed -e 's/^[^=]*= *\(.*\) */\1/')
-/usr/bin/mysqladmin -uroot --password="${rootpw}" status > /dev/null && echo "Nothing to do as the password already works" && exit 0
+/usr/bin/mysqladmin --defaults-file=/root/.my.cnf status > /dev/null && echo "Nothing to do as the password already works" && exit 0
/sbin/service mysqld stop
diff --git a/files/scripts/CentOS/setmysqlpass.sh.6 b/files/scripts/CentOS/setmysqlpass.sh.6
index abd0931..b904487 100644
--- a/files/scripts/CentOS/setmysqlpass.sh.6
+++ b/files/scripts/CentOS/setmysqlpass.sh.6
@@ -4,7 +4,7 @@ test -f /root/.my.cnf || exit 1
rootpw=$(grep password /root/.my.cnf | sed -e 's/^[^=]*= *\(.*\) */\1/')
-/usr/bin/mysqladmin -uroot --password="${rootpw}" status > /dev/null && echo "Nothing to do as the password already works" && exit 0
+/usr/bin/mysqladmin --defaults-file=/root/.my.cnf status > /dev/null && echo "Nothing to do as the password already works" && exit 0
/sbin/service mysqld stop
diff --git a/files/scripts/Debian/setmysqlpass.sh b/files/scripts/Debian/setmysqlpass.sh
index 3de2781..aa1b701 100644
--- a/files/scripts/Debian/setmysqlpass.sh
+++ b/files/scripts/Debian/setmysqlpass.sh
@@ -25,7 +25,7 @@ must_have chown
rootpw=$(grep password /root/.my.cnf | sed -e 's/^[^=]*= *\(.*\) */\1/')
-/usr/bin/mysqladmin -uroot --password="${rootpw}" status > /dev/null && echo "Nothing to do as the password already works" && exit 0
+/usr/bin/mysqladmin --defaults-file=/root/.my.cnf status > /dev/null && echo "Nothing to do as the password already works" && exit 0
/etc/init.d/mysql stop