Display progress bar when an upload is in progress

Displays a progress bar when an upload is in progress and prohibits
uploading multiple attachments in parallel.

3 files changed, 63 insertions, 30 deletions

diff --git a/web-ui/app/js/mail_view/ui/attachment_icon.js b/web-ui/app/js/mail_view/ui/attachment_icon.js
index 478853b0..6b9cb31c 100644
--- a/web-ui/app/js/mail_view/ui/attachment_icon.js
+++ b/web-ui/app/js/mail_view/ui/attachment_icon.js
@@ -34,12 +34,27 @@ define(
                 this.trigger(document, events.mail.startUploadAttachment);
             };
 
+            this.uploadInProgress = function (ev, data) {
+                this.attr.busy = true;
+                this.$node.addClass('busy');
+            };
+
+            this.uploadFinished = function (ev, data) {
+                this.attr.busy = false;
+                this.$node.removeClass('busy');
+            };
+
             this.after('initialize', function () {
                 if (features.isEnabled('attachment')) {
                     this.render();
+                    this.on(document, events.mail.uploadingAttachment, this.uploadInProgress);
+                    this.on(document, events.mail.uploadedAttachment, this.uploadFinished);
                 }
-                this.on(this.$node, 'click', this.triggerUploadAttachment);
+                this.on(this.$node, 'click', function() {
+                    if (!this.attr.busy) {
+                        this.triggerUploadAttachment();
+                    }
+                });
             });
-
         });
     });
diff --git a/web-ui/app/js/mail_view/ui/attachment_list.js b/web-ui/app/js/mail_view/ui/attachment_list.js
index 3def6870..19a48a8d 100644
--- a/web-ui/app/js/mail_view/ui/attachment_list.js
+++ b/web-ui/app/js/mail_view/ui/attachment_list.js
@@ -29,7 +29,8 @@ define(
             this.defaultAttrs({
                 inputFileUpload: '#fileupload',
                 attachmentListItem: '#attachment-list-item',
-                progressBar: '#progress .progress-bar',
+                attachmentUploadItem: '#attachment-upload-item',
+                attachmentUploadItemProgress: '#attachment-upload-item-progress',
                 attachmentBaseUrl: '/attachment',
                 attachments: [],
                 closeIcon: '.close-icon',
@@ -74,57 +75,73 @@ define(
                 return element;
             };
 
-            this.checkAttachmentSize = function(e, data) {
-                var self = this;
-                var uploadError = self.select('uploadError');
+            this.performPreUploadCheck = function(e, data) {
+                if (data.originalFiles[0].size > ATTACHMENT_SIZE_LIMIT) {
+                    return false;
+                }
+
+                return true;
+            };
+
+            this.removeUploadError = function() {
+                var uploadError = this.select('uploadError');
                 if (uploadError) {
                     uploadError.remove();
                 }
+            };
 
-                var uploadErrors = [];
+            this.showUploadError = function () {
+                var self = this;
 
-                var showUploadFailed = function () {
-                    var html = $(templates.compose.uploadAttachmentFailed());
-                    html.insertAfter(self.select('attachmentListItem'));
+                var html = $(templates.compose.uploadAttachmentFailed());
+                html.insertAfter(self.select('attachmentListItem'));
 
-                    self.on(self.select('closeIcon'), 'click', dismissUploadFailed);
-                    self.on(self.select('dismissButton'), 'click', dismissUploadFailed);
-                    self.on(self.select('uploadFileButton'), 'click', uploadAnotherFile);
-                };
+                self.on(self.select('closeIcon'), 'click', dismissUploadFailed);
+                self.on(self.select('dismissButton'), 'click', dismissUploadFailed);
+                self.on(self.select('uploadFileButton'), 'click', uploadAnotherFile);
 
-                var dismissUploadFailed = function (event) {
+                function dismissUploadFailed(event) {
                     event.preventDefault();
                     self.select('uploadError').remove();
-                };
+                }
 
-                var uploadAnotherFile = function (event) {
+                function uploadAnotherFile(event) {
                     event.preventDefault();
                     self.trigger(document, events.mail.startUploadAttachment);
-                };
-
-                if (data.originalFiles[0].size > ATTACHMENT_SIZE_LIMIT) {
-                    uploadErrors.push('Filesize is too big');
-                }
-                if (uploadErrors.length > 0) {
-                    showUploadFailed();
-                } else {
-                    data.submit();
                 }
             };
 
+            this.showUploadProgressBar = function() {
+                this.select('attachmentUploadItem').show();
+            };
+
+            this.hideUploadProgressBar = function() {
+                this.select('attachmentUploadItem').hide();
+            };
+
             this.addJqueryFileUploadConfig = function() {
                 var self = this;
+
+                self.removeUploadError();
+
                 this.select('inputFileUpload').fileupload({
-                    add: function(e, data) { self.checkAttachmentSize(e, data); },
+                    add: function(e, data) {
+                        if (self.performPreUploadCheck(e, data)) {
+                            self.showUploadProgressBar();
+                            data.submit();
+                        } else {
+                            self.showUploadError();
+                        }
+                    },
                     url: self.attr.attachmentBaseUrl,
                     dataType: 'json',
                     done: function (e, response) {
-                        var data = response.result;
-                        self.trigger(document, events.mail.uploadedAttachment, data);
+                        self.hideUploadProgressBar();
+                        self.trigger(document, events.mail.uploadedAttachment, response.result);
                     },
                     progressall: function (e, data) {
                         var progressRate = parseInt(data.loaded / data.total * 100, 10);
-                        self.select('progressBar').css('width', progressRate + '%');
+                        self.select('attachmentUploadItemProgress').css('width', progressRate + '%');
                     }
                 }).bind('fileuploadstart', function (e) {
                     self.trigger(document, events.mail.uploadingAttachment);
diff --git a/web-ui/app/js/views/templates.js b/web-ui/app/js/views/templates.js
index e5a3c435..f9d944b8 100644
--- a/web-ui/app/js/views/templates.js
+++ b/web-ui/app/js/views/templates.js
@@ -75,6 +75,7 @@ define(['hbs/templates'], function (templates) {
   Handlebars.registerPartial('tag_inner', Templates.tags.tagInner);
   Handlebars.registerPartial('recipients', Templates.compose.recipients);
   Handlebars.registerPartial('attachments_list', Templates.compose.attachmentsList);
+  Handlebars.registerPartial('attachments_upload', Templates.compose.attachmentsList);
   Handlebars.registerPartial('attachment_item', Templates.compose.attachmentItem);
   Handlebars.registerPartial('uploadAttachmentFailed', Templates.compose.uploadAttachmentFailed);