summaryrefslogtreecommitdiff
path: root/service/test/integration
diff options
context:
space:
mode:
authorVictor Shyba <victor.shyba@gmail.com>2015-08-30 02:37:34 -0300
committerVictor Shyba <victor.shyba@gmail.com>2015-08-30 02:37:34 -0300
commit02ed9435cafeb677b200a665ca77608e30caf854 (patch)
tree664af3533ef79c02a109fc5806abd2b070e3cd58 /service/test/integration
parent978f3446d5cafd94d244b4240ab71dad283c9830 (diff)
[tests] reduce flakiness in test_incoming_mail
It was adding messages with notify_just_mdoc set to True (default). leap.mail suggests that this flag is set to True for performance, but it is unsafe. I was getting a lot of false negatives on tests, now it is not flaky anymore. -- Issue #445
Diffstat (limited to 'service/test/integration')
-rw-r--r--service/test/integration/test_incoming_mail.py4
1 files changed, 2 insertions, 2 deletions
diff --git a/service/test/integration/test_incoming_mail.py b/service/test/integration/test_incoming_mail.py
index bc3ca099..8a5540dc 100644
--- a/service/test/integration/test_incoming_mail.py
+++ b/service/test/integration/test_incoming_mail.py
@@ -31,7 +31,7 @@ class IncomingMailTest(SoledadTestBase):
# when
yield MailboxIndexerListener.listen(self.account, 'INBOX', self.mail_store)
- yield mbx.addMessage(input_mail.raw, [])
+ yield mbx.addMessage(input_mail.raw, [], notify_just_mdoc=False)
# then
yield self.wait_in_reactor() # event handlers are called async, wait for it
@@ -46,5 +46,5 @@ class IncomingMailTest(SoledadTestBase):
def done_waiting():
d.callback(None)
- reactor.callLater(1.0, done_waiting)
+ reactor.callLater(1, done_waiting)
return d