diff options
| author | Azul <azul@riseup.net> | 2017-07-24 09:55:28 +0200 |
|---|---|---|
| committer | Azul <azul@riseup.net> | 2017-07-24 10:03:22 +0200 |
| commit | b1738a78ccf5768f92068a27255f9f69be1c3147 (patch) | |
| tree | 6cad7ae458d6bc349a0ba925f82477feb2010fa1 /test/remote/Readme.md | |
| parent | cfa6395c7e5728de02221b94b5f9cfe8a4debf09 (diff) | |
fix: #3 handle domains without A-record
If a domain only has an mx record but no A record it
will trigger a ConnectionError when attempting the
nicknym key lookup.
We need to detect and handle this in the http adapter
already because once the exception is handled by Celluloid
our actor will be terminated.
So now we allow for handing a rescue option to the
adapter with a string that is checked for inclusion in
the error message. If the string is found the exception
will be caught and the adapter returns nil.
We only make use of this when checking the availability
of nicknym so far. That should be the only http request
going out.
Diffstat (limited to 'test/remote/Readme.md')
| -rw-r--r-- | test/remote/Readme.md | 15 |
1 files changed, 7 insertions, 8 deletions
diff --git a/test/remote/Readme.md b/test/remote/Readme.md index 957ea12..53f5e65 100644 --- a/test/remote/Readme.md +++ b/test/remote/Readme.md @@ -1,15 +1,14 @@ Integration tests for clients of remote services ================================================ -The tests in this directory are integration test with remote services. However -we aims at testing the client side of the equation as that is what we control -here. +The tests in this directory are integration test with remote services. +However we aims at testing the client side of the equation as that is +what we control here. -So unexpected server behavious should *crash* the test if we are not dealing -with it properly yet and have no unit test for it. +So unexpected server behavious should *crash* the test if we are not +dealing with it properly yet and have no unit test for it. -Server responses that we do not expect but handle in the code and test in unit -tests make the test *skip*. +Server responses that we do not expect but handle in the code and test +in unit tests make the test *skip*. The Behaviour we would normally expect should make the test *pass* - |