summaryrefslogtreecommitdiff
path: root/engines
diff options
context:
space:
mode:
authorAzul <azul@riseup.net>2016-05-22 21:11:48 +0200
committerAzul <azul@riseup.net>2016-05-22 21:14:45 +0200
commitb851fe2fd6e0029df81976b647ede7190a1fd547 (patch)
tree2f1335fa1de85d3bf078e0dcc98fa7ce364e67db /engines
parenta1b494e334406660a1f49fb7de9b043493809640 (diff)
make ticket tests pass without network connection
MX validations relied on network connection. Only using them in production environment now. I want to be able to develop and test when disconnected.
Diffstat (limited to 'engines')
-rw-r--r--engines/support/app/models/ticket.rb4
-rw-r--r--engines/support/test/unit/ticket_test.rb4
2 files changed, 5 insertions, 3 deletions
diff --git a/engines/support/app/models/ticket.rb b/engines/support/app/models/ticket.rb
index 4615a10..025e2ab 100644
--- a/engines/support/app/models/ticket.rb
+++ b/engines/support/app/models/ticket.rb
@@ -37,9 +37,11 @@ class Ticket < CouchRest::Model::Base
# email can be nil, "", or valid address.
# validation provided by 'valid_email' gem.
+ # mx validation depends on network availability and is disabled in test
+ # and development environment
validates :email, :allow_blank => true,
:email => true,
- :mx_with_fallback => true
+ :mx_with_fallback => Rails.env.production?
def self.search(options = {})
@selection = TicketSelection.new(options)
diff --git a/engines/support/test/unit/ticket_test.rb b/engines/support/test/unit/ticket_test.rb
index c2c5e11..373f06c 100644
--- a/engines/support/test/unit/ticket_test.rb
+++ b/engines/support/test/unit/ticket_test.rb
@@ -8,12 +8,12 @@ class TicketTest < ActiveSupport::TestCase
test "ticket with default attribs is valid" do
t = FactoryGirl.build :ticket
- assert t.valid?
+ assert t.valid?, t.errors.full_messages.to_sentence
end
test "ticket without email is valid" do
t = FactoryGirl.build :ticket, email: ""
- assert t.valid?
+ assert t.valid?, t.errors.full_messages.to_sentence
end
test "ticket validates email format" do