diff options
| author | Kali Kaneko <kali@leap.se> | 2014-11-07 20:14:51 +0100 |
|---|---|---|
| committer | Kali Kaneko <kali@leap.se> | 2014-11-07 20:14:51 +0100 |
| commit | 571fd912925a76ab35c55b7906d774363b51ce37 (patch) | |
| tree | b3437f3639f3fcd42db050177175b32cb7f3b852 /src | |
| parent | fa5fe88d47dd3e90d8336dbd56e9bf6b38acd811 (diff) | |
Do not use logger.exception during provider checks.
Closes: #6219
leap log handler was choking on the captured exception.
it might have to do with the exception unwinding made by the reactor.
this is a workaround to allow the provider checks to show a meaningful
error message. The backtrace should only be there for development
purpuses, so removing it.
Diffstat (limited to 'src')
| -rw-r--r-- | src/leap/bitmask/provider/providerbootstrapper.py | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/leap/bitmask/provider/providerbootstrapper.py b/src/leap/bitmask/provider/providerbootstrapper.py index 71edbb87..8eefb9d9 100644 --- a/src/leap/bitmask/provider/providerbootstrapper.py +++ b/src/leap/bitmask/provider/providerbootstrapper.py @@ -148,7 +148,6 @@ class ProviderBootstrapper(AbstractBootstrapper): timeout=REQUEST_TIMEOUT) res.raise_for_status() except requests.exceptions.SSLError as exc: - logger.exception(exc) self._err_msg = self.tr("Provider certificate could " "not be verified") raise @@ -156,7 +155,6 @@ class ProviderBootstrapper(AbstractBootstrapper): # XXX careful!. The error might be also a SSL handshake # timeout error, in which case we should retry a couple of times # more, for cases where the ssl server gives high latencies. - logger.exception(exc) self._err_msg = self.tr("Provider does not support HTTPS") raise |