make tests pass + pep8

They were breaking mainly because I did not bother to have a pass
over them to change the PROVIDER settings from the branding case.
All good now, although much testing is yet needed and some refactor
could be used.

long live green tests!

1 files changed, 7 insertions, 3 deletions

diff --git a/src/leap/eip/tests/test_openvpnconnection.py b/src/leap/eip/tests/test_openvpnconnection.py
index 61769f04..0f27facf 100644
--- a/src/leap/eip/tests/test_openvpnconnection.py
+++ b/src/leap/eip/tests/test_openvpnconnection.py
@@ -76,13 +76,17 @@ class OpenVPNConnectionTest(BaseLeapTest):
     #
 
     def test_detect_vpn(self):
+        # XXX review, not sure if captured all the logic
+        # while fixing. kali.
         openvpn_connection = openvpnconnection.OpenVPNConnection()
+
         with patch.object(psutil, "get_process_list") as mocked_psutil:
+            mocked_process = Mock()
+            mocked_process.name = "openvpn"
+            mocked_psutil.return_value = [mocked_process]
             with self.assertRaises(eipexceptions.OpenVPNAlreadyRunning):
-                mocked_process = Mock()
-                mocked_process.name = "openvpn"
-                mocked_psutil.return_value = [mocked_process]
                 openvpn_connection._check_if_running_instance()
+
         openvpn_connection._check_if_running_instance()
 
     @unittest.skipIf(_system == "Windows", "lin/mac only")