#8830 fix onBoot behavior after ui changes

7 files changed, 45 insertions, 26 deletions

diff --git a/app/src/main/java/se/leap/bitmaskclient/ConfigHelper.java b/app/src/main/java/se/leap/bitmaskclient/ConfigHelper.java
index 741a6f56..22965252 100644
--- a/app/src/main/java/se/leap/bitmaskclient/ConfigHelper.java
+++ b/app/src/main/java/se/leap/bitmaskclient/ConfigHelper.java
@@ -21,7 +21,6 @@ import android.support.annotation.NonNull;
 import android.support.annotation.Nullable;
 import android.util.Log;
 
-import org.jetbrains.annotations.NotNull;
 import org.json.JSONException;
 import org.json.JSONObject;
 import org.spongycastle.util.encoders.Base64;
diff --git a/app/src/main/java/se/leap/bitmaskclient/Constants.java b/app/src/main/java/se/leap/bitmaskclient/Constants.java
index 7ee3adab..acfddf5d 100644
--- a/app/src/main/java/se/leap/bitmaskclient/Constants.java
+++ b/app/src/main/java/se/leap/bitmaskclient/Constants.java
@@ -36,7 +36,7 @@ public interface Constants {
     String EIP_ACTION_STOP = "se.leap.bitmaskclient.EIP.STOP";
     String EIP_ACTION_UPDATE = "se.leap.bitmaskclient.EIP.UPDATE";
     String EIP_ACTION_IS_RUNNING = "se.leap.bitmaskclient.EIP.IS_RUNNING";
-    String EIP_ACTION_START_ALWAYS_ON_EIP = "se.leap.bitmaskclient.START_ALWAYS_ON_EIP";
+    String EIP_ACTION_START_ALWAYS_ON_VPN = "se.leap.bitmaskclient.START_ALWAYS_ON_VPN";
     String EIP_ACTION_START_BLOCKING_VPN = "se.leap.bitmaskclient.EIP_ACTION_START_BLOCKING_VPN";
     String EIP_ACTION_STOP_BLOCKING_VPN = "se.leap.bitmaskclient.EIP_ACTION_STOP_BLOCKING_VPN";
 
diff --git a/app/src/main/java/se/leap/bitmaskclient/EipFragment.java b/app/src/main/java/se/leap/bitmaskclient/EipFragment.java
index 4027bc14..5f939a76 100644
--- a/app/src/main/java/se/leap/bitmaskclient/EipFragment.java
+++ b/app/src/main/java/se/leap/bitmaskclient/EipFragment.java
@@ -139,11 +139,6 @@ public class EipFragment extends Fragment implements Observer {
         eipStatus.addObserver(this);
         View view = inflater.inflate(R.layout.eip_service_fragment, container, false);
         ButterKnife.inject(this, view);
-
-        Bundle arguments = getArguments();
-        if (arguments != null && arguments.containsKey(START_EIP_ON_BOOT) && arguments.getBoolean(START_EIP_ON_BOOT)) {
-            startEipFromScratch();
-        }
         return view;
     }
 
diff --git a/app/src/main/java/se/leap/bitmaskclient/OnBootReceiver.java b/app/src/main/java/se/leap/bitmaskclient/OnBootReceiver.java
index 2a8aa42f..95828e46 100644
--- a/app/src/main/java/se/leap/bitmaskclient/OnBootReceiver.java
+++ b/app/src/main/java/se/leap/bitmaskclient/OnBootReceiver.java
@@ -35,14 +35,15 @@ public class OnBootReceiver extends BroadcastReceiver {
                 return;
             }
             if (startOnBoot) {
-                Intent dashboardIntent = new Intent(context, Dashboard.class);
-                dashboardIntent.putExtra(EIP_RESTART_ON_BOOT, true);
-                dashboardIntent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
-                context.startActivity(dashboardIntent);
+                Log.d("OpenVpn", "start StartActivity!");
+                Intent startActivityIntent = new Intent(context, StartActivity.class);
+                startActivityIntent.putExtra(EIP_RESTART_ON_BOOT, true);
+                startActivityIntent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
+                context.startActivity(startActivityIntent);
             }
         } else {
             if (isAlwaysOnConfigured) {
-                Intent dashboardIntent = new Intent(context, Dashboard.class);
+                Intent dashboardIntent = new Intent(context, StartActivity.class);
                 dashboardIntent.putExtra(APP_ACTION_CONFIGURE_ALWAYS_ON_PROFILE, true);
                 dashboardIntent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
                 context.startActivity(dashboardIntent);
diff --git a/app/src/main/java/se/leap/bitmaskclient/StartActivity.java b/app/src/main/java/se/leap/bitmaskclient/StartActivity.java
index f5991538..da59a1fc 100644
--- a/app/src/main/java/se/leap/bitmaskclient/StartActivity.java
+++ b/app/src/main/java/se/leap/bitmaskclient/StartActivity.java
@@ -13,12 +13,17 @@ import java.lang.annotation.Retention;
 import java.lang.annotation.RetentionPolicy;
 
 import de.blinkt.openvpn.core.VpnStatus;
+import se.leap.bitmaskclient.eip.EIP;
 import se.leap.bitmaskclient.userstatus.User;
 
 import static se.leap.bitmaskclient.Constants.APP_ACTION_CONFIGURE_ALWAYS_ON_PROFILE;
+import static se.leap.bitmaskclient.Constants.EIP_ACTION_START;
+import static se.leap.bitmaskclient.Constants.EIP_RECEIVER;
+import static se.leap.bitmaskclient.Constants.EIP_RESTART_ON_BOOT;
 import static se.leap.bitmaskclient.Constants.PREFERENCES_APP_VERSION;
 import static se.leap.bitmaskclient.Constants.REQUEST_CODE_CONFIGURE_LEAP;
 import static se.leap.bitmaskclient.Constants.SHARED_PREFERENCES;
+import static se.leap.bitmaskclient.MainActivity.ACTION_SHOW_VPN_FRAGMENT;
 
 /**
  * Activity shown at startup. Evaluates if App is started for the first time or has been upgraded
@@ -26,7 +31,7 @@ import static se.leap.bitmaskclient.Constants.SHARED_PREFERENCES;
  *
  */
 public class StartActivity extends Activity {
-    public static final String TAG = Dashboard.class.getSimpleName();
+    public static final String TAG = StartActivity.class.getSimpleName();
 
     @Retention(RetentionPolicy.SOURCE)
     @IntDef({FIRST, NORMAL, UPGRADE, DOWNGRADE})
@@ -151,8 +156,12 @@ public class StartActivity extends Activity {
             } else {
                 Log.d(TAG, "vpn provider is configured");
 
-                //buildDashboard(getIntent().getBooleanExtra(EIP_RESTART_ON_BOOT, false));
-//                user_status_fragment.restoreSessionStatus(savedInstanceState);
+                if (getIntent() != null && getIntent().getBooleanExtra(EIP_RESTART_ON_BOOT, false)) {
+                    Log.d(TAG, "start VPN in background");
+                    eipCommand(EIP_ACTION_START);
+                    finish();
+                }
+                Log.d(TAG, "show MainActivity!");
                 showMainActivity();
             }
         } else {
@@ -177,7 +186,6 @@ public class StartActivity extends Activity {
             if (resultCode == RESULT_OK && data.hasExtra(Provider.KEY)) {
                 Provider provider = data.getParcelableExtra(Provider.KEY);
                 ConfigHelper.storeProviderInPreferences(preferences, provider);
-
                 showMainActivity();
             } else if (resultCode == RESULT_CANCELED) {
                 finish();
@@ -187,9 +195,21 @@ public class StartActivity extends Activity {
 
     private void showMainActivity() {
         Intent intent = new Intent(this, MainActivity.class);
-        intent.setAction(MainActivity.ACTION_SHOW_VPN_FRAGMENT);
+        intent.setAction(ACTION_SHOW_VPN_FRAGMENT);
         startActivity(intent);
         finish();
     }
 
+
+    /**
+     * Send a command to EIP
+     *
+     * @param action A valid String constant from EIP class representing an Intent
+     *               filter for the EIP class
+     */
+    private void eipCommand(String action) {
+        Intent vpn_intent = new Intent(this.getApplicationContext(), EIP.class);
+        vpn_intent.setAction(action);
+        this.startService(vpn_intent);
+    }
 }
diff --git a/app/src/main/java/se/leap/bitmaskclient/eip/EIP.java b/app/src/main/java/se/leap/bitmaskclient/eip/EIP.java
index eca5b881..5b7c6e69 100644
--- a/app/src/main/java/se/leap/bitmaskclient/eip/EIP.java
+++ b/app/src/main/java/se/leap/bitmaskclient/eip/EIP.java
@@ -33,11 +33,12 @@ import se.leap.bitmaskclient.OnBootReceiver;
 import static se.leap.bitmaskclient.Constants.EIP_ACTION_CHECK_CERT_VALIDITY;
 import static se.leap.bitmaskclient.Constants.EIP_ACTION_IS_RUNNING;
 import static se.leap.bitmaskclient.Constants.EIP_ACTION_START;
-import static se.leap.bitmaskclient.Constants.EIP_ACTION_START_ALWAYS_ON_EIP;
+import static se.leap.bitmaskclient.Constants.EIP_ACTION_START_ALWAYS_ON_VPN;
 import static se.leap.bitmaskclient.Constants.EIP_ACTION_STOP;
 import static se.leap.bitmaskclient.Constants.EIP_ACTION_UPDATE;
 import static se.leap.bitmaskclient.Constants.EIP_RECEIVER;
 import static se.leap.bitmaskclient.Constants.EIP_REQUEST;
+import static se.leap.bitmaskclient.Constants.EIP_RESTART_ON_BOOT;
 import static se.leap.bitmaskclient.Constants.PROVIDER_KEY;
 import static se.leap.bitmaskclient.Constants.PROVIDER_VPN_CERTIFICATE;
 import static se.leap.bitmaskclient.Constants.SHARED_PREFERENCES;
@@ -90,8 +91,8 @@ public final class EIP extends IntentService {
             case EIP_ACTION_START:
                 startEIP();
                 break;
-            case EIP_ACTION_START_ALWAYS_ON_EIP:
-                startAlwaysOnEIP();
+            case EIP_ACTION_START_ALWAYS_ON_VPN:
+                startEIPAlwaysOnVpn();
                 break;
             case EIP_ACTION_STOP:
                 stopEIP();
@@ -114,6 +115,9 @@ public final class EIP extends IntentService {
      * It also sets up early routes.
      */
     private void startEIP() {
+        if (!preferences.getBoolean(EIP_RESTART_ON_BOOT, false)){
+            preferences.edit().putBoolean(EIP_RESTART_ON_BOOT, true).commit();
+        }
         if (gatewaysManager.isEmpty())
             updateEIPService();
         if (!EipStatus.getInstance().isBlockingVpnEstablished())  {
@@ -132,8 +136,8 @@ public final class EIP extends IntentService {
      * Tries to start the last used vpn profile when the OS was rebooted and always-on-VPN is enabled.
      * The {@link OnBootReceiver} will care if there is no profile.
      */
-    private void startAlwaysOnEIP() {
-        Log.d(TAG, "startAlwaysOnEIP vpn");
+    private void startEIPAlwaysOnVpn() {
+        Log.d(TAG, "startEIPAlwaysOnVpn vpn");
 
         if (gatewaysManager.isEmpty())
             updateEIPService();
@@ -141,10 +145,10 @@ public final class EIP extends IntentService {
         gateway = gatewaysManager.select();
 
         if (gateway != null && gateway.getProfile() != null) {
-            Log.d(TAG, "startAlwaysOnEIP eip launch avtive gateway vpn");
+            Log.d(TAG, "startEIPAlwaysOnVpn eip launch avtive gateway vpn");
             launchActiveGateway();
         } else {
-            Log.d(TAG, "startAlwaysOnEIP no active profile available!");
+            Log.d(TAG, "startEIPAlwaysOnVpn no active profile available!");
         }
     }
 
diff --git a/app/src/main/java/se/leap/bitmaskclient/eip/VoidVpnService.java b/app/src/main/java/se/leap/bitmaskclient/eip/VoidVpnService.java
index 6d49d83d..76d5fb8e 100644
--- a/app/src/main/java/se/leap/bitmaskclient/eip/VoidVpnService.java
+++ b/app/src/main/java/se/leap/bitmaskclient/eip/VoidVpnService.java
@@ -33,7 +33,7 @@ import de.blinkt.openvpn.core.VpnStatus;
 import se.leap.bitmaskclient.R;
 import se.leap.bitmaskclient.VpnNotificationManager;
 
-import static se.leap.bitmaskclient.Constants.EIP_ACTION_START_ALWAYS_ON_EIP;
+import static se.leap.bitmaskclient.Constants.EIP_ACTION_START_ALWAYS_ON_VPN;
 import static se.leap.bitmaskclient.Constants.EIP_ACTION_START_BLOCKING_VPN;
 import static se.leap.bitmaskclient.Constants.EIP_ACTION_STOP_BLOCKING_VPN;
 import static se.leap.bitmaskclient.Constants.EIP_IS_ALWAYS_ON;
@@ -150,7 +150,7 @@ public class VoidVpnService extends VpnService implements Observer, VpnNotificat
 
     private void requestVpnWithLastSelectedProfile() {
         Intent startEIP = new Intent(getApplicationContext(), EIP.class);
-        startEIP.setAction(EIP_ACTION_START_ALWAYS_ON_EIP);
+        startEIP.setAction(EIP_ACTION_START_ALWAYS_ON_VPN);
         getApplicationContext().startService(startEIP);
     }