[bug] reuse wsgi threadpool

it seems evident that the functions were thought to pass a threadpool
along, but it finally wasn't properly passed and so there was a new
threadpool created to handle every resource.

I have removed the creation from the factory because I don't think it
makes sense to create a threadpool on the fly, it's prone to errors.

- Resolves: #8774

1 files changed, 4 insertions, 3 deletions

diff --git a/server/src/leap/soledad/server/auth.py b/server/src/leap/soledad/server/auth.py
index e064341b..b5744fe9 100644
--- a/server/src/leap/soledad/server/auth.py
+++ b/server/src/leap/soledad/server/auth.py
@@ -48,8 +48,9 @@ log = Logger()
 @implementer(IRealm)
 class SoledadRealm(object):
 
-    def __init__(self, conf=None, sync_pool=None):
-        if not conf:
+    def __init__(self, sync_pool, conf=None):
+        assert sync_pool is not None
+        if conf is None:
             conf = get_config()
         blobs = conf['blobs']
         self.anon_resource = SoledadAnonResource(
@@ -160,7 +161,7 @@ class TokenCredentialFactory(object):
             raise error.LoginFailed('Invalid credentials')
 
 
-def portalFactory(sync_pool=None):
+def portalFactory(sync_pool):
     realm = SoledadRealm(sync_pool=sync_pool)
     checker = TokenChecker()
     return Portal(realm, [checker])