summaryrefslogtreecommitdiff
path: root/common
diff options
context:
space:
mode:
authorKali Kaneko <kali@leap.se>2015-07-22 12:36:41 -0400
committerKali Kaneko <kali@leap.se>2015-07-22 16:40:24 -0400
commit82c8989ddbcc57befca806495b7040efd0cb0d4e (patch)
tree07d9d59bda1b461ee4ed2857bc4d022449770c08 /common
parent8074dcfff4bf2304d581efe8a01174a2dd1288eb (diff)
[pkg] separate leap requirements
this is part of a process to make the setup of the development mode less troublesome. from now on, setting up a virtualenv in pure development mode will be as easy as telling pip to just install the external dependencies:: pip install -r pkg/requirements.pip and traversing all the leap repos for the needed leap dependencies doing:: python setup.py develop - Related: #7288
Diffstat (limited to 'common')
-rw-r--r--common/pkg/requirements-leap.pip1
-rw-r--r--common/pkg/requirements.pip3
-rw-r--r--common/pkg/utils.py29
-rw-r--r--common/setup.py18
4 files changed, 41 insertions, 10 deletions
diff --git a/common/pkg/requirements-leap.pip b/common/pkg/requirements-leap.pip
new file mode 100644
index 00000000..b311859e
--- /dev/null
+++ b/common/pkg/requirements-leap.pip
@@ -0,0 +1 @@
+leap.common>=0.4.0
diff --git a/common/pkg/requirements.pip b/common/pkg/requirements.pip
index b91186e7..287741d2 100644
--- a/common/pkg/requirements.pip
+++ b/common/pkg/requirements.pip
@@ -1,9 +1,6 @@
simplejson
u1db
-# leap deps -- bump me!
-leap.common>=0.4.0
-
# XXX -- fix me!
# oauth is not strictly needed by us, but we need it until u1db adds it to its
# release as a dep.
diff --git a/common/pkg/utils.py b/common/pkg/utils.py
index deace14b..d1680102 100644
--- a/common/pkg/utils.py
+++ b/common/pkg/utils.py
@@ -14,20 +14,34 @@
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
-
"""
Utils to help in the setup process
"""
-
import os
import re
import sys
+def is_develop_mode():
+ """
+ Returns True if we're calling the setup script using the argument for
+ setuptools development mode.
+
+ This avoids messing up with dependency pinning and order, the
+ responsibility of installing the leap dependencies is left to the
+ developer.
+ """
+ args = sys.argv
+ devflags = "setup.py", "develop"
+ if (args[0], args[1]) == devflags:
+ return True
+ return False
+
+
def get_reqs_from_files(reqfiles):
"""
Returns the contents of the top requirement file listed as a
- string list with the lines
+ string list with the lines.
@param reqfiles: requirement files to parse
@type reqfiles: list of str
@@ -43,6 +57,9 @@ def parse_requirements(reqfiles=['requirements.txt',
"""
Parses the requirement files provided.
+ The passed reqfiles list is a list of possible locations to try, the
+ function will return the contents of the first path found.
+
Checks the value of LEAP_VENV_SKIP_PYSIDE to see if it should
return PySide as a dep or not. Don't set, or set to 0 if you want
to install it through pip.
@@ -58,9 +75,9 @@ def parse_requirements(reqfiles=['requirements.txt',
if re.match(r'\s*-e\s+', line):
pass
# do not try to do anything with externals on vcs
- #requirements.append(re.sub(r'\s*-e\s+.*#egg=(.*)$', r'\1',
- #line))
- # http://foo.bar/baz/foobar/zipball/master#egg=foobar
+ # requirements.append(re.sub(r'\s*-e\s+.*#egg=(.*)$', r'\1',
+ # line))
+ # http://foo.bar/baz/foobar/zipball/master#egg=foobar
elif re.match(r'\s*https?:', line):
requirements.append(re.sub(r'\s*https?:.*#egg=(.*)$', r'\1',
line))
diff --git a/common/setup.py b/common/setup.py
index f4d8bc65..49d94dad 100644
--- a/common/setup.py
+++ b/common/setup.py
@@ -250,6 +250,22 @@ cmdclass["develop"] = cmd_develop
# XXX add ref to docs
+requirements = utils.parse_requirements()
+
+if utils.is_develop_mode():
+ print
+ print ("[WARNING] Skipping leap-specific dependencies "
+ "because development mode is detected.")
+ print ("[WARNING] You can install "
+ "the latest published versions with "
+ "'pip install -r pkg/requirements-leap.pip'")
+ print ("[WARNING] Or you can instead do 'python setup.py develop' "
+ "from the parent folder of each one of them.")
+ print
+else:
+ requirements += utils.parse_requirements(
+ reqfiles=["pkg/requirements-leap.pip"])
+
setup(
name='leap.soledad.common',
version=VERSION,
@@ -273,7 +289,7 @@ setup(
packages=find_packages('src', exclude=['*.tests', '*.tests.*']),
package_dir={'': 'src'},
test_suite='leap.soledad.common.tests',
- install_requires=utils.parse_requirements(),
+ install_requires=requirements,
tests_require=utils.parse_requirements(
reqfiles=['pkg/requirements-testing.pip']),
extras_require={