diff options
| author | drebs <drebs@leap.se> | 2016-05-01 13:34:33 -0300 |
|---|---|---|
| committer | Kali Kaneko <kali@leap.se> | 2016-06-06 19:58:50 -0400 |
| commit | 06f3c80e848b14d3fff1a6edd2cd58f998b976db (patch) | |
| tree | 8b4748aa73a3f9329c6bcf17f582c921bbce7d7d /client/changes | |
| parent | 9eac24ba91ccbbd335e2cf6d8f59c518659348e6 (diff) | |
[bug] remove doc content conversion to unicode
Theoretically (until now), Soledad inherits from U1DB the behaviour of only
accepting valid JSON for documents contents. JSON documents only allow for
unicode strings. Despite that, until now we had implemented lossy convertion
to unicode to avoid encoding errors when dumping/loading JSON content. This
allowed for API users to pass non-unicode to Soledad, but caused the
application to take more time because of conversion.
There were 2 problem with this: (1) conversion may take a long time and a lot
of memory when convertin large payloads; and (2) conversion was being made
before deferring to the adbapi, and this was blocking the reactor.
This commit completelly removes the conversion to unicode, thus leaving the
responsibility of unicode conversion to users of the Soledad API.
Diffstat (limited to 'client/changes')
| -rw-r--r-- | client/changes/next-changelog.rst | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/client/changes/next-changelog.rst b/client/changes/next-changelog.rst index 6e97386c..050d84be 100644 --- a/client/changes/next-changelog.rst +++ b/client/changes/next-changelog.rst @@ -16,6 +16,8 @@ Features Bugfixes ~~~~~~~~ - `#1235 <https://leap.se/code/issues/1235>`_: Description for the fixed stuff corresponding with issue #1235. +- Remove document content conversion to unicode. Users of API are responsible + for only passing valid JSON to Soledad for storage. - Bugfix without related issue number. Misc |