diff options
author | Tulio Casagrande <tcasagra@thoughtworks.com> | 2016-10-04 18:40:33 -0300 |
---|---|---|
committer | Tulio Casagrande <tcasagra@thoughtworks.com> | 2016-10-12 10:45:44 -0300 |
commit | 2b6a0e8d7168b20f86d585ebc4e57b61b1bb9cf9 (patch) | |
tree | 0cb96679f6e7f98121e524ab4602f57ebc158ed2 /HISTORY | |
parent | 4e06eb370b99f2d343e96f774a3ad9b8b77c9548 (diff) |
[bug] remove finalClose from SQLCipherU1DBSync
We discovered that class was registering a `finalClose` to be
executed on reactor shutdown.
On the multiuser scenario, a logout destroys Soledad and should
properly terminate everything related to it. That SQLCipherU1DBSync
instance was being held even after logout by the reactor so it
could call that `finalClose` on shutdown.
The `finalClose` only set running to False and set a `shutdownID` that
was not used anywhere else, so we removed it and moved setting
running to False to the `close` function method. That way we preserve
the functionality but let the instance be properly garbage collected
on logout.
Diffstat (limited to 'HISTORY')
0 files changed, 0 insertions, 0 deletions