<feed xmlns='http://www.w3.org/2005/Atom'>
<title>soledad.git/client/src/leap, branch 0.9.0rc1</title>
<subtitle>[soledad]
</subtitle>
<link rel='alternate' type='text/html' href='https://leap.se/git/soledad.git/'/>
<entry>
<title>[bug] remove finalClose from SQLCipherU1DBSync</title>
<updated>2016-10-12T13:45:44+00:00</updated>
<author>
<name>Tulio Casagrande</name>
<email>tcasagra@thoughtworks.com</email>
</author>
<published>2016-10-04T21:40:33+00:00</published>
<link rel='alternate' type='text/html' href='https://leap.se/git/soledad.git/commit/?id=2b6a0e8d7168b20f86d585ebc4e57b61b1bb9cf9'/>
<id>2b6a0e8d7168b20f86d585ebc4e57b61b1bb9cf9</id>
<content type='text'>
We discovered that class was registering a `finalClose` to be
executed on reactor shutdown.

On the multiuser scenario, a logout destroys Soledad and should
properly terminate everything related to it. That SQLCipherU1DBSync
instance was being held even after logout by the reactor so it
could call that `finalClose` on shutdown.

The `finalClose` only set running to False and set a `shutdownID` that
was not used anywhere else, so we removed it and moved setting
running to False to the `close` function method. That way we preserve
the functionality but let the instance be properly garbage collected
on logout.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We discovered that class was registering a `finalClose` to be
executed on reactor shutdown.

On the multiuser scenario, a logout destroys Soledad and should
properly terminate everything related to it. That SQLCipherU1DBSync
instance was being held even after logout by the reactor so it
could call that `finalClose` on shutdown.

The `finalClose` only set running to False and set a `shutdownID` that
was not used anywhere else, so we removed it and moved setting
running to False to the `close` function method. That way we preserve
the functionality but let the instance be properly garbage collected
on logout.
</pre>
</div>
</content>
</entry>
<entry>
<title>[bug] use % for formatting</title>
<updated>2016-09-30T18:54:39+00:00</updated>
<author>
<name>Victor Shyba</name>
<email>victor.shyba@gmail.com</email>
</author>
<published>2016-09-30T18:40:54+00:00</published>
<link rel='alternate' type='text/html' href='https://leap.se/git/soledad.git/commit/?id=0c89333460953413033154e60da2ddb9cc1aed55'/>
<id>0c89333460953413033154e60da2ddb9cc1aed55</id>
<content type='text'>
Otherwise it will put the exception as an additional parameter.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Otherwise it will put the exception as an additional parameter.
</pre>
</div>
</content>
</entry>
<entry>
<title>[style] standardize log messages</title>
<updated>2016-09-22T20:58:18+00:00</updated>
<author>
<name>drebs</name>
<email>drebs@leap.se</email>
</author>
<published>2016-09-22T18:32:34+00:00</published>
<link rel='alternate' type='text/html' href='https://leap.se/git/soledad.git/commit/?id=b1a7b538ab851c9e1aab3be5ba31411d658a4773'/>
<id>b1a7b538ab851c9e1aab3be5ba31411d658a4773</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>[feat] centralize logging and use twisted.logger by default</title>
<updated>2016-09-22T20:57:40+00:00</updated>
<author>
<name>drebs</name>
<email>drebs@leap.se</email>
</author>
<published>2016-09-22T17:44:46+00:00</published>
<link rel='alternate' type='text/html' href='https://leap.se/git/soledad.git/commit/?id=b7340a962bfeae9af28c4b514d0eb077f41dd832'/>
<id>b7340a962bfeae9af28c4b514d0eb077f41dd832</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>[bug] fail gracefully if dbsyncer has not been initialized</title>
<updated>2016-09-02T19:33:41+00:00</updated>
<author>
<name>Kali Kaneko</name>
<email>kali@leap.se</email>
</author>
<published>2016-09-01T04:55:26+00:00</published>
<link rel='alternate' type='text/html' href='https://leap.se/git/soledad.git/commit/?id=6b283761de3a845d09de20fcc2b6a4a63130e45f'/>
<id>6b283761de3a845d09de20fcc2b6a4a63130e45f</id>
<content type='text'>
this is needed for some mail tests.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
this is needed for some mail tests.
</pre>
</div>
</content>
</entry>
<entry>
<title>[doc] improve SQLITE_MAX_VARIABLE_NUMBER comments</title>
<updated>2016-08-23T18:48:55+00:00</updated>
<author>
<name>Victor Shyba</name>
<email>victor.shyba@gmail.com</email>
</author>
<published>2016-08-23T18:48:55+00:00</published>
<link rel='alternate' type='text/html' href='https://leap.se/git/soledad.git/commit/?id=eaf8907696a7b5ae0b1411f0770f59c0ed5f9fc4'/>
<id>eaf8907696a7b5ae0b1411f0770f59c0ed5f9fc4</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>[bug] limit pool comnsumption to 900 docs</title>
<updated>2016-08-22T15:36:16+00:00</updated>
<author>
<name>Victor Shyba</name>
<email>victor.shyba@gmail.com</email>
</author>
<published>2016-08-20T03:44:02+00:00</published>
<link rel='alternate' type='text/html' href='https://leap.se/git/soledad.git/commit/?id=062d781b734db60d0ae317eaf5b86c7d75abacd9'/>
<id>062d781b734db60d0ae317eaf5b86c7d75abacd9</id>
<content type='text'>
This was discovered during load tests: Trying to process more than 999
docs triggers an error on SQLite due a select query not supporting 999
values to query.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This was discovered during load tests: Trying to process more than 999
docs triggers an error on SQLite due a select query not supporting 999
values to query.
</pre>
</div>
</content>
</entry>
<entry>
<title>[test] avoid race condition on test_processing_order</title>
<updated>2016-08-02T14:51:14+00:00</updated>
<author>
<name>Victor Shyba</name>
<email>victor.shyba@gmail.com</email>
</author>
<published>2016-08-02T03:07:13+00:00</published>
<link rel='alternate' type='text/html' href='https://leap.se/git/soledad.git/commit/?id=1c8b39b808a5d5b56f5463d29ad1a7e901bf84d5'/>
<id>1c8b39b808a5d5b56f5463d29ad1a7e901bf84d5</id>
<content type='text'>
test_processing_order aims to check that unordered docs wont be
processed, but if we let the pool start and advance Twisted LoopingCall
clock right before calling the processing method manually, the process
method will run concurrently and cause a race condition issue.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
test_processing_order aims to check that unordered docs wont be
processed, but if we let the pool start and advance Twisted LoopingCall
clock right before calling the processing method manually, the process
method will run concurrently and cause a race condition issue.
</pre>
</div>
</content>
</entry>
<entry>
<title>[style] pep8</title>
<updated>2016-07-13T17:36:14+00:00</updated>
<author>
<name>Kali Kaneko</name>
<email>kali@leap.se</email>
</author>
<published>2016-07-13T17:36:14+00:00</published>
<link rel='alternate' type='text/html' href='https://leap.se/git/soledad.git/commit/?id=7d264548d6df756f2a157fe59cf58b3240825418'/>
<id>7d264548d6df756f2a157fe59cf58b3240825418</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>[refactor] make u1db connection pool args explicit</title>
<updated>2016-07-12T01:09:33+00:00</updated>
<author>
<name>drebs</name>
<email>drebs@leap.se</email>
</author>
<published>2016-07-10T08:38:04+00:00</published>
<link rel='alternate' type='text/html' href='https://leap.se/git/soledad.git/commit/?id=f406ccbaf2b79db1d65827463f830f4ffbe5856c'/>
<id>f406ccbaf2b79db1d65827463f830f4ffbe5856c</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
