From 481cbe15a83fb397aa023c97aaf5ec19ee2f0632 Mon Sep 17 00:00:00 2001
From: 5Ub-Z3r0 <5ub-z3r0@nikorasu.net>
Date: Wed, 10 Oct 2012 17:38:03 +0300
Subject: Add support for master svn repositories
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Pull request related to issue #8331.
I have added support into the exists? method (actually working_copy_exists?) for checking if the path is a master repository, using svnlook. It should be ok in most cases, since svnlook comes with svnadmin in nearly every distribution.
---
 lib/puppet/provider/vcsrepo/svn.rb            | 13 +++++++++++--
 spec/unit/puppet/provider/vcsrepo/svn_spec.rb |  1 +
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/lib/puppet/provider/vcsrepo/svn.rb b/lib/puppet/provider/vcsrepo/svn.rb
index 7485ff5..0c911bf 100644
--- a/lib/puppet/provider/vcsrepo/svn.rb
+++ b/lib/puppet/provider/vcsrepo/svn.rb
@@ -4,7 +4,8 @@ Puppet::Type.type(:vcsrepo).provide(:svn, :parent => Puppet::Provider::Vcsrepo)
   desc "Supports Subversion repositories"
 
   optional_commands :svn      => 'svn',
-                    :svnadmin => 'svnadmin'
+                    :svnadmin => 'svnadmin',
+                    :svnlook  => 'svnlook'
 
   has_features :filesystem_types, :reference_tracking, :basic_auth, :configuration
 
@@ -20,7 +21,15 @@ Puppet::Type.type(:vcsrepo).provide(:svn, :parent => Puppet::Provider::Vcsrepo)
   end
 
   def working_copy_exists?
-    File.directory?(File.join(@resource.value(:path), '.svn'))
+    if File.directory?(@resource.value(:path))
+      if File.directory?(File.join(@resource.value(:path), '.svn'))
+        return true
+      end
+      if svnlook('uuid',@resource.value(:path))
+        return true
+      end
+    end
+    return false
   end
 
   def exists?
diff --git a/spec/unit/puppet/provider/vcsrepo/svn_spec.rb b/spec/unit/puppet/provider/vcsrepo/svn_spec.rb
index 75d58f9..a533b7c 100644
--- a/spec/unit/puppet/provider/vcsrepo/svn_spec.rb
+++ b/spec/unit/puppet/provider/vcsrepo/svn_spec.rb
@@ -49,6 +49,7 @@ describe_provider :vcsrepo, :svn, :resource => {:path => '/tmp/vcsrepo'} do
 
   describe "checking existence" do
     it "should check for the directory" do
+      expects_directory?(true, resource.value(:path))
       expects_directory?(true, File.join(resource.value(:path), '.svn'))
       provider.exists?
     end
-- 
cgit v1.2.3


From a2ef96e0de924d43b2cb56ac8fd979c9eee59d72 Mon Sep 17 00:00:00 2001
From: Aaron Stone <aaron@serendipity.cx>
Date: Fri, 19 Jul 2013 12:35:23 -0700
Subject: Style and comments

---
 lib/puppet/provider/vcsrepo/svn.rb | 20 +++++++-------------
 1 file changed, 7 insertions(+), 13 deletions(-)

diff --git a/lib/puppet/provider/vcsrepo/svn.rb b/lib/puppet/provider/vcsrepo/svn.rb
index 0c911bf..3132c36 100644
--- a/lib/puppet/provider/vcsrepo/svn.rb
+++ b/lib/puppet/provider/vcsrepo/svn.rb
@@ -22,14 +22,12 @@ Puppet::Type.type(:vcsrepo).provide(:svn, :parent => Puppet::Provider::Vcsrepo)
 
   def working_copy_exists?
     if File.directory?(@resource.value(:path))
-      if File.directory?(File.join(@resource.value(:path), '.svn'))
-        return true
-      end
-      if svnlook('uuid',@resource.value(:path))
-        return true
-      end
+      # :path is an svn checkout
+      return true if File.directory?(File.join(@resource.value(:path), '.svn'))
+      # :path is an svn server
+      return true if svnlook('uuid', @resource.value(:path))
     end
-    return false
+    false
   end
 
   def exists?
@@ -42,11 +40,7 @@ Puppet::Type.type(:vcsrepo).provide(:svn, :parent => Puppet::Provider::Vcsrepo)
 
   def latest?
     at_path do
-      if self.revision < self.latest then
-        return false
-      else
-        return true
-      end
+      self.revision >= self.latest
     end
   end
 
@@ -66,7 +60,7 @@ Puppet::Type.type(:vcsrepo).provide(:svn, :parent => Puppet::Provider::Vcsrepo)
       args.push('--config-dir', @resource.value(:configuration))
     end
 
-    return args
+    args
   end
 
   def latest
-- 
cgit v1.2.3