From abdcd73c60eac610a23125ae12ec3d775013496a Mon Sep 17 00:00:00 2001 From: Justin Ellison Date: Wed, 17 Aug 2011 10:07:40 -0500 Subject: Adding basic_auth feature and adding --non-interactive to all svn commands. The basic_auth feature allows the manifest to specify an optional basic_auth_username and basic_auth_password to be sent to the subversion server over HTTP(S). Adding --non-interactive to all svn commands just lets svn know that there's not a user on the other end to send y/n questions. --- lib/puppet/provider/vcsrepo/svn.rb | 25 +++++++++++++++++++------ 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/lib/puppet/provider/vcsrepo/svn.rb b/lib/puppet/provider/vcsrepo/svn.rb index 680188c..53daf53 100644 --- a/lib/puppet/provider/vcsrepo/svn.rb +++ b/lib/puppet/provider/vcsrepo/svn.rb @@ -7,7 +7,7 @@ Puppet::Type.type(:vcsrepo).provide(:svn, :parent => Puppet::Provider::Vcsrepo) :svnadmin => 'svnadmin' defaultfor :svn => :exists - has_features :filesystem_types, :reference_tracking + has_features :filesystem_types, :reference_tracking, :basic_auth def create if !@resource.value(:source) @@ -40,29 +40,42 @@ Puppet::Type.type(:vcsrepo).provide(:svn, :parent => Puppet::Provider::Vcsrepo) end end end + + def buildargs + args = ['--non-interactive'] + if @resource.value(:basic_auth_username) && @resource.value(:basic_auth_password) + args.push('--username', @resource.value(:basic_auth_username)) + args.push('--password', @resource.value(:basic_auth_password)) + args.push('--no-auth-cache') + end + return args + end def latest + args = buildargs.push('info', '-r', 'HEAD') at_path do - svn('info', '-r', 'HEAD')[/^Revision:\s+(\d+)/m, 1] + svn(*args)[/^Revision:\s+(\d+)/m, 1] end end def revision + args = buildargs.push('info') at_path do - svn('info')[/^Revision:\s+(\d+)/m, 1] + svn(*args)[/^Revision:\s+(\d+)/m, 1] end end def revision=(desired) + args = buildargs.push('update', '-r', desired) at_path do - svn('update', '-r', desired) + svn(*args) end end private - def checkout_repository(source, path, revision = nil) - args = ['checkout'] + def checkout_repository(source, path, revision) + args = buildargs.push('checkout') if revision args.push('-r', revision) end -- cgit v1.2.3 From d84d3e29c9e3f1d9771e5df5ab659e16513a9a06 Mon Sep 17 00:00:00 2001 From: Justin Ellison Date: Thu, 18 Aug 2011 08:30:09 -0500 Subject: Forgot to add the parameters to the type definition. --- lib/puppet/type/vcsrepo.rb | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/lib/puppet/type/vcsrepo.rb b/lib/puppet/type/vcsrepo.rb index 6b35779..9bf8311 100644 --- a/lib/puppet/type/vcsrepo.rb +++ b/lib/puppet/type/vcsrepo.rb @@ -5,7 +5,8 @@ Puppet::Type.newtype(:vcsrepo) do feature :gzip_compression, "The provider supports explicit GZip compression levels" - + feature :basic_auth, + "The provider supports HTTP Basic Authentication" feature :bare_repositories, "The provider differentiates between bare repositories and those with working copies", @@ -136,6 +137,14 @@ Puppet::Type.newtype(:vcsrepo) do end end + newparam :basic_auth_username, :required_features => [:basic_auth] do + desc "HTTP Basic Auth username" + end + + newparam :basic_auth_password, :required_features => [:basic_auth] do + desc "HTTP Basic Auth password" + end + newparam :identity, :required_features => [:ssh_identity] do desc "SSH identity file" end -- cgit v1.2.3