Overhaul the spec tests to work in rspec2.
[puppet_vcsrepo.git] / spec / unit / puppet / provider / vcsrepo / bzr_spec.rb
index d39b858..488ddc0 100644 (file)
-require 'pathname'; Pathname.new(__FILE__).realpath.ascend { |x| begin; require (x + 'spec_helper.rb'); break; rescue LoadError; end }
+require 'spec_helper'
 
-provider_class = Puppet::Type.type(:vcsrepo).provider(:bzr)
+describe Puppet::Type.type(:vcsrepo).provider(:bzr_provider) do
 
-describe provider_class do
+  let(:resource) { Puppet::Type.type(:vcsrepo).new({
+    :name     => 'test',
+    :ensure   => :present,
+    :provider => :bzr,
+    :revision => '2634',
+    :source   => 'lp:do',
+    :path     => '/tmp/test',
+  })}
+
+  let(:provider) { resource.provider }
 
   before :each do
-    @resource = stub("resource")
-    @provider = provider_class.new(@resource)
-    @path = '/tmp/vcsrepo'
+    Puppet::Util.stubs(:which).with('bzr').returns('/usr/bin/bzr')
   end
 
-  describe 'when creating' do
-    before do
-      @resource.expects(:value).with(:path).returns(@path).at_least_once
-    end
-    context "when a source is given" do
-      before do
-        @source = 'http://example.com/bzr/repo'
-        @resource.expects(:value).with(:source).returns(@source).at_least_once
-      end
-      context "and when a revision is given" do
-        before do
-          @revision = 'somerev'
-          @resource.expects(:value).with(:revision).returns(@revision).at_least_once
-        end
-        it "should execute 'bzr clone -r' with the revision" do
-          @provider.expects(:bzr).with('branch', '-r', @revision, @source, @path)
-          @provider.create
-        end
-      end
-      context "and when a revision is not given" do
-        before do
-          @resource.expects(:value).with(:revision).returns(nil).at_least_once
-        end
-        it "should just execute 'bzr clone' without a revision" do
-          @provider.expects(:bzr).with('branch', @source, @path)
-          @provider.create
-        end
+  describe 'creating' do
+    context 'with defaults' do
+      it "should execute 'bzr clone -r' with the revision" do
+        provider.expects(:bzr).with('branch', '-r', resource.value(:revision), resource.value(:source), resource.value(:path))
+        provider.create
       end
     end
-    context "when a source is not given" do
-      before do
-        @resource.expects(:value).with(:source).returns(nil).at_least_once
+
+    context 'without revision' do
+      it "should just execute 'bzr clone' without a revision" do
+        resource.delete(:revision)
+        provider.expects(:bzr).with('branch', resource.value(:source), resource.value(:path))
+        provider.create
       end
+    end
+
+    context 'without source' do
       it "should execute 'bzr init'" do
-        @provider.expects(:bzr).with('init', @path)
-        @provider.create
+        resource.delete(:source)
+        provider.expects(:bzr).with('init', resource.value(:path))
+        provider.create
       end
     end
   end
 
-  describe 'when destroying' do
+  describe 'destroying' do
     it "it should remove the directory" do
-      @resource.expects(:value).with(:path).returns(@path).at_least_once
-      FileUtils.expects(:rm_rf).with(@path)
-      @provider.destroy
+      provider.destroy
     end
   end
 
-  describe "when checking existence" do
-    before do
-      @resource.expects(:value).with(:path).returns(@path)
-    end
+  describe "checking existence" do
     it "should check for the directory" do
-      File.expects(:directory?).with(File.join(@path, '.bzr'))
-      @provider.exists?
+      File.expects(:directory?).with(File.join(resource.value(:path), '.bzr')).returns(true)
+      provider.exists?
     end
   end
 
-  describe "when checking the revision property" do
+  describe "checking the revision property" do
     before do
-      @resource.expects(:value).with(:path).returns(@path).at_least_once
-      Dir.expects(:chdir).with(@path).yields
-      @provider.expects(:bzr).with('version-info').returns(fixture(:bzr_version_info))
+      expects_chdir
+      provider.expects(:bzr).with('version-info').returns(File.read(fixtures('bzr_version_info.txt')))
       @current_revid = 'menesis@pov.lt-20100309191856-4wmfqzc803fj300x'
-      @current_revno = '2634'
     end
+
     context "when given a non-revid as the resource revision" do
       context "when its revid is not different than the current revid" do
-        before do
-          @revision = @current_revno
-          @resource.expects(:value).with(:revision).returns(@revision).at_least_once
-        end
         it "should return the ref" do
-          @provider.expects(:bzr).with('revision-info', @revision).returns("#{@current_revno} #{@current_revid}\n")
-          @provider.revision.should == @revision
+          resource[:revision] = '2634'
+          provider.expects(:bzr).with('revision-info', '2634').returns("2634 menesis@pov.lt-20100309191856-4wmfqzc803fj300x\n")
+          provider.revision.should == resource.value(:revision)
         end
       end
       context "when its revid is different than the current revid" do
-        before do
-          @revision = '2636'
-          @resource.expects(:value).with(:revision).returns(@revision).at_least_once
-        end
         it "should return the current revid" do
-          @provider.expects(:bzr).with('revision-info', @revision).returns("#{@revision} menesis@pov.lt-20100309191856-4wmfqzc803fj300y\n")
-          @provider.revision.should == @current_revid
-        end          
+          resource[:revision] = '2636'
+          provider.expects(:bzr).with('revision-info', resource.value(:revision)).returns("2635 foo\n")
+          provider.revision.should == @current_revid
+        end
       end
     end
+
     context "when given a revid as the resource revision" do
       context "when it is the same as the current revid" do
-        before do
-          @revision = @current_revid
-          @resource.expects(:value).with(:revision).returns(@revision).at_least_once
-        end
         it "should return it" do
-          @provider.expects(:bzr).with('revision-info', @revision).returns("#{@current_revno} #{@current_revid}\n")
-          @provider.revision.should == @revision
+          resource[:revision] = 'menesis@pov.lt-20100309191856-4wmfqzc803fj300x'
+          provider.expects(:bzr).with('revision-info', resource.value(:revision)).returns("1234 #{resource.value(:revision)}\n")
+          provider.revision.should == resource.value(:revision)
         end
       end
       context "when it is not the same as the current revid" do
-        before do
-          @revision = 'menesis@pov.lt-20100309191856-4wmfqzc803fj300y'
-          @resource.expects(:value).with(:revision).returns(@revision).at_least_once
-        end
         it "should return the current revid" do
-          @provider.expects(:bzr).with('revision-info', @revision).returns("2636 #{@revision}\n")
-          @provider.revision.should == @current_revid
+          resource[:revision] = 'menesis@pov.lt-20100309191856-4wmfqzc803fj300y'
+          provider.expects(:bzr).with('revision-info', resource.value(:revision)).returns("2636 foo\n")
+          provider.revision.should == @current_revid
         end
       end
+
     end
   end
-  
-  describe "when setting the revision property" do
-    before do
-      @resource.expects(:value).with(:path).returns(@path).at_least_once
-      @revision = 'somerev'
-    end
+
+  describe "setting the revision property" do
     it "should use 'bzr update -r' with the revision" do
-      @provider.expects('bzr').with('update', '-r', @revision, @path)
-      @provider.revision = @revision
+      Dir.expects(:chdir).with('/tmp/test').at_least_once.yields
+      provider.expects(:bzr).with('update', '-r', 'somerev')
+      provider.revision = 'somerev'
     end
   end