From 10767a0016b0f46aceab9ac97738390035a112dc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Louis-Philippe=20V=C3=A9ronneau?= Date: Wed, 11 Oct 2017 15:52:10 -0400 Subject: copy CI infra from the shared apt module as-is --- spec/acceptance/apt_spec.rb | 21 ++++++ .../acceptance/nodesets/debian-8-x86_64-docker.yml | 19 +++++ spec/acceptance/nodesets/default.yml | 1 + spec/classes/init_spec.rb | 18 +++++ spec/defines/conf_spec.rb | 74 +++++++++++++++++++ spec/defines/preferences_snippet_spec.rb | 66 +++++++++++++++++ spec/spec_helper.rb | 12 +++ spec/spec_helper_acceptance.rb | 18 +++++ spec/unit/custom_facts_spec.rb | 86 ++++++++++++++++++++++ 9 files changed, 315 insertions(+) create mode 100644 spec/acceptance/apt_spec.rb create mode 100644 spec/acceptance/nodesets/debian-8-x86_64-docker.yml create mode 120000 spec/acceptance/nodesets/default.yml create mode 100644 spec/classes/init_spec.rb create mode 100644 spec/defines/conf_spec.rb create mode 100644 spec/defines/preferences_snippet_spec.rb create mode 100644 spec/spec_helper.rb create mode 100644 spec/spec_helper_acceptance.rb create mode 100644 spec/unit/custom_facts_spec.rb (limited to 'spec') diff --git a/spec/acceptance/apt_spec.rb b/spec/acceptance/apt_spec.rb new file mode 100644 index 0000000..a976a56 --- /dev/null +++ b/spec/acceptance/apt_spec.rb @@ -0,0 +1,21 @@ +require 'spec_helper_acceptance' + +describe 'apt class' do + + context 'default parameters' do + it 'should work idempotently with no errors' do + pp = <<-EOS + class { 'apt': } + EOS + + # Run it twice and test for idempotency + apply_manifest(pp, :catch_failures => true) + apply_manifest(pp, :catch_changes => true) + end + + describe package('apt') do + it { is_expected.to be_installed } + end + + end +end diff --git a/spec/acceptance/nodesets/debian-8-x86_64-docker.yml b/spec/acceptance/nodesets/debian-8-x86_64-docker.yml new file mode 100644 index 0000000..f09ad62 --- /dev/null +++ b/spec/acceptance/nodesets/debian-8-x86_64-docker.yml @@ -0,0 +1,19 @@ +HOSTS: + debian-8-x64: + platform: debian-8-amd64 + image: debian:8 + hypervisor: docker + docker_preserve_image: true + docker_cmd: '["/sbin/init"]' + docker_image_commands: + - 'apt-get install -y wget locales-all puppet git' + - 'rm -f /usr/sbin/policy-rc.d' + +CONFIG: + type: foss + #log_level: verbose + #log_level: debug + +ssh: + password: root + auth_methods: ["password"] diff --git a/spec/acceptance/nodesets/default.yml b/spec/acceptance/nodesets/default.yml new file mode 120000 index 0000000..b125a96 --- /dev/null +++ b/spec/acceptance/nodesets/default.yml @@ -0,0 +1 @@ +debian-8-x86_64-docker.yml \ No newline at end of file diff --git a/spec/classes/init_spec.rb b/spec/classes/init_spec.rb new file mode 100644 index 0000000..9ba554f --- /dev/null +++ b/spec/classes/init_spec.rb @@ -0,0 +1,18 @@ +require 'spec_helper' + +describe 'apt', :type => :class do + let :pre_condition do + 'class { "apt": }' + end + let(:facts) { { + :lsbdistid => 'Debian', + :osfamily => 'Debian', + :operatingsystem => 'Debian', + :debian_release => 'jessie', + :debian_codename => 'jessie', + :lsbdistcodename => 'jessie', + :virtual => 'physical', + :puppetversion => Puppet.version, } } + #it { is_expected.to compile.with_all_deps } + it { is_expected.to compile } +end diff --git a/spec/defines/conf_spec.rb b/spec/defines/conf_spec.rb new file mode 100644 index 0000000..cc4fb1f --- /dev/null +++ b/spec/defines/conf_spec.rb @@ -0,0 +1,74 @@ +require 'spec_helper' +describe 'apt::apt_conf', :type => :define do + let :pre_condition do + 'class { "apt": }' + end + let(:facts) { { + :lsbdistid => 'Debian', + :osfamily => 'Debian', + :operatingsystem => 'Debian', + :debian_release => 'jessie', + :debian_codename => 'jessie', + :lsbdistcodename => 'jessie', + :virtual => 'physical', + :puppetversion => Puppet.version, } } + let :title do + 'norecommends' + end + + describe "when creating an apt_conf snippet" do + let :default_params do + { + :ensure => 'present', + :content => "Apt::Install-Recommends 0;\nApt::AutoRemove::InstallRecommends 1;\n" + } + end + let :params do + default_params + end + let :filename do + "/etc/apt/apt.conf.d/norecommends" + end + + it { is_expected.to contain_file(filename).with({ + 'ensure' => 'present', + 'content' => /Apt::Install-Recommends 0;\nApt::AutoRemove::InstallRecommends 1;/, + 'owner' => 'root', + # default to '0', not 'root' + #'group' => 'root', + 'mode' => '0644', + }) + } + + end + + describe "when creating a preference without content" do + let :params do + { + :ensure => 'absent', + } + end + + it 'fails' do + expect { subject.call } .to raise_error(Puppet::Error, /One of \$source or \$content must be specified for apt_conf norecommends/) + end + end + + describe "when removing an apt preference" do + let :params do + { + :ensure => 'absent', + :content => "Apt::Install-Recommends 0;\nApt::AutoRemove::InstallRecommends 1;\n", + } + end + + let :filename do + "/etc/apt/apt.conf.d/norecommends" + end + + it { is_expected.to contain_file(filename).with({ + 'ensure' => 'absent', + }) + } + end +end diff --git a/spec/defines/preferences_snippet_spec.rb b/spec/defines/preferences_snippet_spec.rb new file mode 100644 index 0000000..012a5f6 --- /dev/null +++ b/spec/defines/preferences_snippet_spec.rb @@ -0,0 +1,66 @@ +require 'spec_helper' +describe 'apt::preferences_snippet', :type => :define do + let :pre_condition do + 'class { "apt": }' + end + let(:facts) { { + :lsbdistid => 'Debian', + :osfamily => 'Debian', + :operatingsystem => 'Debian', + :debian_release => 'jessie', + :debian_codename => 'jessie', + :lsbdistcodename => 'jessie', + :virtual => 'physical', + :puppetversion => Puppet.version, } } + let :title do + 'test' + end + + describe "when creating a preferences_snippet" do + let :default_params do + { + :ensure => 'present', + :release => "jessie-backports", + :priority => '999' + } + end + let :params do + default_params + end + let :filename do + "/etc/apt/preferences.d/test" + end + + it { is_expected.to contain_file(filename).with({ + 'ensure' => 'present', + 'content' => /Package: test\nPin: release a=jessie-backports\nPin-Priority: 999/, + 'owner' => 'root', + 'group' => '0', + 'mode' => '0644', + }) + } + + end + + describe "when using both pin and release parameters" do + let :default_params do + { + :ensure => 'present', + :priority => '999', + :release => "jessie-backports", + :pin => '1.0' + } + end + let :params do + default_params + end + let :filename do + "/etc/apt/preferences.d/test" + end + + it 'fails' do + expect { subject.call } .to raise_error(Puppet::Error, /apt::preferences_snippet requires either a 'pin' or 'release' argument, not both/) + end + end + +end diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb new file mode 100644 index 0000000..3cca63a --- /dev/null +++ b/spec/spec_helper.rb @@ -0,0 +1,12 @@ +# https://puppetlabs.com/blog/testing-modules-in-the-puppet-forge +require 'puppetlabs_spec_helper/module_spec_helper' + +fixture_path = File.expand_path(File.join(__FILE__, '..', 'fixtures')) + +RSpec.configure do |c| + + c.manifest_dir = File.join(fixture_path, 'manifests') + c.module_path = File.join(fixture_path, 'modules') + + c.color = true +end diff --git a/spec/spec_helper_acceptance.rb b/spec/spec_helper_acceptance.rb new file mode 100644 index 0000000..1ccd84d --- /dev/null +++ b/spec/spec_helper_acceptance.rb @@ -0,0 +1,18 @@ +require 'beaker-rspec' + +RSpec.configure do |c| + module_root = File.expand_path(File.join(File.dirname(__FILE__), '..')) + module_name = module_root.split('-').last + + # Readable test descriptions + c.formatter = :documentation + + # Configure all nodes in nodeset + c.before :suite do + # Install module and dependencies + puppet_module_install(:source => module_root, :module_name => module_name) + hosts.each do |host| + shell('git clone https://gitlab.com/shared-puppet-modules-group/common.git /etc/puppet/modules/common') + end + end +end diff --git a/spec/unit/custom_facts_spec.rb b/spec/unit/custom_facts_spec.rb new file mode 100644 index 0000000..9a28d92 --- /dev/null +++ b/spec/unit/custom_facts_spec.rb @@ -0,0 +1,86 @@ +require "spec_helper" + +describe "Facter::Util::Fact" do + before { + Facter.clear + } + + describe 'custom facts' do + + context 'Debian 7' do + before do + Facter.fact(:operatingsystem).stubs(:value).returns("Debian") + Facter.fact(:operatingsystemrelease).stubs(:value).returns("7.8") + Facter.fact(:lsbdistcodename).stubs(:value).returns("wheezy") + end + + it "debian_release = oldstable" do + expect(Facter.fact(:debian_release).value).to eq('oldstable') + end + + it "debian_codename = wheezy" do + expect(Facter.fact(:debian_codename).value).to eq('wheezy') + end + + it "debian_nextcodename = jessie" do + expect(Facter.fact(:debian_nextcodename).value).to eq('jessie') + end + + it "debian_nextrelease = stable" do + expect(Facter.fact(:debian_nextrelease).value).to eq('stable') + end + end + + context 'Debian 8' do + before do + Facter.fact(:operatingsystem).stubs(:value).returns("Debian") + Facter.fact(:operatingsystemrelease).stubs(:value).returns("8.0") + Facter.fact(:lsbdistcodename).stubs(:value).returns("jessie") + end + + it "debian_release = stable" do + expect(Facter.fact(:debian_release).value).to eq('stable') + end + + it "debian_codename = jessie" do + expect(Facter.fact(:debian_codename).value).to eq('jessie') + end + + it "debian_nextcodename = stretch" do + expect(Facter.fact(:debian_nextcodename).value).to eq('stretch') + end + + it "debian_nextrelease = testing" do + expect(Facter.fact(:debian_nextrelease).value).to eq('testing') + end + end + + context 'Ubuntu 15.10' do + before do + Facter.fact(:operatingsystem).stubs(:value).returns("Ubuntu") + Facter.fact(:operatingsystemrelease).stubs(:value).returns("15.10") + Facter.fact(:lsbdistcodename).stubs(:value).returns("wily") + end + + it "ubuntu_codename = wily" do + expect(Facter.fact(:ubuntu_codename).value).to eq('wily') + end + + it "ubuntu_nextcodename = xenial" do + expect(Facter.fact(:ubuntu_nextcodename).value).to eq('xenial') + end + end + end + + describe "Test 'apt_running' fact" do + it "should return true when apt-get is running" do + Facter::Util::Resolution.stubs(:exec).with("pgrep apt-get >/dev/null 2>&1 && echo true || echo false").returns("true") + expect(Facter.fact(:apt_running).value).to eq('true') + end + it "should return false when apt-get is not running" do + Facter::Util::Resolution.stubs(:exec).with("pgrep apt-get >/dev/null 2>&1 && echo true || echo false").returns("false") + expect(Facter.fact(:apt_running).value).to eq('false') + end + end + +end -- cgit v1.2.3 From 6b12caf4f6310bd6695ef5676387658fb444778a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Louis-Philippe=20V=C3=A9ronneau?= Date: Wed, 11 Oct 2017 16:05:28 -0400 Subject: remove apt-specific tests --- spec/acceptance/apt_spec.rb | 21 -------- spec/classes/init_spec.rb | 18 ------- spec/defines/conf_spec.rb | 74 --------------------------- spec/defines/preferences_snippet_spec.rb | 66 ------------------------ spec/unit/custom_facts_spec.rb | 86 -------------------------------- 5 files changed, 265 deletions(-) delete mode 100644 spec/acceptance/apt_spec.rb delete mode 100644 spec/classes/init_spec.rb delete mode 100644 spec/defines/conf_spec.rb delete mode 100644 spec/defines/preferences_snippet_spec.rb delete mode 100644 spec/unit/custom_facts_spec.rb (limited to 'spec') diff --git a/spec/acceptance/apt_spec.rb b/spec/acceptance/apt_spec.rb deleted file mode 100644 index a976a56..0000000 --- a/spec/acceptance/apt_spec.rb +++ /dev/null @@ -1,21 +0,0 @@ -require 'spec_helper_acceptance' - -describe 'apt class' do - - context 'default parameters' do - it 'should work idempotently with no errors' do - pp = <<-EOS - class { 'apt': } - EOS - - # Run it twice and test for idempotency - apply_manifest(pp, :catch_failures => true) - apply_manifest(pp, :catch_changes => true) - end - - describe package('apt') do - it { is_expected.to be_installed } - end - - end -end diff --git a/spec/classes/init_spec.rb b/spec/classes/init_spec.rb deleted file mode 100644 index 9ba554f..0000000 --- a/spec/classes/init_spec.rb +++ /dev/null @@ -1,18 +0,0 @@ -require 'spec_helper' - -describe 'apt', :type => :class do - let :pre_condition do - 'class { "apt": }' - end - let(:facts) { { - :lsbdistid => 'Debian', - :osfamily => 'Debian', - :operatingsystem => 'Debian', - :debian_release => 'jessie', - :debian_codename => 'jessie', - :lsbdistcodename => 'jessie', - :virtual => 'physical', - :puppetversion => Puppet.version, } } - #it { is_expected.to compile.with_all_deps } - it { is_expected.to compile } -end diff --git a/spec/defines/conf_spec.rb b/spec/defines/conf_spec.rb deleted file mode 100644 index cc4fb1f..0000000 --- a/spec/defines/conf_spec.rb +++ /dev/null @@ -1,74 +0,0 @@ -require 'spec_helper' -describe 'apt::apt_conf', :type => :define do - let :pre_condition do - 'class { "apt": }' - end - let(:facts) { { - :lsbdistid => 'Debian', - :osfamily => 'Debian', - :operatingsystem => 'Debian', - :debian_release => 'jessie', - :debian_codename => 'jessie', - :lsbdistcodename => 'jessie', - :virtual => 'physical', - :puppetversion => Puppet.version, } } - let :title do - 'norecommends' - end - - describe "when creating an apt_conf snippet" do - let :default_params do - { - :ensure => 'present', - :content => "Apt::Install-Recommends 0;\nApt::AutoRemove::InstallRecommends 1;\n" - } - end - let :params do - default_params - end - let :filename do - "/etc/apt/apt.conf.d/norecommends" - end - - it { is_expected.to contain_file(filename).with({ - 'ensure' => 'present', - 'content' => /Apt::Install-Recommends 0;\nApt::AutoRemove::InstallRecommends 1;/, - 'owner' => 'root', - # default to '0', not 'root' - #'group' => 'root', - 'mode' => '0644', - }) - } - - end - - describe "when creating a preference without content" do - let :params do - { - :ensure => 'absent', - } - end - - it 'fails' do - expect { subject.call } .to raise_error(Puppet::Error, /One of \$source or \$content must be specified for apt_conf norecommends/) - end - end - - describe "when removing an apt preference" do - let :params do - { - :ensure => 'absent', - :content => "Apt::Install-Recommends 0;\nApt::AutoRemove::InstallRecommends 1;\n", - } - end - - let :filename do - "/etc/apt/apt.conf.d/norecommends" - end - - it { is_expected.to contain_file(filename).with({ - 'ensure' => 'absent', - }) - } - end -end diff --git a/spec/defines/preferences_snippet_spec.rb b/spec/defines/preferences_snippet_spec.rb deleted file mode 100644 index 012a5f6..0000000 --- a/spec/defines/preferences_snippet_spec.rb +++ /dev/null @@ -1,66 +0,0 @@ -require 'spec_helper' -describe 'apt::preferences_snippet', :type => :define do - let :pre_condition do - 'class { "apt": }' - end - let(:facts) { { - :lsbdistid => 'Debian', - :osfamily => 'Debian', - :operatingsystem => 'Debian', - :debian_release => 'jessie', - :debian_codename => 'jessie', - :lsbdistcodename => 'jessie', - :virtual => 'physical', - :puppetversion => Puppet.version, } } - let :title do - 'test' - end - - describe "when creating a preferences_snippet" do - let :default_params do - { - :ensure => 'present', - :release => "jessie-backports", - :priority => '999' - } - end - let :params do - default_params - end - let :filename do - "/etc/apt/preferences.d/test" - end - - it { is_expected.to contain_file(filename).with({ - 'ensure' => 'present', - 'content' => /Package: test\nPin: release a=jessie-backports\nPin-Priority: 999/, - 'owner' => 'root', - 'group' => '0', - 'mode' => '0644', - }) - } - - end - - describe "when using both pin and release parameters" do - let :default_params do - { - :ensure => 'present', - :priority => '999', - :release => "jessie-backports", - :pin => '1.0' - } - end - let :params do - default_params - end - let :filename do - "/etc/apt/preferences.d/test" - end - - it 'fails' do - expect { subject.call } .to raise_error(Puppet::Error, /apt::preferences_snippet requires either a 'pin' or 'release' argument, not both/) - end - end - -end diff --git a/spec/unit/custom_facts_spec.rb b/spec/unit/custom_facts_spec.rb deleted file mode 100644 index 9a28d92..0000000 --- a/spec/unit/custom_facts_spec.rb +++ /dev/null @@ -1,86 +0,0 @@ -require "spec_helper" - -describe "Facter::Util::Fact" do - before { - Facter.clear - } - - describe 'custom facts' do - - context 'Debian 7' do - before do - Facter.fact(:operatingsystem).stubs(:value).returns("Debian") - Facter.fact(:operatingsystemrelease).stubs(:value).returns("7.8") - Facter.fact(:lsbdistcodename).stubs(:value).returns("wheezy") - end - - it "debian_release = oldstable" do - expect(Facter.fact(:debian_release).value).to eq('oldstable') - end - - it "debian_codename = wheezy" do - expect(Facter.fact(:debian_codename).value).to eq('wheezy') - end - - it "debian_nextcodename = jessie" do - expect(Facter.fact(:debian_nextcodename).value).to eq('jessie') - end - - it "debian_nextrelease = stable" do - expect(Facter.fact(:debian_nextrelease).value).to eq('stable') - end - end - - context 'Debian 8' do - before do - Facter.fact(:operatingsystem).stubs(:value).returns("Debian") - Facter.fact(:operatingsystemrelease).stubs(:value).returns("8.0") - Facter.fact(:lsbdistcodename).stubs(:value).returns("jessie") - end - - it "debian_release = stable" do - expect(Facter.fact(:debian_release).value).to eq('stable') - end - - it "debian_codename = jessie" do - expect(Facter.fact(:debian_codename).value).to eq('jessie') - end - - it "debian_nextcodename = stretch" do - expect(Facter.fact(:debian_nextcodename).value).to eq('stretch') - end - - it "debian_nextrelease = testing" do - expect(Facter.fact(:debian_nextrelease).value).to eq('testing') - end - end - - context 'Ubuntu 15.10' do - before do - Facter.fact(:operatingsystem).stubs(:value).returns("Ubuntu") - Facter.fact(:operatingsystemrelease).stubs(:value).returns("15.10") - Facter.fact(:lsbdistcodename).stubs(:value).returns("wily") - end - - it "ubuntu_codename = wily" do - expect(Facter.fact(:ubuntu_codename).value).to eq('wily') - end - - it "ubuntu_nextcodename = xenial" do - expect(Facter.fact(:ubuntu_nextcodename).value).to eq('xenial') - end - end - end - - describe "Test 'apt_running' fact" do - it "should return true when apt-get is running" do - Facter::Util::Resolution.stubs(:exec).with("pgrep apt-get >/dev/null 2>&1 && echo true || echo false").returns("true") - expect(Facter.fact(:apt_running).value).to eq('true') - end - it "should return false when apt-get is not running" do - Facter::Util::Resolution.stubs(:exec).with("pgrep apt-get >/dev/null 2>&1 && echo true || echo false").returns("false") - expect(Facter.fact(:apt_running).value).to eq('false') - end - end - -end -- cgit v1.2.3 From 15d171a2bc2a76cb3d6f94fb1443e24e93a545e2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Louis-Philippe=20V=C3=A9ronneau?= Date: Wed, 11 Oct 2017 16:22:48 -0400 Subject: replace the apt deps in the CI by the tor ones --- spec/spec_helper_acceptance.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'spec') diff --git a/spec/spec_helper_acceptance.rb b/spec/spec_helper_acceptance.rb index 1ccd84d..e6a2cd8 100644 --- a/spec/spec_helper_acceptance.rb +++ b/spec/spec_helper_acceptance.rb @@ -12,7 +12,7 @@ RSpec.configure do |c| # Install module and dependencies puppet_module_install(:source => module_root, :module_name => module_name) hosts.each do |host| - shell('git clone https://gitlab.com/shared-puppet-modules-group/common.git /etc/puppet/modules/common') + shell('git clone https://github.com/puppetlabs/puppetlabs-concat.git /etc/puppet/modules/concat') end end end -- cgit v1.2.3 From 90cb24c6e0916b27eae744e5f6ecaa84a180517c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Louis-Philippe=20V=C3=A9ronneau?= Date: Fri, 12 Jan 2018 21:55:05 -0500 Subject: remove symbolic link since the Puppet Forge won't accept them --- spec/acceptance/nodesets/debian-8-x86_64-docker.yml | 19 ------------------- spec/acceptance/nodesets/default.yml | 20 +++++++++++++++++++- 2 files changed, 19 insertions(+), 20 deletions(-) delete mode 100644 spec/acceptance/nodesets/debian-8-x86_64-docker.yml mode change 120000 => 100644 spec/acceptance/nodesets/default.yml (limited to 'spec') diff --git a/spec/acceptance/nodesets/debian-8-x86_64-docker.yml b/spec/acceptance/nodesets/debian-8-x86_64-docker.yml deleted file mode 100644 index f09ad62..0000000 --- a/spec/acceptance/nodesets/debian-8-x86_64-docker.yml +++ /dev/null @@ -1,19 +0,0 @@ -HOSTS: - debian-8-x64: - platform: debian-8-amd64 - image: debian:8 - hypervisor: docker - docker_preserve_image: true - docker_cmd: '["/sbin/init"]' - docker_image_commands: - - 'apt-get install -y wget locales-all puppet git' - - 'rm -f /usr/sbin/policy-rc.d' - -CONFIG: - type: foss - #log_level: verbose - #log_level: debug - -ssh: - password: root - auth_methods: ["password"] diff --git a/spec/acceptance/nodesets/default.yml b/spec/acceptance/nodesets/default.yml deleted file mode 120000 index b125a96..0000000 --- a/spec/acceptance/nodesets/default.yml +++ /dev/null @@ -1 +0,0 @@ -debian-8-x86_64-docker.yml \ No newline at end of file diff --git a/spec/acceptance/nodesets/default.yml b/spec/acceptance/nodesets/default.yml new file mode 100644 index 0000000..f09ad62 --- /dev/null +++ b/spec/acceptance/nodesets/default.yml @@ -0,0 +1,19 @@ +HOSTS: + debian-8-x64: + platform: debian-8-amd64 + image: debian:8 + hypervisor: docker + docker_preserve_image: true + docker_cmd: '["/sbin/init"]' + docker_image_commands: + - 'apt-get install -y wget locales-all puppet git' + - 'rm -f /usr/sbin/policy-rc.d' + +CONFIG: + type: foss + #log_level: verbose + #log_level: debug + +ssh: + password: root + auth_methods: ["password"] -- cgit v1.2.3