From c3dd0d46949fd9bf7eff73ff3cc58c71a05936c0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Louis-Philippe=20V=C3=A9ronneau?= Date: Thu, 5 Oct 2017 17:25:24 -0400 Subject: concat::fragment does not have an 'ensure' var anymore --- manifests/daemon/base.pp | 1 - manifests/daemon/bridge.pp | 4 +--- manifests/daemon/control.pp | 1 - manifests/daemon/directory.pp | 1 - manifests/daemon/dns.pp | 4 +--- manifests/daemon/exit_policy.pp | 4 +--- manifests/daemon/hidden_service.pp | 4 +--- manifests/daemon/map_address.pp | 4 +--- manifests/daemon/relay.pp | 1 - manifests/daemon/snippet.pp | 4 +--- manifests/daemon/transparent.pp | 4 +--- 11 files changed, 7 insertions(+), 25 deletions(-) (limited to 'manifests') diff --git a/manifests/daemon/base.pp b/manifests/daemon/base.pp index c0c82ac..f3bbc37 100644 --- a/manifests/daemon/base.pp +++ b/manifests/daemon/base.pp @@ -56,7 +56,6 @@ class tor::daemon::base inherits tor::base { # config file headers concat::fragment { '00.header': - ensure => present, content => template('tor/torrc.header.erb'), order => 00, target => $tor::daemon::config_file, diff --git a/manifests/daemon/bridge.pp b/manifests/daemon/bridge.pp index 83d74e0..a448f82 100644 --- a/manifests/daemon/bridge.pp +++ b/manifests/daemon/bridge.pp @@ -2,11 +2,9 @@ define tor::daemon::bridge( $ip, $port, - $fingerprint = false, - $ensure = present ) { + $fingerprint = false ) { concat::fragment { "10.bridge.${name}": - ensure => $ensure, content => template('tor/torrc.bridge.erb'), order => 10, target => $tor::daemon::config_file, diff --git a/manifests/daemon/control.pp b/manifests/daemon/control.pp index ee425f3..4137c3e 100644 --- a/manifests/daemon/control.pp +++ b/manifests/daemon/control.pp @@ -19,7 +19,6 @@ define tor::daemon::control( } concat::fragment { '04.control': - ensure => $ensure, content => template('tor/torrc.control.erb'), order => 04, target => $tor::daemon::config_file, diff --git a/manifests/daemon/directory.pp b/manifests/daemon/directory.pp index e2e405d..fa7d52d 100644 --- a/manifests/daemon/directory.pp +++ b/manifests/daemon/directory.pp @@ -6,7 +6,6 @@ define tor::daemon::directory ( $ensure = present ) { concat::fragment { '06.directory': - ensure => $ensure, content => template('tor/torrc.directory.erb'), order => 06, target => $tor::daemon::config_file, diff --git a/manifests/daemon/dns.pp b/manifests/daemon/dns.pp index e8d4fc8..e2141c9 100644 --- a/manifests/daemon/dns.pp +++ b/manifests/daemon/dns.pp @@ -1,11 +1,9 @@ # DNS definition define tor::daemon::dns( $port = 0, - $listen_addresses = [], - $ensure = present ) { + $listen_addresses = [] ) { concat::fragment { "08.dns.${name}": - ensure => $ensure, content => template('tor/torrc.dns.erb'), order => '08', target => $tor::daemon::config_file, diff --git a/manifests/daemon/exit_policy.pp b/manifests/daemon/exit_policy.pp index df0fb99..c117d5d 100644 --- a/manifests/daemon/exit_policy.pp +++ b/manifests/daemon/exit_policy.pp @@ -2,11 +2,9 @@ define tor::daemon::exit_policy( $accept = [], $reject = [], - $reject_private = 1, - $ensure = present ) { + $reject_private = 1 ) { concat::fragment { "07.exit_policy.${name}": - ensure => $ensure, content => template('tor/torrc.exit_policy.erb'), order => 07, target => $tor::daemon::config_file, diff --git a/manifests/daemon/hidden_service.pp b/manifests/daemon/hidden_service.pp index 07121bd..4549cc7 100644 --- a/manifests/daemon/hidden_service.pp +++ b/manifests/daemon/hidden_service.pp @@ -2,8 +2,7 @@ define tor::daemon::hidden_service( $ports = [], $single_hop = false, - $data_dir = $tor::daemon::data_dir, - $ensure = present ) { + $data_dir = $tor::daemon::data_dir ) { if $single_hop { @@ -13,7 +12,6 @@ define tor::daemon::hidden_service( } concat::fragment { "05.hidden_service.${name}": - ensure => $ensure, content => template('tor/torrc.hidden_service.erb'), order => 05, target => $tor::daemon::config_file, diff --git a/manifests/daemon/map_address.pp b/manifests/daemon/map_address.pp index ac624a0..1829eae 100644 --- a/manifests/daemon/map_address.pp +++ b/manifests/daemon/map_address.pp @@ -1,11 +1,9 @@ # map address definition define tor::daemon::map_address( $address = '', - $newaddress = '', - $ensure = 'present') { + $newaddress = '' ) { concat::fragment { "08.map_address.${name}": - ensure => $ensure, content => template('tor/torrc.map_address.erb'), order => '08', target => $tor::daemon::config_file, diff --git a/manifests/daemon/relay.pp b/manifests/daemon/relay.pp index 555587c..115eb25 100644 --- a/manifests/daemon/relay.pp +++ b/manifests/daemon/relay.pp @@ -31,7 +31,6 @@ define tor::daemon::relay( } concat::fragment { '03.relay': - ensure => $ensure, content => template('tor/torrc.relay.erb'), order => 03, target => $tor::daemon::config_file, diff --git a/manifests/daemon/snippet.pp b/manifests/daemon/snippet.pp index 7e1494c..5a4c091 100644 --- a/manifests/daemon/snippet.pp +++ b/manifests/daemon/snippet.pp @@ -1,10 +1,8 @@ # Arbitrary torrc snippet definition define tor::daemon::snippet( - $content = '', - $ensure = present ) { + $content = '' ) { concat::fragment { "99.snippet.${name}": - ensure => $ensure, content => $content, order => 99, target => $tor::daemon::config_file, diff --git a/manifests/daemon/transparent.pp b/manifests/daemon/transparent.pp index 6ac7b44..7115fee 100644 --- a/manifests/daemon/transparent.pp +++ b/manifests/daemon/transparent.pp @@ -1,11 +1,9 @@ # Transparent proxy definition define tor::daemon::transparent( $port = 0, - $listen_addresses = [], - $ensure = present ) { + $listen_addresses = [] ) { concat::fragment { "09.transparent.${name}": - ensure => $ensure, content => template('tor/torrc.transparent.erb'), order => '09', target => $tor::daemon::config_file, -- cgit v1.2.3 From 682cc7622e033575d6238c5792f135fce05b13c3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Louis-Philippe=20V=C3=A9ronneau?= Date: Wed, 18 Oct 2017 16:09:14 -0400 Subject: add support for Server Transport Plugins --- manifests/daemon/transport_plugin.pp | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 manifests/daemon/transport_plugin.pp (limited to 'manifests') diff --git a/manifests/daemon/transport_plugin.pp b/manifests/daemon/transport_plugin.pp new file mode 100644 index 0000000..f0ba41f --- /dev/null +++ b/manifests/daemon/transport_plugin.pp @@ -0,0 +1,17 @@ +# transport plugin +define tor::daemon::transport_plugin( + $servertransport_plugin = '', + $servertransport_listenaddr = '', + $servertransport_options = '', + $ext_port = '' ) { + + if $port == $ext_port { + fail('ORPort and ExtORPort values cannot be the same') + } + + concat::fragment { "11.transport_plugin": + content => template('tor/torrc.transport_plugin.erb'), + order => 11, + target => $tor::daemon::config_file, + } +} -- cgit v1.2.3 From 354a87462f346ce6da31c52857f21a923d798445 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Louis-Philippe=20V=C3=A9ronneau?= Date: Wed, 25 Oct 2017 15:51:22 -0400 Subject: remove the port check, since we can't access a variable in another define without creating a fact --- manifests/daemon/transport_plugin.pp | 4 ---- 1 file changed, 4 deletions(-) (limited to 'manifests') diff --git a/manifests/daemon/transport_plugin.pp b/manifests/daemon/transport_plugin.pp index f0ba41f..7242e5e 100644 --- a/manifests/daemon/transport_plugin.pp +++ b/manifests/daemon/transport_plugin.pp @@ -5,10 +5,6 @@ define tor::daemon::transport_plugin( $servertransport_options = '', $ext_port = '' ) { - if $port == $ext_port { - fail('ORPort and ExtORPort values cannot be the same') - } - concat::fragment { "11.transport_plugin": content => template('tor/torrc.transport_plugin.erb'), order => 11, -- cgit v1.2.3 From 47342c072a8d39d8680b7a9b60ffc5ff674840a1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Louis-Philippe=20V=C3=A9ronneau?= Date: Wed, 18 Oct 2017 14:01:32 -0400 Subject: '[]' is not a proper default for AccountingStart, use tor's default instead --- manifests/daemon/relay.pp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'manifests') diff --git a/manifests/daemon/relay.pp b/manifests/daemon/relay.pp index 115eb25..056bbf6 100644 --- a/manifests/daemon/relay.pp +++ b/manifests/daemon/relay.pp @@ -14,7 +14,7 @@ define tor::daemon::relay( $relay_bandwidth_burst = 0, # GB, 0 for no limit $accounting_max = 0, - $accounting_start = [], + $accounting_start = "month 1 0:00", $contact_info = '', # TODO: autofill with other relays $my_family = '', -- cgit v1.2.3 From 4b234d7eb2c42f1c8c8e872e64c619f08bdaa304 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Louis-Philippe=20V=C3=A9ronneau?= Date: Wed, 1 Nov 2017 16:33:03 -0400 Subject: follow puppet syntax guide (and make the CI shutup) --- manifests/daemon/transport_plugin.pp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'manifests') diff --git a/manifests/daemon/transport_plugin.pp b/manifests/daemon/transport_plugin.pp index 7242e5e..1921282 100644 --- a/manifests/daemon/transport_plugin.pp +++ b/manifests/daemon/transport_plugin.pp @@ -5,7 +5,7 @@ define tor::daemon::transport_plugin( $servertransport_options = '', $ext_port = '' ) { - concat::fragment { "11.transport_plugin": + concat::fragment { '11.transport_plugin': content => template('tor/torrc.transport_plugin.erb'), order => 11, target => $tor::daemon::config_file, -- cgit v1.2.3 From d5c17a1c842bbec4d0172895d715f5ce48fb7068 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Louis-Philippe=20V=C3=A9ronneau?= Date: Wed, 1 Nov 2017 16:47:02 -0400 Subject: *ListenAddress (OR, DNS, Trans, etc.) are deprecated since 0.2.3.x-alpha --- manifests/daemon/directory.pp | 1 - manifests/daemon/dns.pp | 3 +-- manifests/daemon/relay.pp | 1 - manifests/daemon/socks.pp | 1 - manifests/daemon/transparent.pp | 3 +-- 5 files changed, 2 insertions(+), 7 deletions(-) (limited to 'manifests') diff --git a/manifests/daemon/directory.pp b/manifests/daemon/directory.pp index fa7d52d..3eaef9f 100644 --- a/manifests/daemon/directory.pp +++ b/manifests/daemon/directory.pp @@ -1,7 +1,6 @@ # directory advertising define tor::daemon::directory ( $port = 0, - $listen_addresses = [], $port_front_page = '/etc/tor/tor-exit-notice.html', $ensure = present ) { diff --git a/manifests/daemon/dns.pp b/manifests/daemon/dns.pp index e2141c9..599abd8 100644 --- a/manifests/daemon/dns.pp +++ b/manifests/daemon/dns.pp @@ -1,7 +1,6 @@ # DNS definition define tor::daemon::dns( - $port = 0, - $listen_addresses = [] ) { + $port = 0 ) { concat::fragment { "08.dns.${name}": content => template('tor/torrc.dns.erb'), diff --git a/manifests/daemon/relay.pp b/manifests/daemon/relay.pp index 056bbf6..fa908f5 100644 --- a/manifests/daemon/relay.pp +++ b/manifests/daemon/relay.pp @@ -1,7 +1,6 @@ # relay definition define tor::daemon::relay( $port = 0, - $listen_addresses = [], $outbound_bindaddresses = [], $portforwarding = 0, # KB/s, defaulting to using tor's default: 5120KB/s diff --git a/manifests/daemon/socks.pp b/manifests/daemon/socks.pp index 54c8b6a..cb130d9 100644 --- a/manifests/daemon/socks.pp +++ b/manifests/daemon/socks.pp @@ -1,7 +1,6 @@ # socks definition define tor::daemon::socks( $port = 0, - $listen_addresses = [], $policies = [] ) { concat::fragment { '02.socks': diff --git a/manifests/daemon/transparent.pp b/manifests/daemon/transparent.pp index 7115fee..90c0142 100644 --- a/manifests/daemon/transparent.pp +++ b/manifests/daemon/transparent.pp @@ -1,7 +1,6 @@ # Transparent proxy definition define tor::daemon::transparent( - $port = 0, - $listen_addresses = [] ) { + $port = 0 ) { concat::fragment { "09.transparent.${name}": content => template('tor/torrc.transparent.erb'), -- cgit v1.2.3 From 01cfa7e013179f17d981ef8ca9822a8c3bd727ff Mon Sep 17 00:00:00 2001 From: Micah Anderson Date: Sat, 7 Oct 2017 13:39:12 -0400 Subject: add v3 hidden service support --- manifests/daemon/hidden_service.pp | 2 ++ 1 file changed, 2 insertions(+) (limited to 'manifests') diff --git a/manifests/daemon/hidden_service.pp b/manifests/daemon/hidden_service.pp index 4549cc7..9e053cc 100644 --- a/manifests/daemon/hidden_service.pp +++ b/manifests/daemon/hidden_service.pp @@ -2,9 +2,11 @@ define tor::daemon::hidden_service( $ports = [], $single_hop = false, + $v3 = false, $data_dir = $tor::daemon::data_dir ) { + if $single_hop { file { "${$data_dir}/${$name}/onion_service_non_anonymous": ensure => 'present', -- cgit v1.2.3