From 3b55113c7321376882f4d158bfcca380706330a2 Mon Sep 17 00:00:00 2001 From: Krzysztof Wilczynski Date: Sat, 30 Apr 2011 01:00:10 +0100 Subject: Moved to unless from if not and changed wording of few error messages. Signed-off-by: Krzysztof Wilczynski --- type.rb | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/type.rb b/type.rb index ac1895c..3051de6 100644 --- a/type.rb +++ b/type.rb @@ -14,17 +14,18 @@ module Puppet::Parser::Functions klass = value.class - if not [Array, Bignum, Fixnum, FalseClass, - Float, Hash, String, TrueClass].include?(klass) + # This should cover all the generic types present in Puppet at present ... + unless [Array, Bignum, Fixnum, FalseClass, + Float, Hash, String, TrueClass].include?(klass) - raise(Puppet::ParseError, 'type(): Unknown type') + raise(Puppet::ParseError, 'type(): Unknown type given') end klass = klass.to_s # Ugly ... # # We note that Integer is the parent to Bignum and Fixnum ... - # Plus we say Boolean for FalseClass and TrueClass ... + # Plus we claim name Boolean for FalseClass and TrueClass ... # result = case klass when /^(?:Big|Fix)num$/ then 'Integer' -- cgit v1.2.3