summaryrefslogtreecommitdiff
path: root/spec
AgeCommit message (Collapse)Author
2017-05-09(PE-20308) Also fix defined type strings & referencesHunter Haugen
2017-05-09Test for defined_with_params() returning false for defined typesDominic Cleal
defined_with_params() now returns false for defined types, causing duplicate resources when using ensure_resources(). Introduced by 4f19c27 in PE-20308.
2017-04-26(PE-20308) Correct boundary for 4.5 vs 4.6Hunter Haugen
2017-04-25(PE-20308) Pass a literal type and not a string to findresourceHunter Haugen
- `defined_with_params` calls `findresource(reference.to_s)` - `findresource` is https://github.com/puppetlabs/puppet/blob/4.8.1/lib/puppet/parser/compiler.rb#L407 and points to https://github.com/puppetlabs/puppet/blob/4.8.1/lib/puppet/resource/catalog.rb#L352 - This calls `Puppet::Resource.new` with the type https://github.com/puppetlabs/puppet/blob/4.8.1/lib/puppet/resource/catalog.rb#L366 - This ends up calling `resource_type` via https://github.com/puppetlabs/puppet/blob/4.8.1/lib/puppet/resource.rb#L317-L319 and that ends up declaring the type via the autoloader api at https://github.com/puppetlabs/puppet/blob/4.8.1/lib/puppet/resource.rb#L390 - But why does the autoloader API fail to find it in the current environment? - Okay, so when the autoloader is trying to find the type, it uses the typeloader to look it up in the current environment https://github.com/puppetlabs/puppet/blob/4.8.1/lib/puppet/metatype/manager.rb#L171 - this calls `get_file` and `mark_loaded` https://github.com/puppetlabs/puppet/blob/4.8.1/lib/puppet/util/autoload.rb#L64-L67 Suggested workaround is to pass a literal type instead of a string to `findresource` to fix in stdlib, and also to fix loading/requiring of type in core puppet. This seems to affect more recent versions of puppet, so fallback to original behavior on pre-4.5
2017-03-21Merge pull request #718 from sspreitzer/master_globWilson McCoubrey
Add glob function
2017-03-21Update alias spec error message expectation for PUP-7371Dominic Cleal
The fix for PUP-7371 adds the missing `Undef` into the error message being tested in type aliases specs, fixing the following failure against Puppet's master branch: test::string rejects other values [] should fail to compile and raise an error matching /parameter 'value' expects a String/ Failure/Error: it { is_expected.to compile.and_raise_error(/parameter 'value' expects a String/) } error during compilation: Evaluation Error: Error while evaluating a Resource Statement, Class[Test::String]: parameter 'value' expects a value of type Undef or String, got Array at line 2:1 on node example # ./spec/aliases/string_spec.rb:27:in `block (5 levels) in <top (required)>'
2017-03-16Merge pull request #737 from domcleal/versioncmpWilson McCoubrey
(MODULES-4528) Use versioncmp to check Puppet version for 4.10.x compat
2017-03-15Permit double slash in absolute/Unix path typesDominic Cleal
2017-03-14Merge pull request #736 from HelenCampbell/lengthfunctDavid Schmitt
Addition of new length function
2017-03-14Addition of new length functionHelen Campbell
2017-03-14(MODULES-4528) Use versioncmp to check Puppet version for 4.10.x compatDominic Cleal
`Puppet.version.to_f` on Puppet 4.10.0 will evaluate to `4.1`, causing test and behavioural changes when conditionals check that the version is equal or greater than versions such as `4.3`. Version comparisons that are vulnerable to this have been changed to use Puppet's versioncmp implementation, while most others only check for for major version boundaries which is safe.
2017-03-13(#FM-6068) allow file encoding to be specified (#726)Geoff Williams
* (#FM-6068) allow file encoding to be specified Add a new parameter `encoding` to allow non UTF-8 files to specify a file encoding. This prevents receiving the error message "invalid byte sequence in UTF-8" when special characters that are not UTF-8 encoded appear in the input stream, such as the copyright symbol. * (#FM-6068) allow file encoding to be specified Added docs and tests as requested
2017-03-08Merge pull request #734 from pmcmaw/FM-6086-unitTestsTP Honey
(FM-6086) - Unit tests for Resource Types
2017-03-08(FM-6086) - Unit tests for Resource TypesPaula McMaw
2017-03-07(FM-6085) - Unit tests for Data TypesPaula McMaw
2017-03-03Merge pull request #732 from pmcmaw/FM-6063-unitTestsHailee Kenney
(FM-6063) - Unit tests for high effort functions
2017-03-03(FM-6063) - Unit tests for high effort functionsPaula McMaw
2017-03-03(MODULES-4485) Improve ipv6 support for typePeter Souter
* Improves regex to catch some valid (but less known) ipv6 strings, mostly those which are a mix of ipv6 strings and embedded ipv4 numbers * Regex inspired by the following: * https://github.com/sindresorhus/ip-regex * https://gist.github.com/cpetschnig/294476 * The original Dartware forum thread where someone originally created this beast of a regex, now lost except to archive.org * Whilst we're here, we can add the more tricky ipv6 strings to the existing functions to validate * Luckily, the `ipaddr` native ruby library used in the original functions already supports these
2017-02-28loosen the regex for tuple checkingtphoney
2017-02-28(FM-6058) - Unit tests for med effort functionsPaula McMaw
2017-02-23Merge pull request #725 from pmcmaw/FM-6054-unitTestsTP Honey
(FM-6054) - Unit tests for low effort functions
2017-02-23(FM-6054) - Unit tests for low effort functionsPaula McMaw
2017-02-22Merge pull request #723 from ↵TP Honey
tphoney/remove_unsupported_platforms_and_future_parser remove unsupported platforms and future parser
2017-02-21remove unsupported platforms and future parsertphoney
2017-02-21Adding unit test for i18n delete_value functionPaula McMaw
2017-02-21Adding unit test for i18n delete_at functionPaula McMaw
2017-02-21Adding unit test for i18n delete functionPaula McMaw
2017-02-21Adding unit test for i18n count functionPaula McMaw
2017-02-21Adding unit test for i18n concat functionPaula McMaw
2017-02-21Merge pull request #714 from pmcmaw/SPIKEi18NDavid Schmitt
(FM-6019) - i18N tests for Spike
2017-02-21Merge pull request #719 from domcleal/metadata-test-moduleDavid Schmitt
Allow test module metadata.json to be read
2017-02-21Merge pull request #720 from DavidS/fix-hiera-is-not-a-classPaula McMaw
Fix acceptance test failure "Hiera is not a class"
2017-02-20Fix acceptance test failure "Hiera is not a class"David Schmitt
Due to [BKR-969](https://tickets.puppetlabs.com/browse/BKR-969) the global `Hiera` symbol is corrupted. Loading puppet before beaker fixes that.
2017-02-20Merge pull request #715 from domcleal/function-fact-freezeDavid Schmitt
Fix unsupported data type error with rspec-puppet master
2017-02-05Add glob functionSascha Spreitzer
2017-02-04Allow test module metadata.json to be readDominic Cleal
Since puppetlabs/puppet@f2e8e66, the test module's metadata.json is also read causing expectation failures. Like 5c51463, permit it to be read by Puppet.
2017-02-04Fix unsupported data type error with rspec-puppet masterDominic Cleal
The symbol used in the value of the facts hash is not a valid type of value for facts, and results in the following error since rspec-puppet@d50acf0e. Puppet::Error: Unsupported data type: 'Symbol' # puppet/lib/puppet/parser/scope.rb:788:in `deep_freeze' # puppet/lib/puppet/parser/scope.rb:781:in `block in deep_freeze' # puppet/lib/puppet/parser/scope.rb:781:in `each' # puppet/lib/puppet/parser/scope.rb:781:in `deep_freeze' # puppet/lib/puppet/parser/scope.rb:764:in `set_facts' # puppet/lib/puppet/parser/compiler.rb:850:in `set_node_parameters' # puppet/lib/puppet/parser/compiler.rb:166:in `block (2 levels) in compile' # puppet/lib/puppet/util/profiler/around_profiler.rb:58:in `profile' # puppet/lib/puppet/util/profiler.rb:51:in `profile' # puppet/lib/puppet/parser/compiler.rb:166:in `block in compile' # puppet/lib/puppet/context.rb:65:in `override' # puppet/lib/puppet.rb:293:in `override' # puppet/lib/puppet/parser/compiler.rb:162:in `compile' # rspec-puppet/lib/rspec-puppet/example/function_example_group.rb:161:in `build_compiler' The fact's presence doesn't change the behaviour, so remove it.
2017-02-02(FM-6019) - [WIP] - i18N tests for SpikePaula McMaw
2017-01-24(MODULES-4098) Sync the rest of the filesHunter Haugen
2017-01-19Implement beaker-module_install_helperWilson McCoubrey
2017-01-13Addition of compat hash type for deprecationHelen Campbell
2016-12-13Merge pull request #700 from petems/MODULES-4188-uuid_functionBryan Jen
(MODULES-4188) Add UUID generation function
2016-12-09Merge pull request #697 from ↵David Schmitt
HAIL9000/issue/master/MODULES-3829_add_tests_for_ensure_resources (MODULES-3829) Add tests for ensure_resources
2016-12-09(MODULES-3829) Make ensure_packages work with < 2.0Hailee Kenney
Prior to this commit, if a hash was passed in as an argument to the ensure_packages function a method of hash duplication would be used that is not supported with versions of ruby older than 2.0. In order to ensure the method is compatible with older ruby versions, switch to a different method of duplication. Additionally add tests to prevent further regressions.
2016-12-09(MODULES-4188) Add FQDN UUID generation functionPeter Souter
* Generates UUID based on a given FQDN string and the DNS namespace (6ba7b810-9dad-11d1-80b4-00c04fd430c8)
2016-12-08(MODULES-3829) Add tests for ensure_resourcesHailee Kenney
Prior to this commit, we didn't have tests for the ensure_resources function (only for the ensure_resource function). This meant that we weren't catching a bug in the ensure_resources function. In order to prevent this in the future, add some tests which test the specific functionality of ensure_resources.
2016-11-29Update deprecation tests to include future parserHelen Campbell
2016-11-21Revert "Call site output for deprecation warnings"Bryan Jen
2016-11-21Call site display for deprecation warningsHelen Campbell
2016-11-10Merge pull request #632 from MiamiOH/masterWilson McCoubrey
Handle array values in join_keys_to_values function
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-04 15:58:45 +0000