Age | Commit message (Collapse) | Author |
|
(FM-5703, PUP-6717) Remove the dynamic deprecation_gen function
|
|
|
|
This was not working when the puppet master did not have the newest stdlib
version in its environment.
|
|
HAIL9000/issue/master/MODULES-3590_fix_match_for_absence_parameter
(MODULES-3590) Fix match_for_absence parameter
|
|
Prior to this commit, due to a bug in the exists? method in the
file_line provider, match_for_absence didn't work as described (or
at all really). Update the exists? logic so that match_for_absence
works as described.
Additionally add a unit test to prevent regressions and update the
documentation for the parameter to reflect the fact that it is
ignored when `ensure => present`.
|
|
|
|
(MODULES-3933) Fix getparam for 'false' values
|
|
This is the idiomatic version of #634, and also addresses
the test failures.
Original-Fix-By: Michiel Brandenburg <michiel@silverstreet.com>
|
|
|
|
Permit undef passed as `nil` to validate_string
|
|
When validate_string is called via the Puppet 4 deprecation wrappers
from deprecation_gen (introduced in 970852d), `undef` is passed as `nil`
where it was previously passed as `''` from the Puppet 3-style function
API.
This change explicitly permits a `nil` value in validate_string, and
adds a test case to `is_string` which also accepts the same.
Fixes test failures in apt, concat etc:
Error while evaluating a Function Call, nil is not a string. It looks to be a NilClass at apt/manifests/source.pp:23:3 [..]
# ./spec/fixtures/modules/stdlib/lib/puppet/parser/functions/validate_string.rb:34:in `block (2 levels) in <module:Functions>'
# ./spec/fixtures/modules/stdlib/lib/puppet/parser/functions/validate_string.rb:32:in `each'
# ./spec/fixtures/modules/stdlib/lib/puppet/parser/functions/validate_string.rb:32:in `block in <module:Functions>'
# puppet-4.7.0/lib/puppet/parser/functions.rb:174:in `block (2 levels) in newfunction'
# puppet-4.7.0/lib/puppet/util/profiler/around_profiler.rb:58:in `profile'
# puppet-4.7.0/lib/puppet/util/profiler.rb:51:in `profile'
# puppet-4.7.0/lib/puppet/parser/functions.rb:167:in `block in newfunction'
# ./spec/fixtures/modules/stdlib/lib/puppet_x/puppetlabs/stdlib/deprecation_gen.rb:13:in `block (2 levels) in deprecation_gen'
|
|
Ensure validate functions use Puppet 4 deprecation
|
|
|
|
|
|
|
|
Remove duplicate deprecation warnings
|
|
|
|
Add deprecation warnings to remaining validates
|
|
|
|
Revert "Ensure validate functions use Puppet 4 deprecation"
|
|
|
|
Ensure validate functions use Puppet 4 deprecation
|
|
|
|
Add facter fact for puppet_environmentpath
|
|
Fix whitespace
|
|
|
|
Refactor dig44 function
|
|
Change in readme for numerical string
|
|
|
|
(MODULES-3737) refactor validate_legacy and tests
|
|
* validate_legacy now accepts undef values
* update the TypeMismatch message to include the original validate function name
* only notice, not warn, on newly allowed values
* changed previous_validation to function_name to avoid confusion with the function of the same name
* use deprecation() instead of warn(), when hitting a deprecated value
* prepare the tests and function for MODULES-3735
* rewrite validate_legacy tests to use new rspec-puppet
* move validate_re deprecation to puppet4 only
* adapt validate_re_spec
|
|
|
|
Addition of logging with file and line numbers
|
|
|
|
Deprecation function README update
|
|
|
|
Deprecation function to be mutable in all cases
|
|
|
|
Fix validate_legacy docs table formatting
|
|
|
|
|
|
MODULES-3699 Deprecation spec fix 2
|
|
|
|
Update documentation for validate_legacy
|
|
This adds a in-depth explanation of the process to migrate to Puppet 4
data types.
|
|
The current implementation of the dig44 function has the
following problems:
* Doesn't recognise Puppet4's :undef value as an empty value
and doesn't return the default value.
* Doesn't make a different between false and nil value
and returns the default value for a non-empty false value
|
|
Update modulesync_config [a3fe424]
|
|
|
|
(MODULES-3534) Deprecation of ip functions
|
|
|