Age | Commit message (Collapse) | Author |
|
This now emits one deprecation warning for each function used (but not for each call-site). Prior to this, only a single deprecation warning would have been triggered, potentially misleading users.
Additionally this adds v4 deprecation stubs for the functions that were missed.
|
|
Mergeback
|
|
Release prep for 4.13.0
|
|
Apparently mocha 1.2.0 causes an endless hang
on spec/unit/facter/root_home_spec.rb. Forcing
an earlier version avoids this for now.
|
|
* Changelog & Thanks
* Add known issues/version compatiblity to README
* Whitespace fixes
* Update version and dependency information
* Fix issue tracker URL
|
|
Final cleanups
|
|
@keymone added information on how to reproduce his issue, so here's the
test case that would fail without his change.
|
|
|
|
This reverts commit b63862ff43194194f7428739a32cfe13bad1e7ed, as it would
only show the irrelevant first entry of the ruby stack trace. The
puppetserver log does contain the full trace information, or you can use
--strict=error to cause a hard failure when hitting a deprecation.
# Conflicts:
# lib/puppet/functions/validate_legacy.rb
|
|
This patch updates the README to specify that the 'after' parameter
in the file_line class accepts a regular expression.
|
|
`catch` returns value of second argument to `throw`, which until 860a2761f334c964068038b3ef6853f08beb1df5 was `nil`, but now is non-falsey reason for error. short-circuit using return and eval to nil if `throw` was caught.
|
|
Type updates
|
|
|
|
(FM-5703, PUP-6717) Remove the dynamic deprecation_gen function
|
|
|
|
This was not working when the puppet master did not have the newest stdlib
version in its environment.
|
|
HAIL9000/issue/master/MODULES-3590_fix_match_for_absence_parameter
(MODULES-3590) Fix match_for_absence parameter
|
|
Prior to this commit, due to a bug in the exists? method in the
file_line provider, match_for_absence didn't work as described (or
at all really). Update the exists? logic so that match_for_absence
works as described.
Additionally add a unit test to prevent regressions and update the
documentation for the parameter to reflect the fact that it is
ignored when `ensure => present`.
|
|
|
|
(MODULES-3933) Fix getparam for 'false' values
|
|
This is the idiomatic version of #634, and also addresses
the test failures.
Original-Fix-By: Michiel Brandenburg <michiel@silverstreet.com>
|
|
|
|
Permit undef passed as `nil` to validate_string
|
|
When validate_string is called via the Puppet 4 deprecation wrappers
from deprecation_gen (introduced in 970852d), `undef` is passed as `nil`
where it was previously passed as `''` from the Puppet 3-style function
API.
This change explicitly permits a `nil` value in validate_string, and
adds a test case to `is_string` which also accepts the same.
Fixes test failures in apt, concat etc:
Error while evaluating a Function Call, nil is not a string. It looks to be a NilClass at apt/manifests/source.pp:23:3 [..]
# ./spec/fixtures/modules/stdlib/lib/puppet/parser/functions/validate_string.rb:34:in `block (2 levels) in <module:Functions>'
# ./spec/fixtures/modules/stdlib/lib/puppet/parser/functions/validate_string.rb:32:in `each'
# ./spec/fixtures/modules/stdlib/lib/puppet/parser/functions/validate_string.rb:32:in `block in <module:Functions>'
# puppet-4.7.0/lib/puppet/parser/functions.rb:174:in `block (2 levels) in newfunction'
# puppet-4.7.0/lib/puppet/util/profiler/around_profiler.rb:58:in `profile'
# puppet-4.7.0/lib/puppet/util/profiler.rb:51:in `profile'
# puppet-4.7.0/lib/puppet/parser/functions.rb:167:in `block in newfunction'
# ./spec/fixtures/modules/stdlib/lib/puppet_x/puppetlabs/stdlib/deprecation_gen.rb:13:in `block (2 levels) in deprecation_gen'
|
|
Ensure validate functions use Puppet 4 deprecation
|
|
|
|
|
|
|
|
Remove duplicate deprecation warnings
|
|
|
|
Add deprecation warnings to remaining validates
|
|
|
|
Revert "Ensure validate functions use Puppet 4 deprecation"
|
|
|
|
Ensure validate functions use Puppet 4 deprecation
|
|
|
|
Add facter fact for puppet_environmentpath
|
|
Fix whitespace
|
|
|
|
Refactor dig44 function
|
|
Change in readme for numerical string
|
|
|
|
(MODULES-3737) refactor validate_legacy and tests
|
|
* validate_legacy now accepts undef values
* update the TypeMismatch message to include the original validate function name
* only notice, not warn, on newly allowed values
* changed previous_validation to function_name to avoid confusion with the function of the same name
* use deprecation() instead of warn(), when hitting a deprecated value
* prepare the tests and function for MODULES-3735
* rewrite validate_legacy tests to use new rspec-puppet
* move validate_re deprecation to puppet4 only
* adapt validate_re_spec
|
|
|
|
Addition of logging with file and line numbers
|
|
|
|
Deprecation function README update
|
|
|
|
Deprecation function to be mutable in all cases
|