summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-10-07Merge pull request #666 from ↵David Schmitt
HAIL9000/issue/master/MODULES-3590_fix_match_for_absence_parameter (MODULES-3590) Fix match_for_absence parameter
2016-10-06(MODULES-3590) Fix match_for_absence parameterHailee Kenney
Prior to this commit, due to a bug in the exists? method in the file_line provider, match_for_absence didn't work as described (or at all really). Update the exists? logic so that match_for_absence works as described. Additionally add a unit test to prevent regressions and update the documentation for the parameter to reflect the fact that it is ignored when `ensure => present`.
2016-10-06Corrects Puppet version for compat types testsHelen Campbell
2016-10-04Merge pull request #663 from DavidS/modules-3933-getparam-false-valuesEric Putnam
(MODULES-3933) Fix getparam for 'false' values
2016-10-04(MODULES-3933) Fix getparam for 'false' valuesDavid Schmitt
This is the idiomatic version of #634, and also addresses the test failures. Original-Fix-By: Michiel Brandenburg <michiel@silverstreet.com>
2016-10-04MODULES-3774: stdlib validate_legacy reviewjbondpdx
2016-10-04Merge pull request #662 from domcleal/validate-string-undefDavid Schmitt
Permit undef passed as `nil` to validate_string
2016-10-04Permit undef passed as `nil` to validate_stringDominic Cleal
When validate_string is called via the Puppet 4 deprecation wrappers from deprecation_gen (introduced in 970852d), `undef` is passed as `nil` where it was previously passed as `''` from the Puppet 3-style function API. This change explicitly permits a `nil` value in validate_string, and adds a test case to `is_string` which also accepts the same. Fixes test failures in apt, concat etc: Error while evaluating a Function Call, nil is not a string. It looks to be a NilClass at apt/manifests/source.pp:23:3 [..] # ./spec/fixtures/modules/stdlib/lib/puppet/parser/functions/validate_string.rb:34:in `block (2 levels) in <module:Functions>' # ./spec/fixtures/modules/stdlib/lib/puppet/parser/functions/validate_string.rb:32:in `each' # ./spec/fixtures/modules/stdlib/lib/puppet/parser/functions/validate_string.rb:32:in `block in <module:Functions>' # puppet-4.7.0/lib/puppet/parser/functions.rb:174:in `block (2 levels) in newfunction' # puppet-4.7.0/lib/puppet/util/profiler/around_profiler.rb:58:in `profile' # puppet-4.7.0/lib/puppet/util/profiler.rb:51:in `profile' # puppet-4.7.0/lib/puppet/parser/functions.rb:167:in `block in newfunction' # ./spec/fixtures/modules/stdlib/lib/puppet_x/puppetlabs/stdlib/deprecation_gen.rb:13:in `block (2 levels) in deprecation_gen'
2016-10-03Merge pull request #659 from HelenCampbell/omglobDavid Schmitt
Ensure validate functions use Puppet 4 deprecation
2016-10-03Replace :context with :all in spec testsHelen Campbell
2016-10-03Acceptance test cleanupHelen Campbell
2016-10-03Addition of Puppet 4 functionsHelen Campbell
2016-09-26Merge pull request #657 from HelenCampbell/dupRemovalDavid Schmitt
Remove duplicate deprecation warnings
2016-09-26Remove duplicate deprecation warningsHelen Campbell
2016-09-26Merge pull request #656 from HelenCampbell/hashFupdateHunter Haugen
Add deprecation warnings to remaining validates
2016-09-26Add deprecation warnings to remaining validatesHelen Campbell
2016-09-21Merge pull request #655 from puppetlabs/revert-654-puppet4DepDavid Schmitt
Revert "Ensure validate functions use Puppet 4 deprecation"
2016-09-21Revert "Ensure validate functions use Puppet 4 deprecation"Helen
2016-09-21Merge pull request #654 from HelenCampbell/puppet4DepDavid Schmitt
Ensure validate functions use Puppet 4 deprecation
2016-09-21Ensure validate functions use Puppet 4 deprecationHelen Campbell
2016-09-15Merge pull request #648 from stbenjam/environmentpath-factHunter Haugen
Add facter fact for puppet_environmentpath
2016-09-15Merge pull request #653 from hunner/fix_whitespaceBryan Jen
Fix whitespace
2016-09-15Fix whitespaceHunter Haugen
2016-09-15Merge pull request #644 from dmitryilyin/masterBryan Jen
Refactor dig44 function
2016-09-14Merge pull request #652 from pmcmaw/README_numerical_stringDavid Schmitt
Change in readme for numerical string
2016-09-14Change in readme for numerical stringPaula McMaw
2016-09-07Merge pull request #649 from DavidS/modules-3737Hunter Haugen
(MODULES-3737) refactor validate_legacy and tests
2016-09-07(MODULES-3737) validate_legacy: refactoringDavid Schmitt
* validate_legacy now accepts undef values * update the TypeMismatch message to include the original validate function name * only notice, not warn, on newly allowed values * changed previous_validation to function_name to avoid confusion with the function of the same name * use deprecation() instead of warn(), when hitting a deprecated value * prepare the tests and function for MODULES-3735 * rewrite validate_legacy tests to use new rspec-puppet * move validate_re deprecation to puppet4 only * adapt validate_re_spec
2016-09-07Fix assert_private tests to not hit the newly deprecated subject.callDavid Schmitt
2016-09-06Merge pull request #651 from HelenCampbell/deprecationUpdateEric Putnam
Addition of logging with file and line numbers
2016-09-06Addition of logging with file and line numbersHelen Campbell
2016-09-06Merge pull request #650 from HelenCampbell/deprecationUpdateDavid Schmitt
Deprecation function README update
2016-09-06Deprecation README updateHelen Campbell
2016-09-06Merge pull request #641 from HelenCampbell/deprecationUpdateDavid Schmitt
Deprecation function to be mutable in all cases
2016-09-05Deprecation function to be mutable in all casesHelen Campbell
2016-09-02Merge pull request #647 from domcleal/validate-legacy-table-formattingDavid Schmitt
Fix validate_legacy docs table formatting
2016-09-02Add facter fact for puppet_environmentpathStephen Benjamin
2016-09-02Fix validate_legacy docs table formattingDominic Cleal
2016-09-01Merge pull request #646 from eputnam/deprecation_spec_fix_2Bryan Jen
MODULES-3699 Deprecation spec fix 2
2016-09-01(MODULES-3699) fixes deprecation msg testEric Putnam
2016-09-01Merge pull request #645 from DavidS/update-validate_legacy_docsTP Honey
Update documentation for validate_legacy
2016-09-01Update documentation for validate_legacyDavid Schmitt
This adds a in-depth explanation of the process to migrate to Puppet 4 data types.
2016-08-30Refactor dig44 functionDmitry Ilyin
The current implementation of the dig44 function has the following problems: * Doesn't recognise Puppet4's :undef value as an empty value and doesn't return the default value. * Doesn't make a different between false and nil value and returns the default value for a non-empty false value
2016-08-29Merge pull request #642 from puppetlabs/modulesyncEric Putnam
Update modulesync_config [a3fe424]
2016-08-26Update modulesync_config [a3fe424]David Schmitt
2016-08-17Merge pull request #637 from HelenCampbell/ipdeprecationDavid Schmitt
(MODULES-3534) Deprecation of ip functions
2016-08-17Deprecation of ip functionsHelen Campbell
2016-08-15Merge pull request #636 from domcleal/deprecation-warning-loggerDavid Schmitt
(maint) Switch 3.x deprecation() to use Puppet warning logger
2016-08-15(maint) Switch 3.x deprecation() to use Puppet warning loggerDominic Cleal
The deprecation function was calling the `Kernel#warn` function which prints to stderr, rather than the Puppet logger. This causes problems for Puppet module tests on Travis CI, which has a cap on the amount of stdout/err permitted in its logs and also prevents users from finding the deprecation warnings when running under a Puppet master.
2016-08-15Merge pull request #635 from DavidS/fix-ensure_resource-expectationsTP Honey
(MAINT) Update ensure_resource specs
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-30 11:19:23 +0000