summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-04-25(PE-20308) Pass a literal type and not a string to findresourceHunter Haugen
- `defined_with_params` calls `findresource(reference.to_s)` - `findresource` is https://github.com/puppetlabs/puppet/blob/4.8.1/lib/puppet/parser/compiler.rb#L407 and points to https://github.com/puppetlabs/puppet/blob/4.8.1/lib/puppet/resource/catalog.rb#L352 - This calls `Puppet::Resource.new` with the type https://github.com/puppetlabs/puppet/blob/4.8.1/lib/puppet/resource/catalog.rb#L366 - This ends up calling `resource_type` via https://github.com/puppetlabs/puppet/blob/4.8.1/lib/puppet/resource.rb#L317-L319 and that ends up declaring the type via the autoloader api at https://github.com/puppetlabs/puppet/blob/4.8.1/lib/puppet/resource.rb#L390 - But why does the autoloader API fail to find it in the current environment? - Okay, so when the autoloader is trying to find the type, it uses the typeloader to look it up in the current environment https://github.com/puppetlabs/puppet/blob/4.8.1/lib/puppet/metatype/manager.rb#L171 - this calls `get_file` and `mark_loaded` https://github.com/puppetlabs/puppet/blob/4.8.1/lib/puppet/util/autoload.rb#L64-L67 Suggested workaround is to pass a literal type instead of a string to `findresource` to fix in stdlib, and also to fix loading/requiring of type in core puppet. This seems to affect more recent versions of puppet, so fallback to original behavior on pre-4.5
2017-04-25Merge pull request #760 from puppetlabs/releaseEric Putnam
Release mergeback
2017-04-19Merge pull request #758 from sathieu/file_line_ruby18Hunter Haugen
Ruby 1.8 doesn't support open_args
2017-04-18Ruby 1.8 doesn't support open_argsMathieu Parent
Regression from #726
2017-04-14(maint) Stdlib::Compat::Integer accepts numbers with newlines apparentlyHunter Haugen
2017-04-06Merge pull request #755 from rnelson0/patch-1Hunter Haugen
TOC updates
2017-04-05TOC updatesRob Nelson
Add TOC entries for the various reference sections, plus a markdown-related typo in a header
2017-04-04Merge pull request #747 from jbondpdx/loc-editHunter Haugen
(MODULES-4322) pre-loc edit on stdlib README
2017-04-04(MODULES-4322) pre-localization edit on stdlib READMEjbondpdx
So many fixes, just so many.
2017-03-30[msync] 786266 Implement puppet-module-gems, a45803 Remove metadata.json ↵Wilson McCoubrey
from locales config (#754) * [msync] 786266 Implement puppet-module-gems, a45803 Remove metadata.json from locales config * [maint] Fix puppet-lint warnings introduced with 2.2.0 puppet-lint release
2017-03-23Merge pull request #746 from pmcmaw/FM-6116-add-stdlib-potEric Putnam
(FM-6116) - Adding POT file for metadata.json
2017-03-23(FM-6116) - Adding POT file for metadata.jsonPaula McMaw
2017-03-23[MODULES-4528] Replace Puppet.version.to_f version comparison from ↵Wilson McCoubrey
spec_helper.rb (#745)
2017-03-21Merge pull request #718 from sspreitzer/master_globWilson McCoubrey
Add glob function
2017-03-21Merge pull request #743 from domcleal/alias-error-expectationWilson McCoubrey
Update alias spec error message expectation for PUP-7371
2017-03-21Release prep for 4.16.0 (#744)Helen
2017-03-21Update alias spec error message expectation for PUP-7371Dominic Cleal
The fix for PUP-7371 adds the missing `Undef` into the error message being tested in type aliases specs, fixing the following failure against Puppet's master branch: test::string rejects other values [] should fail to compile and raise an error matching /parameter 'value' expects a String/ Failure/Error: it { is_expected.to compile.and_raise_error(/parameter 'value' expects a String/) } error during compilation: Evaluation Error: Error while evaluating a Resource Statement, Class[Test::String]: parameter 'value' expects a value of type Undef or String, got Array at line 2:1 on node example # ./spec/aliases/string_spec.rb:27:in `block (5 levels) in <top (required)>'
2017-03-20Merge pull request #742 from HelenCampbell/releaseyWilson McCoubrey
Release prep for 4.16.0
2017-03-20Release prep for 4.16.0Helen Campbell
2017-03-16Merge pull request #737 from domcleal/versioncmpWilson McCoubrey
(MODULES-4528) Use versioncmp to check Puppet version for 4.10.x compat
2017-03-16Merge pull request #740 from domcleal/abspath-double-slashWilson McCoubrey
Permit double slash in absolute/Unix path types
2017-03-15Merge pull request #741 from HelenCampbell/utf8readmeHailee Kenney
(FM-6051) Adds comments to warn for UTF8 incompatibility
2017-03-15(FM-6051) Adds comments to warn for UTF8 incompatibilityHelen Campbell
2017-03-15Permit double slash in absolute/Unix path typesDominic Cleal
2017-03-14Merge pull request #739 from puppetlabs/releaseEric Putnam
Release mergeback for 4.15.0
2017-03-14Merge pull request #736 from HelenCampbell/lengthfunctDavid Schmitt
Addition of new length function
2017-03-14Addition of new length functionHelen Campbell
2017-03-14(MODULES-4528) Use versioncmp to check Puppet version for 4.10.x compatDominic Cleal
`Puppet.version.to_f` on Puppet 4.10.0 will evaluate to `4.1`, causing test and behavioural changes when conditionals check that the version is equal or greater than versions such as `4.3`. Version comparisons that are vulnerable to this have been changed to use Puppet's versioncmp implementation, while most others only check for for major version boundaries which is safe.
2017-03-13Merge pull request #729 from eputnam/i18n_prepGlenn Sarti
(MODULES-4473) join strings for i18n parser
2017-03-13(#FM-6068) allow file encoding to be specified (#726)Geoff Williams
* (#FM-6068) allow file encoding to be specified Add a new parameter `encoding` to allow non UTF-8 files to specify a file encoding. This prevents receiving the error message "invalid byte sequence in UTF-8" when special characters that are not UTF-8 encoded appear in the input stream, such as the copyright symbol. * (#FM-6068) allow file encoding to be specified Added docs and tests as requested
2017-03-10Merge pull request #735 from bulletproofnetworks/masterWilson McCoubrey
Should only try to apply the resource if it not defined
2017-03-10Should only try to aplpy the resource if it not definedmbakerbp
2017-03-08Merge pull request #734 from pmcmaw/FM-6086-unitTestsTP Honey
(FM-6086) - Unit tests for Resource Types
2017-03-08(FM-6086) - Unit tests for Resource TypesPaula McMaw
2017-03-07Merge pull request #733 from pmcmaw/FM-6085-unitTestsHailee Kenney
(FM-6085) - Unit tests for Data Types
2017-03-07(FM-6085) - Unit tests for Data TypesPaula McMaw
2017-03-03Merge pull request #732 from pmcmaw/FM-6063-unitTestsHailee Kenney
(FM-6063) - Unit tests for high effort functions
2017-03-03(FM-6063) - Unit tests for high effort functionsPaula McMaw
2017-03-03Merge pull request #731 from petems/MODULES-4485-improve_ip6_supportDavid Schmitt
(MODULES-4485) Improve ipv6 support for type
2017-03-03(MODULES-4485) Improve ipv6 support for typePeter Souter
* Improves regex to catch some valid (but less known) ipv6 strings, mostly those which are a mix of ipv6 strings and embedded ipv4 numbers * Regex inspired by the following: * https://github.com/sindresorhus/ip-regex * https://gist.github.com/cpetschnig/294476 * The original Dartware forum thread where someone originally created this beast of a regex, now lost except to archive.org * Whilst we're here, we can add the more tricky ipv6 strings to the existing functions to validate * Luckily, the `ipaddr` native ruby library used in the original functions already supports these
2017-03-01(MODULES-4473) join strings for i18n parserEric Putnam
This commit joins all strings that are split over two lines with a plus, backslash, or double less than so that our magical i18n parser can wave over the module and mark every ruby string with our i18n function.
2017-03-01Merge pull request #728 from tphoney/loosen_regex_testPaula McMaw
loosen the regex for tuple checking
2017-02-28loosen the regex for tuple checkingtphoney
2017-02-28Merge pull request #727 from pmcmaw/FM-6058-unitTestsHelen
(FM-6058) - Unit tests for med effort functions
2017-02-28(FM-6058) - Unit tests for med effort functionsPaula McMaw
2017-02-23Merge pull request #725 from pmcmaw/FM-6054-unitTestsTP Honey
(FM-6054) - Unit tests for low effort functions
2017-02-23(FM-6054) - Unit tests for low effort functionsPaula McMaw
2017-02-22Merge pull request #723 from ↵TP Honey
tphoney/remove_unsupported_platforms_and_future_parser remove unsupported platforms and future parser
2017-02-21remove unsupported platforms and future parsertphoney
2017-02-21Merge pull request #724 from pmcmaw/MODULES-4429-unitTestsHelen
Modules 4429 unit tests