1 files changed, 11 insertions, 9 deletions
diff --git a/spec/functions/is_ipv4_address_spec.rb b/spec/functions/is_ipv4_address_spec.rb
index e39d93b..985260c 100644
--- a/spec/functions/is_ipv4_address_spec.rb
+++ b/spec/functions/is_ipv4_address_spec.rb
@@ -1,15 +1,17 @@
 require 'spec_helper'
 
 describe 'is_ipv4_address' do
-  
+
   it { is_expected.not_to eq(nil) }
   it { is_expected.to run.with_params().and_raise_error(Puppet::ParseError, /wrong number of arguments/i) }
-  it { is_expected.to run.with_params('1.2.3.4').and_return(true) }
-  it { is_expected.to run.with_params('1.2.3.255').and_return(true) }
-  it { is_expected.to run.with_params('1.2.3').and_return(false) }
-  it { is_expected.to run.with_params('1.2.3.4.5').and_return(false) }
-  it { is_expected.to run.with_params('').and_return(false) }
-  it { is_expected.to run.with_params('one').and_return(false) }
+
+  SharedData::IPV4_PATTERNS.each do |value|
+    it { is_expected.to run.with_params(value).and_return(true) }
+  end
+
+  SharedData::IPV4_NEGATIVE_PATTERNS.each do |value|
+    it { is_expected.to run.with_params(value).and_return(false) }
+  end
 
   context 'Checking for deprecation warning', if: Puppet.version.to_f < 4.0 do
     after(:all) do
@@ -19,12 +21,12 @@ describe 'is_ipv4_address' do
     it 'should display a single deprecation' do
       ENV['STDLIB_LOG_DEPRECATIONS'] = "true"
       scope.expects(:warning).with(includes('This method is deprecated'))
-      is_expected.to run.with_params('1.2.3.4').and_return(true)
+      is_expected.to run.with_params(SharedData::IPV4_PATTERNS.first).and_return(true)
     end
     it 'should display no warning for deprecation' do
       ENV['STDLIB_LOG_DEPRECATIONS'] = "false"
       scope.expects(:warning).with(includes('This method is deprecated')).never
-      is_expected.to run.with_params('1.2.3.4').and_return(true)
+      is_expected.to run.with_params(SharedData::IPV4_PATTERNS.first).and_return(true)
     end
   end
 end