From 8552753d9e3ab7662e618c54875e626a2b6926e9 Mon Sep 17 00:00:00 2001 From: Matt Taggart Date: Fri, 10 Feb 2017 13:08:12 -0800 Subject: remove deprecated blacklist the blacklist file was deprecated by upstream in 4.5.7, remove all references to them. Debian wheezy shipped with 4.5.5.3-3 (but could use a backport) and jessie has 4.6.4.3-2 currently. --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'README.md') diff --git a/README.md b/README.md index e7e2985..82c0ab3 100644 --- a/README.md +++ b/README.md @@ -187,7 +187,7 @@ Example from node.pp: shorewall::interface { 'eth0': zone => 'net', rfc1918 => true, - options => 'tcpflags,blacklist,nosmurfs'; + options => 'tcpflags,nosmurfs'; } shorewall::policy { -- cgit v1.2.3 From 4b3f8eac5f343b5ecd2354d16e83256b8413e807 Mon Sep 17 00:00:00 2001 From: Matt Taggart Date: Fri, 10 Feb 2017 13:33:05 -0800 Subject: remove deprecated rfc1918 file this hasn't been supported since 3.x days --- README.md | 1 - 1 file changed, 1 deletion(-) (limited to 'README.md') diff --git a/README.md b/README.md index 82c0ab3..e6fb027 100644 --- a/README.md +++ b/README.md @@ -186,7 +186,6 @@ Example from node.pp: shorewall::interface { 'eth0': zone => 'net', - rfc1918 => true, options => 'tcpflags,nosmurfs'; } -- cgit v1.2.3 From 725b5bdc4c3e278ed34aee408a54a5453a04a41b Mon Sep 17 00:00:00 2001 From: Matt Taggart Date: Fri, 10 Feb 2017 15:06:16 -0800 Subject: add some notes about deprecated features --- README.md | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) (limited to 'README.md') diff --git a/README.md b/README.md index e6fb027..4cb1a8a 100644 --- a/README.md +++ b/README.md @@ -74,6 +74,23 @@ module will not work: CONFIG_PATH="/etc/shorewall/puppet:/etc/shorewall:/usr/share/shorewall" +Warnings +-------- +There are some features that have been deprecated upstream that may still be +supported by this module on certain shorewall major version. Please note +the following: + +* the blacklist file and option is deprecated and replaced by blrules +* the rfc1918 file and norfc1918 option are deprecated +* the tcrules file is deprecated, replaced by mangled +* the routestopped file is deprecated and replaced by stoppedrules +* as of shorewall 4.6.0, SECTION headers need a leading '?' + +You should migrate your own calls to this module to move to the currently +supported methods, we will be dropping support for deprecated features as +the available distribution version permit it. +For more details see http://www.shorewall.net/upgrade_issues.htm + Documentation ------------- -- cgit v1.2.3 From 37bb199434a193dbcd2ad8e42bc5cb024718b884 Mon Sep 17 00:00:00 2001 From: Micah Anderson Date: Sat, 24 Mar 2018 16:39:33 +0100 Subject: This fixes the ?SECTION change. The change requiring ? before SECTION happened in 4.6.0. Our check was only looking at the major version to see if it was 4, and if so, it would not add the ?. This was too imprecise and would not add the ? in versions of shorewall 4.6 and greater. So this commit will change that check to be more specific. --- README.md | 1 - 1 file changed, 1 deletion(-) (limited to 'README.md') diff --git a/README.md b/README.md index 4cb1a8a..4cb8b05 100644 --- a/README.md +++ b/README.md @@ -84,7 +84,6 @@ the following: * the rfc1918 file and norfc1918 option are deprecated * the tcrules file is deprecated, replaced by mangled * the routestopped file is deprecated and replaced by stoppedrules -* as of shorewall 4.6.0, SECTION headers need a leading '?' You should migrate your own calls to this module to move to the currently supported methods, we will be dropping support for deprecated features as -- cgit v1.2.3