summaryrefslogtreecommitdiff
path: root/manifests/cron
AgeCommit message (Collapse)Author
2012-08-10Fix puppet attempting to change the puppet service from 'stopped' to running ↵Micah Anderson
on each run: notice: /Stage[main]/Puppet::Base/Service[puppet]/ensure: ensure changed 'stopped' to 'running' When running in cron mode, you do not want the puppet service enabled, nor do you want it 'running'. When enabling the cron mode, the first part of puppet::cron::base does a Service override on the puppet service to set enable => false. That is a good thing, but all it does is make the service setup so it wont be run on boot. Unfortunately, the puppet service definition also has a 'ensure => running' which does an /etc/init.d/puppet status and then starts the service if it is not running. In a cron-only setup, the 'status' command results in a failure, because the daemon is not running, and then puppet attempts to start it, which goes nowhere because the /etc/default/puppet is configured not to start. So, looking further at puppet::cron::base we see there is a case switch, testing on operatingsystem and if its debian/ubuntu (or openbsd) it falls out of the case. If it is not one of those, it continues and does a test to see if the version of puppet is 2.6 and if so then it does an additional puppet Service override to set ensure=> stopped which keeps the service from being checked to see if it is running, and if it is not starting it. So to fix this, we remove debian/ubuntu from the case, so it will continue through and then we change the $puppet_majorversion test to look for anything greater than or equal to '2.6', since 2.7 and later are also versions we want this to work with. After this change, we no longer get the attempt to restart puppet on every run.
2012-04-12Merge remote-tracking branch 'lelutin/freebsd' into sharedMicah Anderson
2012-04-12implement fix for cron file being put in place even when you do not include ↵Micah Anderson
puppet::cron. The module should make sure that the cron file is not there if you aren't using the cron method, otherwise the daemon and the cronjob could both run. Used suggested change from jcharaoui in #3513
2012-03-01Revert "the debian-specific case doesn't work for squeeze, so re-factor the ↵intrigeri
way it is" This reverts commit d38e7cf64902ff55138e5f85cc7c3b880ea5fb74. Current puppet package in Squeeze does not start by default => no need to special case it.
2011-08-23Add partial freebsd cron job supportGabriel Filion
The puppet::cron::freebsd class is almost identical to the puppet::cron::openbsd one, but there is no cron job to remove, and the /etc/rc.conf mechanism doesn't exist yet for FreeBSD. Signed-off-by: Gabriel Filion <lelutin@gmail.com>
2011-03-29the % needs to be double-escaped so puppet doesn't complain like this:Micah Anderson
Mar 29 14:08:23 puppetmaster puppet-master[26637]: Unrecognised escape sequence '\%' in file /etc/puppet/modules/puppet/manifests/cron/linux.pp at line 17
2011-03-28percent is magic in crontabs and needs to be escapedMatt Taggart
2011-03-28need to escape the $ in the variablesMicah Anderson
2011-03-28update cronjob to capture the return code output as suggested by LeLutin in ↵Micah Anderson
https://labs.riseup.net/code/issues/2819
2011-03-15change the cronjob so that the failure to find any ↵Micah Anderson
(^err:|^alert:|^emerg:|^crit:) in the output from the puppet run doesn't leave us with a '1' return code from grep. On Debian Squeeze systems, this problem would result in cron reporting that the cron command failed with an exit status 1: /USR/SBIN/CRON[24107]: (CRON) error (grandchild #24108 failed with exit status 1) This was because grep returns a '1' if it fails to find a match. We don't want the failure to find failure messages to produce a failure, so this checks the return code of the grep and fixes it to be '0' if there were no such failure log messages. This is a bit ugly, if you ask me. We are already, unfortunately, swallowing the puppetd return code with the grep. It seems like these sorts of log messages should be retrieved via reports, logcheck, or something other than this grep of the output of the cronjob.
2011-03-01the debian-specific case doesn't work for squeeze, so re-factor the way it isMicah Anderson
done to set a flag so that squeeze has the service stopped, but lenny does not
2011-02-14Revert "debian's puppet initscript has status functionality", this seems to ↵Micah Anderson
have been a mistake in a merge commit This reverts commit bb8ede5cfa0bdbdcc0244a590e6453f16d815cb6.
2011-02-11make a puppet::cron::debian class that includes the override of the ↵Micah Anderson
/etc/cron.d/puppetd.cron file resource and move the override from manifests/debian.pp. /etc/cron.d/puppetd.cron is not a valid cronjob according to the run-parts system that Debian uses to decide what is valid, as a result if you were to 'include puppet::cron' in your manifests on a debian/debian-derived system, then a cronjob would be created that would never be executed.
2010-11-28debian's puppet initscript has status functionalityMicah Anderson
Conflicts: manifests/cron/base.pp manifests/debian.pp
2010-11-28Fix whitespace and coding standards to use standard formatting styles (I ↵Micah Anderson
believe that this Closes #2353)
2010-09-15fix some issues with cron enabling/service disablingmh
2010-08-19work around a 2.6 issuemh
2010-08-18puppet binary is in binmh
2010-08-17enable possibility to enforce puppet http_compressionmh
2010-08-17update openbsd stuff to 2.6 stylemh
2010-08-09remove splay from openbsd cronmh
2010-08-08correctly quote new cron timemh
2010-08-07improve puppet_cronmh
* don't use builtin splay, splay runs depending on the fqdn of a host -> puppet isn't running until it really should * fix various things for cron on openbsd
2010-08-06use $puppet_crontime also for openbsdmh
this is a bit hacky, but works.
2010-08-06codestyle - whitespacemh
Only code style and whitespace formatting issues. Everything should no be in ligne.
2010-07-15puppetd doesnt need to get notified at all, its built-invarac
2010-03-07README, added $puppet_crontime to tune how often a client gets updatesnadir
2010-02-04Allowes puppet::cron also on the puppetmaster servervarac
2010-01-19added ubuntu supportvarac
2009-11-01fixing location of binary for 0.25mh
2009-10-31don't notify service if we run as cronmh
2009-10-30set status to false where it isn't already falsemh
2009-10-27fix disabling of the servicemh
- don't use the status of the service script - try to kill puppet _after_ we managed the service
2009-10-04fix define namingmh
2009-01-06merged with puzzlemh
2008-12-27correct namingmh
2008-12-27correct namingmh
2008-12-27complete pathmh
2008-12-27fix test cmdmh
2008-12-27cron should have a new line at the endmh
2008-12-27stopping puppet daemon manuallymh
2008-12-27added a first version to run the client from cronmh