puppet_puppet.git - [puppet

Age	Commit message (Collapse)	Author
2012-08-10	Fix puppet attempting to change the puppet service from 'stopped' to running ↵	Micah Anderson
	on each run: notice: /Stage[main]/Puppet::Base/Service[puppet]/ensure: ensure changed 'stopped' to 'running' When running in cron mode, you do not want the puppet service enabled, nor do you want it 'running'. When enabling the cron mode, the first part of puppet::cron::base does a Service override on the puppet service to set enable => false. That is a good thing, but all it does is make the service setup so it wont be run on boot. Unfortunately, the puppet service definition also has a 'ensure => running' which does an /etc/init.d/puppet status and then starts the service if it is not running. In a cron-only setup, the 'status' command results in a failure, because the daemon is not running, and then puppet attempts to start it, which goes nowhere because the /etc/default/puppet is configured not to start. So, looking further at puppet::cron::base we see there is a case switch, testing on operatingsystem and if its debian/ubuntu (or openbsd) it falls out of the case. If it is not one of those, it continues and does a test to see if the version of puppet is 2.6 and if so then it does an additional puppet Service override to set ensure=> stopped which keeps the service from being checked to see if it is running, and if it is not starting it. So to fix this, we remove debian/ubuntu from the case, so it will continue through and then we change the $puppet_majorversion test to look for anything greater than or equal to '2.6', since 2.7 and later are also versions we want this to work with. After this change, we no longer get the attempt to restart puppet on every run.
2012-03-01	Revert "the debian-specific case doesn't work for squeeze, so re-factor the ↵	intrigeri
	way it is" This reverts commit d38e7cf64902ff55138e5f85cc7c3b880ea5fb74. Current puppet package in Squeeze does not start by default => no need to special case it.
2011-03-01	the debian-specific case doesn't work for squeeze, so re-factor the way it is	Micah Anderson
	done to set a flag so that squeeze has the service stopped, but lenny does not
2011-02-14	Revert "debian's puppet initscript has status functionality", this seems to ↵	Micah Anderson
	have been a mistake in a merge commit This reverts commit bb8ede5cfa0bdbdcc0244a590e6453f16d815cb6.
2010-11-28	debian's puppet initscript has status functionality	Micah Anderson
	Conflicts: manifests/cron/base.pp manifests/debian.pp
2010-11-28	Fix whitespace and coding standards to use standard formatting styles (I ↵	Micah Anderson
	believe that this Closes #2353)
2010-09-15	fix some issues with cron enabling/service disabling	mh

2010-08-19	work around a 2.6 issue	mh

2010-08-06	codestyle - whitespace	mh
	Only code style and whitespace formatting issues. Everything should no be in ligne.
2010-07-15	puppetd doesnt need to get notified at all, its built-in	varac

2010-02-04	Allowes puppet::cron also on the puppetmaster server	varac

2010-01-19	added ubuntu support	varac

2009-10-31	don't notify service if we run as cron	mh

2009-10-30	set status to false where it isn't already false	mh

2009-10-27	fix disabling of the service	mh
	- don't use the status of the service script - try to kill puppet _after_ we managed the service
2008-12-27	fix test cmd	mh

2008-12-27	stopping puppet daemon manually	mh

2008-12-27	added a first version to run the client from cron	mh