From 5d25ec9d1ec77d735d393ef7cab7d1232e3d8997 Mon Sep 17 00:00:00 2001
From: varac <varacanero@zeromail.org>
Date: Thu, 5 Mar 2015 09:23:05 +0100
Subject: fix postfix::satellite class
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

i got this error using postfix::satellite:

  Error: Could not retrieve catalog from remote server: Error 400 on
  SERVER: Cannot reassign variable valid_fqdn at
  /etc/puppet/modules/postfix/manifests/satellite.pp:32 …

reassigning a variable within a given scope doesn't work in puppet
see https://docs.puppetlabs.com/puppet/latest/reference/lang_variables.html#no-reassignment

i still think overriding $::fqdn is not a good idea, but for now,
i just want to get this class working again.
---
 manifests/satellite.pp | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/manifests/satellite.pp b/manifests/satellite.pp
index 739c625..45a40ad 100644
--- a/manifests/satellite.pp
+++ b/manifests/satellite.pp
@@ -21,16 +21,16 @@
 #     }
 #   }
 #
+
 class postfix::satellite(
   $relayhost           = '',
-  $valid_fqdn          = '',
+  $valid_fqdn          = $::fqdn,
   $root_mail_recipient = ''
 ) {
 
-  # If $valid_fqdn exists, use it to override $fqdn
-  case $valid_fqdn {
-    "":      { $valid_fqdn = $::fqdn }
-    default: { $fqdn = "${valid_fqdn}" }
+  # If $valid_fqdn is provided, use it to override $fqdn
+  if $valid_fqdn != $::fdqn {
+    $fqdn = $valid_fqdn
   }
 
   class { 'postfix':
-- 
cgit v1.2.3