From 4bd026dfedc07de63ae5bd8c7ef86eaa70bb6390 Mon Sep 17 00:00:00 2001
From: Gabriel Filion <gabster@lelutin.ca>
Date: Sun, 19 Apr 2015 16:08:38 -0400
Subject: lint plugin.pp

This should make it easier to read the code.
---
 manifests/plugin.pp | 37 +++++++++++++++++++++----------------
 1 file changed, 21 insertions(+), 16 deletions(-)

diff --git a/manifests/plugin.pp b/manifests/plugin.pp
index 6d849fd..f2e4ed2 100644
--- a/manifests/plugin.pp
+++ b/manifests/plugin.pp
@@ -1,22 +1,27 @@
 define nagios::plugin(
-    $source = 'absent',
-    $ensure = present
+  $source = 'absent',
+  $ensure = present
 ){
+  if $::hardwaremodel == 'x86_64' and $::operatingsystem != 'debian' {
+    $real_path = "/usr/lib64/nagios/plugins/${name}"
+  }
+  else {
+    $real_path = "/usr/lib/nagios/plugins/${name}"
+  }
+
+  $real_source = $source ? {
+    'absent' => "puppet:///modules/nagios/plugins/${name}",
+    default => "puppet:///modules/${source}"
+  }
+
   file{$name:
-    path => $::hardwaremodel ? {
-      'x86_64' => $::operatingsystem ? {
-        'debian' => "/usr/lib/nagios/plugins/${name}",
-        default  => "/usr/lib64/nagios/plugins/${name}",
-      },
-      default => "/usr/lib/nagios/plugins/${name}",
-    },
-    ensure => $ensure,
-    source => $source ? {
-      'absent' => "puppet:///modules/nagios/plugins/${name}",
-      default => "puppet:///modules/${source}"
-    },
-    tag => 'nagios_plugin',
+    ensure  => $ensure,
+    path    => $real_path,
+    source  => $real_source,
+    tag     => 'nagios_plugin',
     require => Package['nagios-plugins'],
-    owner => root, group => 0, mode => 0755;
+    owner   => 'root',
+    group   => 0,
+    mode    => '0755';
   }
 }
-- 
cgit v1.2.3