From aa8da42f01d26e184ec110840723355953c42b00 Mon Sep 17 00:00:00 2001 From: Wouter Schoot Date: Mon, 24 Jun 2013 16:19:19 +0200 Subject: Changed include to ordering to prevent duplicate inclusions --- manifests/plugins/setup.pp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'manifests/plugins/setup.pp') diff --git a/manifests/plugins/setup.pp b/manifests/plugins/setup.pp index 197b657..96891d3 100644 --- a/manifests/plugins/setup.pp +++ b/manifests/plugins/setup.pp @@ -1,7 +1,7 @@ class munin::plugins::setup { # This is required for the munin-node service and package requirements below. - include munin::client + Class['munin::client'] -> Class['munin::plugins::setup'] file { [ '/etc/munin/plugins', '/etc/munin/plugin-conf.d' ]: -- cgit v1.2.3 From aaf55c9ebfa0e34f63b2ca3c2b660e1d164026dd Mon Sep 17 00:00:00 2001 From: Ewoud Kohl van Wijngaarden Date: Mon, 6 May 2013 18:13:12 +0200 Subject: lintify --- manifests/plugins/setup.pp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'manifests/plugins/setup.pp') diff --git a/manifests/plugins/setup.pp b/manifests/plugins/setup.pp index 197b657..e6210e9 100644 --- a/manifests/plugins/setup.pp +++ b/manifests/plugins/setup.pp @@ -1,3 +1,4 @@ +# Set up the munin plugins for a node class munin::plugins::setup { # This is required for the munin-node service and package requirements below. @@ -5,10 +6,10 @@ class munin::plugins::setup { file { [ '/etc/munin/plugins', '/etc/munin/plugin-conf.d' ]: - ignore => 'snmp_*', ensure => directory, + ignore => 'snmp_*', checksum => mtime, - recurse => true, + recurse => true, purge => true, force => true, notify => Service['munin-node'], -- cgit v1.2.3 From 26224742940b06335bca3cb8f5e09d0c0a5cabef Mon Sep 17 00:00:00 2001 From: Tomas Barton Date: Sun, 13 Oct 2013 20:24:20 +0200 Subject: Class[] -> Class[] requirement replaced by an anchor --- manifests/plugins/setup.pp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'manifests/plugins/setup.pp') diff --git a/manifests/plugins/setup.pp b/manifests/plugins/setup.pp index e0826f0..e1a57d9 100644 --- a/manifests/plugins/setup.pp +++ b/manifests/plugins/setup.pp @@ -1,12 +1,10 @@ # Set up the munin plugins for a node class munin::plugins::setup { - # This is required for the munin-node service and package requirements below. - Class['munin::client'] -> Class['munin::plugins::setup'] - file { [ '/etc/munin/plugins', '/etc/munin/plugin-conf.d' ]: ensure => directory, + require => Anchor['munin::client::installed'], ignore => 'snmp_*', checksum => mtime, recurse => true, @@ -18,6 +16,7 @@ class munin::plugins::setup { mode => '0755'; '/etc/munin/plugin-conf.d/munin-node': ensure => present, + require => Anchor['munin::client::installed'], notify => Service['munin-node'], owner => root, group => 0, -- cgit v1.2.3 From ad37140f6123c0e85cfbeb23dee5b3ea3c324701 Mon Sep 17 00:00:00 2001 From: mh Date: Sun, 3 Nov 2013 17:55:54 +0100 Subject: remove anchor dependency - fixed #26 given that all os are using package installation now, we can replace the anchor with the package dependency. It also caused a dependency cycle as the anchor was for the whole class and not only the package installation. --- manifests/plugins/setup.pp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'manifests/plugins/setup.pp') diff --git a/manifests/plugins/setup.pp b/manifests/plugins/setup.pp index e1a57d9..23222ec 100644 --- a/manifests/plugins/setup.pp +++ b/manifests/plugins/setup.pp @@ -4,7 +4,7 @@ class munin::plugins::setup { file { [ '/etc/munin/plugins', '/etc/munin/plugin-conf.d' ]: ensure => directory, - require => Anchor['munin::client::installed'], + require => Package['munin-node'], ignore => 'snmp_*', checksum => mtime, recurse => true, @@ -16,7 +16,7 @@ class munin::plugins::setup { mode => '0755'; '/etc/munin/plugin-conf.d/munin-node': ensure => present, - require => Anchor['munin::client::installed'], + require => Package['munin-node'], notify => Service['munin-node'], owner => root, group => 0, -- cgit v1.2.3 From d92912ba27c1234e6f6072a3b922beabbd28dd98 Mon Sep 17 00:00:00 2001 From: mh Date: Sun, 3 Nov 2013 18:28:30 +0100 Subject: remove unnecessary dependencies --- manifests/plugins/setup.pp | 13 ------------- 1 file changed, 13 deletions(-) (limited to 'manifests/plugins/setup.pp') diff --git a/manifests/plugins/setup.pp b/manifests/plugins/setup.pp index 23222ec..a3f3b22 100644 --- a/manifests/plugins/setup.pp +++ b/manifests/plugins/setup.pp @@ -16,22 +16,9 @@ class munin::plugins::setup { mode => '0755'; '/etc/munin/plugin-conf.d/munin-node': ensure => present, - require => Package['munin-node'], notify => Service['munin-node'], owner => root, group => 0, mode => '0640'; } - case $::kernel { - openbsd: { - File['/etc/munin/plugin-conf.d/munin-node']{ - before => File['/var/run/munin'], - } - } - default: { - File['/etc/munin/plugin-conf.d/munin-node']{ - before => Package['munin-node'], - } - } - } } -- cgit v1.2.3