From 24cea641287831a1ea32574e3b62ba858b89f0de Mon Sep 17 00:00:00 2001 From: Jefferson Stachelski Date: Wed, 17 Feb 2016 17:00:52 -0200 Subject: Fixed bug removing duplicated attachment Issue #549 --- .../test/spec/mail_view/ui/attachment_list.spec.js | 26 ++++++++++++---------- 1 file changed, 14 insertions(+), 12 deletions(-) (limited to 'web-ui/test/spec') diff --git a/web-ui/test/spec/mail_view/ui/attachment_list.spec.js b/web-ui/test/spec/mail_view/ui/attachment_list.spec.js index eab605d6..c0e2a5ef 100644 --- a/web-ui/test/spec/mail_view/ui/attachment_list.spec.js +++ b/web-ui/test/spec/mail_view/ui/attachment_list.spec.js @@ -123,47 +123,49 @@ describeMixin('mail_view/ui/attachment_list', function () { describe('Remove attachment', function () { it('should call the remove attachment method when triggered the removeAttachement event', function () { - var stubAttachment = {ident: 'whatever'}; + var stubAttachment = {ident: 'whatever', element: 'element'}; spyOn(this.component, 'removeAttachmentFromList'); spyOn(this.component, 'destroyAttachmentElement'); $(document).trigger(Pixelated.events.mail.removeAttachment, stubAttachment); - expect(this.component.removeAttachmentFromList).toHaveBeenCalledWith(stubAttachment); - expect(this.component.destroyAttachmentElement).toHaveBeenCalledWith(stubAttachment); + expect(this.component.removeAttachmentFromList).toHaveBeenCalledWith('whatever'); + expect(this.component.destroyAttachmentElement).toHaveBeenCalledWith('element'); }); it('should remove the attachment item from the DOM', function () { - var stubAttachment = {ident: 'whatever'}; + var stubAttachment = {ident: 'whatever', element: 'element'}; this.setupComponent('
' + - '' + + '' + '' + '
'); + var element = this.component.$node.find('i.remove-icon'); + expect(this.component.$node.find('li[data-ident=whatever]').length).toEqual(1); - this.component.destroyAttachmentElement(stubAttachment); + this.component.destroyAttachmentElement(element); expect(this.component.$node.find('li[data-ident=whatever]').length).toEqual(0); }); it('should remove attachment from attachment list', function () { - var stubAttachment = {ident: 'whatever'}; - this.component.attr.attachments = [stubAttachment, {ident: 'another attachment'}]; - this.component.removeAttachmentFromList(stubAttachment); + var stubAttachment = {ident: 'whatever', element: 'element'}; + this.component.attr.attachments = [{ident: 'whatever'}, {ident: 'another attachment'}]; + this.component.removeAttachmentFromList('whatever'); expect(this.component.attr.attachments).toEqual([{ident: 'another attachment'}]); }); it('when remove attachment that is not on the attachment list should not do anything', function () { - var stubAttachment = {ident: 'whatever'}; - this.component.attr.attachments = [stubAttachment]; + var stubAttachment = {ident: 'whatever', element: 'element'}; + this.component.attr.attachments = [{ident: 'whatever'}]; this.component.removeAttachmentFromList({ident: 'different attachment'}); - expect(this.component.attr.attachments).toEqual([stubAttachment]); + expect(this.component.attr.attachments).toEqual([{ident: 'whatever'}]); }); }); }); -- cgit v1.2.3