From fec26b211a42b068e677ac5b43080bd4bf59e47a Mon Sep 17 00:00:00 2001 From: Thais Siqueira Date: Fri, 24 Feb 2017 14:27:31 -0300 Subject: [#907] Moves tests to directories components --- web-ui/src/backup_account/page.spec.js | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) create mode 100644 web-ui/src/backup_account/page.spec.js (limited to 'web-ui/src/backup_account/page.spec.js') diff --git a/web-ui/src/backup_account/page.spec.js b/web-ui/src/backup_account/page.spec.js new file mode 100644 index 00000000..66d2dc78 --- /dev/null +++ b/web-ui/src/backup_account/page.spec.js @@ -0,0 +1,25 @@ +import { shallow } from 'enzyme'; +import expect from 'expect'; +import React from 'react'; +import { Page } from 'src/backup_account/page'; + +describe('Page', () => { + let page; + + beforeEach(() => { + const mockTranslations = key => key; + page = shallow(); + }); + + it('renders backup email page title', () => { + expect(page.find('h1').text()).toEqual('backup-account.title'); + }); + + it('renders backup account email input field', () => { + expect(page.find('InputField').props().name).toEqual('email'); + }); + + it('renders backup account submit button', () => { + expect(page.find('SubmitButton').props().buttonText).toEqual('backup-account.button'); + }); +}); -- cgit v1.2.3 From ef173d95b22154ee72c685cd6d5b04e9473dc988 Mon Sep 17 00:00:00 2001 From: Thais Siqueira Date: Fri, 24 Feb 2017 14:48:20 -0300 Subject: [#907] Renames components tests --- web-ui/src/backup_account/page.spec.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'web-ui/src/backup_account/page.spec.js') diff --git a/web-ui/src/backup_account/page.spec.js b/web-ui/src/backup_account/page.spec.js index 66d2dc78..ece61336 100644 --- a/web-ui/src/backup_account/page.spec.js +++ b/web-ui/src/backup_account/page.spec.js @@ -3,7 +3,7 @@ import expect from 'expect'; import React from 'react'; import { Page } from 'src/backup_account/page'; -describe('Page', () => { +describe('BackupAccount', () => { let page; beforeEach(() => { -- cgit v1.2.3 From dc982839a98e2b165832dc243ec17d7631dec769 Mon Sep 17 00:00:00 2001 From: Tayane Fernandes Date: Thu, 9 Mar 2017 17:44:34 -0300 Subject: [#923] Add email validation error on backup account page We added a library to do the validation and we are calling the email validation when the field changes the value. with @FrailWords --- web-ui/src/backup_account/page.spec.js | 14 ++++++++++++++ 1 file changed, 14 insertions(+) (limited to 'web-ui/src/backup_account/page.spec.js') diff --git a/web-ui/src/backup_account/page.spec.js b/web-ui/src/backup_account/page.spec.js index ece61336..f9c5251a 100644 --- a/web-ui/src/backup_account/page.spec.js +++ b/web-ui/src/backup_account/page.spec.js @@ -22,4 +22,18 @@ describe('BackupAccount', () => { it('renders backup account submit button', () => { expect(page.find('SubmitButton').props().buttonText).toEqual('backup-account.button'); }); + + describe('Email validation', () => { + it('should set error in state when email is invalid', () => { + var pageInstance = page.instance(); + pageInstance.validateEmail({target: {value: 'test'}}); + expect(pageInstance.state.error).toEqual('Your email is invalid'); + }); + + it('should not set error in state when email is valid', () => { + var pageInstance = page.instance(); + pageInstance.validateEmail({target: {value: 'test@test.com'}}); + expect(pageInstance.state.error).toEqual(''); + }); + }); }); -- cgit v1.2.3 From aad05a38511a8bdd9bd13d2d38092ce6b35ac46b Mon Sep 17 00:00:00 2001 From: Tayane Fernandes Date: Thu, 9 Mar 2017 18:54:10 -0300 Subject: [#923] Disable button when the email is invalid on the backup email page with @FrailWords --- web-ui/src/backup_account/page.spec.js | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) (limited to 'web-ui/src/backup_account/page.spec.js') diff --git a/web-ui/src/backup_account/page.spec.js b/web-ui/src/backup_account/page.spec.js index f9c5251a..30aefc96 100644 --- a/web-ui/src/backup_account/page.spec.js +++ b/web-ui/src/backup_account/page.spec.js @@ -24,16 +24,29 @@ describe('BackupAccount', () => { }); describe('Email validation', () => { + let pageInstance; + + beforeEach(() => { + pageInstance = page.instance(); + }); + it('should set error in state when email is invalid', () => { - var pageInstance = page.instance(); - pageInstance.validateEmail({target: {value: 'test'}}); + pageInstance.validateEmail({ target: { value: 'test' } }); expect(pageInstance.state.error).toEqual('Your email is invalid'); }); it('should not set error in state when email is valid', () => { - var pageInstance = page.instance(); - pageInstance.validateEmail({target: {value: 'test@test.com'}}); + pageInstance.validateEmail({ target: { value: 'test@test.com' } }); expect(pageInstance.state.error).toEqual(''); }); + + it('submit button should be disabled when email field is empty', () => { + expect(page.find('SubmitButton').props().disabled).toEqual(true); + }); + + it('submit button should be enabled when email field is valid', () => { + pageInstance.setState({ validEmail: true }); + expect(page.find('SubmitButton').props().disabled).toEqual(false); + }); }); }); -- cgit v1.2.3 From 9e5dce775c51b44cf7b17d8ab564fdefc16a06c0 Mon Sep 17 00:00:00 2001 From: Tayane Fernandes Date: Fri, 10 Mar 2017 15:25:43 -0300 Subject: [#923] Fix the submit button when the email is empty When the email is empty the button should be disabled, but we should not see any error message with @FrailWords --- web-ui/src/backup_account/page.spec.js | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) (limited to 'web-ui/src/backup_account/page.spec.js') diff --git a/web-ui/src/backup_account/page.spec.js b/web-ui/src/backup_account/page.spec.js index 30aefc96..9a79392c 100644 --- a/web-ui/src/backup_account/page.spec.js +++ b/web-ui/src/backup_account/page.spec.js @@ -30,23 +30,27 @@ describe('BackupAccount', () => { pageInstance = page.instance(); }); - it('should set error in state when email is invalid', () => { + it('verify initial state', () => { + expect(pageInstance.state.error).toEqual(''); + expect(page.find('SubmitButton').props().disabled).toEqual(true); + }); + + it('should set error in state and disabled submit button when email is invalid', () => { pageInstance.validateEmail({ target: { value: 'test' } }); expect(pageInstance.state.error).toEqual('Your email is invalid'); + expect(page.find('SubmitButton').props().disabled).toEqual(true); }); - it('should not set error in state when email is valid', () => { + it('should not set error in state and submit button is enabled when email is valid', () => { pageInstance.validateEmail({ target: { value: 'test@test.com' } }); expect(pageInstance.state.error).toEqual(''); + expect(page.find('SubmitButton').props().disabled).toEqual(false); }); - it('submit button should be disabled when email field is empty', () => { + it('should not set error in state and disable submit button when email is empty', () => { + pageInstance.validateEmail({ target: { value: '' } }); + expect(pageInstance.state.error).toEqual(''); expect(page.find('SubmitButton').props().disabled).toEqual(true); }); - - it('submit button should be enabled when email field is valid', () => { - pageInstance.setState({ validEmail: true }); - expect(page.find('SubmitButton').props().disabled).toEqual(false); - }); }); }); -- cgit v1.2.3 From 3c1cf6548939d164c4296eeaf637ec4a9901b0f4 Mon Sep 17 00:00:00 2001 From: Tayane Fernandes Date: Fri, 10 Mar 2017 16:11:07 -0300 Subject: [#923] Add translation for the validation error @FrailWords --- web-ui/src/backup_account/page.spec.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'web-ui/src/backup_account/page.spec.js') diff --git a/web-ui/src/backup_account/page.spec.js b/web-ui/src/backup_account/page.spec.js index 9a79392c..f3590ed8 100644 --- a/web-ui/src/backup_account/page.spec.js +++ b/web-ui/src/backup_account/page.spec.js @@ -37,7 +37,7 @@ describe('BackupAccount', () => { it('should set error in state and disabled submit button when email is invalid', () => { pageInstance.validateEmail({ target: { value: 'test' } }); - expect(pageInstance.state.error).toEqual('Your email is invalid'); + expect(pageInstance.state.error).toEqual('backup-account.error.invalid-email'); expect(page.find('SubmitButton').props().disabled).toEqual(true); }); -- cgit v1.2.3 From def51d0d4265e9a489d05ca8cb4bec6abb26073f Mon Sep 17 00:00:00 2001 From: Sriram Viswanathan Date: Fri, 10 Mar 2017 17:36:24 -0300 Subject: [#923] Separate out asserts into different tests with @tayanefernandes --- web-ui/src/backup_account/page.spec.js | 48 +++++++++++++++++++++++++--------- 1 file changed, 36 insertions(+), 12 deletions(-) (limited to 'web-ui/src/backup_account/page.spec.js') diff --git a/web-ui/src/backup_account/page.spec.js b/web-ui/src/backup_account/page.spec.js index f3590ed8..334d3ba8 100644 --- a/web-ui/src/backup_account/page.spec.js +++ b/web-ui/src/backup_account/page.spec.js @@ -35,22 +35,46 @@ describe('BackupAccount', () => { expect(page.find('SubmitButton').props().disabled).toEqual(true); }); - it('should set error in state and disabled submit button when email is invalid', () => { - pageInstance.validateEmail({ target: { value: 'test' } }); - expect(pageInstance.state.error).toEqual('backup-account.error.invalid-email'); - expect(page.find('SubmitButton').props().disabled).toEqual(true); + context('with invalid email', () => { + beforeEach(() => { + pageInstance.validateEmail({ target: { value: 'test' } }); + }); + + it('sets error in state', () => { + expect(pageInstance.state.error).toEqual('backup-account.error.invalid-email'); + }); + + it('disables submit button', () => { + expect(page.find('SubmitButton').props().disabled).toEqual(true); + }); }); - it('should not set error in state and submit button is enabled when email is valid', () => { - pageInstance.validateEmail({ target: { value: 'test@test.com' } }); - expect(pageInstance.state.error).toEqual(''); - expect(page.find('SubmitButton').props().disabled).toEqual(false); + context('with valid email', () => { + beforeEach(() => { + pageInstance.validateEmail({ target: { value: 'test@test.com' } }); + }); + + it('does not set error in state', () => { + expect(pageInstance.state.error).toEqual(''); + }); + + it('submit button is enabled', () => { + expect(page.find('SubmitButton').props().disabled).toEqual(false); + }); }); - it('should not set error in state and disable submit button when email is empty', () => { - pageInstance.validateEmail({ target: { value: '' } }); - expect(pageInstance.state.error).toEqual(''); - expect(page.find('SubmitButton').props().disabled).toEqual(true); + context('with empty email', () => { + beforeEach(() => { + pageInstance.validateEmail({ target: { value: '' } }); + }); + + it('not set error in state', () => { + expect(pageInstance.state.error).toEqual(''); + }); + + it('disables submit button', () => { + expect(page.find('SubmitButton').props().disabled).toEqual(true); + }); }); }); }); -- cgit v1.2.3