From 82d4432b977e0960746bba1c6f03077fb6322263 Mon Sep 17 00:00:00 2001
From: NavaL <ayoyo@thoughtworks.com>
Date: Mon, 22 Feb 2016 15:11:10 +0100
Subject: Removes stacktrace errors from appearing on the login page. Instead
 shows a generic: "invalid xml format" message

Issue #214
---
 service/test/unit/resources/test_login_resource.py | 23 ++++++++++++++++++++++
 1 file changed, 23 insertions(+)

(limited to 'service/test/unit/resources/test_login_resource.py')

diff --git a/service/test/unit/resources/test_login_resource.py b/service/test/unit/resources/test_login_resource.py
index 3cd9d3b2..d8194156 100644
--- a/service/test/unit/resources/test_login_resource.py
+++ b/service/test/unit/resources/test_login_resource.py
@@ -99,6 +99,29 @@ class TestLoginResource(unittest.TestCase):
         d.addCallback(tear_down)
         return d
 
+    def test_non_xml_compliant_banner_will_send_default_invalid_format_banner(self):
+        request = DummyRequest([''])
+
+        banner_file_name = 'banner.txt'
+        xml_invalid_banner = '<p>some unclosed paragraph'
+        self._write(banner_file_name, xml_invalid_banner)
+
+        self.resource._disclaimer_banner = 'service/_trial_temp/' + banner_file_name
+
+        d = self.web.get(request)
+
+        def assert_default_invalid_banner_disclaimer_rendered(_):
+            self.assertEqual(200, request.responseCode)
+            written_response = ''.join(request.written)
+            self.assertIn("Invalid XML template format for service/_trial_temp/banner.txt.", written_response)
+
+        def tear_down(_):
+            os.remove(banner_file_name)
+
+        d.addCallback(assert_default_invalid_banner_disclaimer_rendered)
+        d.addCallback(tear_down)
+        return d
+
 
 class TestLoginPOST(unittest.TestCase):
     def setUp(self):
-- 
cgit v1.2.3