From 1082f233962953c0927b73e7acac2665d420857b Mon Sep 17 00:00:00 2001 From: Duda Dornelles Date: Fri, 26 Sep 2014 13:11:00 -0300 Subject: Fixing tests --- service/test/adapter/mail_service_test.py | 4 + service/test/adapter/pixelated_mail_sender_test.py | 11 +- service/test/adapter/pixelated_mail_test.py | 158 ++++++++------------- service/test/adapter/pixelated_mailbox_test.py | 53 ++----- service/test/adapter/pixelated_mailboxes_test.py | 31 ++-- service/test/adapter/test_helper.py | 37 +++-- service/test/adapter/test_tag_service.py | 6 +- 7 files changed, 133 insertions(+), 167 deletions(-) (limited to 'service/test/adapter') diff --git a/service/test/adapter/mail_service_test.py b/service/test/adapter/mail_service_test.py index 517368e2..38542cac 100644 --- a/service/test/adapter/mail_service_test.py +++ b/service/test/adapter/mail_service_test.py @@ -17,10 +17,14 @@ import unittest from pixelated.adapter.mail_service import MailService from mockito import * +import pixelated.adapter.soledad_querier class TestMailService(unittest.TestCase): def setUp(self): + self.querier = mock() + pixelated.adapter.soledad_querier.get_soledad_querier_instance = lambda x, y: self.querier + self.mailboxes = mock() self.mail_sender = mock() self.mail_service = MailService(self.mailboxes, self.mail_sender) diff --git a/service/test/adapter/pixelated_mail_sender_test.py b/service/test/adapter/pixelated_mail_sender_test.py index b41f1d0c..d75aa57c 100644 --- a/service/test/adapter/pixelated_mail_sender_test.py +++ b/service/test/adapter/pixelated_mail_sender_test.py @@ -27,12 +27,13 @@ class PixelatedMailSenderTest(unittest.TestCase): self.mail_sender = PixelatedMailSender(self.mail_address, self.smtp_client) def test_send_mail_sends_to_To_Cc_and_Bcc(self): - mail_dict = test_helper.mail_dict() - mail_dict['header']['to'] = ['to@pixelated.org', 'anotherto@pixelated.org'] - mail_dict['header']['cc'] = ['cc@pixelated.org', 'anothercc@pixelated.org'] - mail_dict['header']['bcc'] = ['bcc@pixelated.org', 'anotherbcc@pixelated.org'] + headers = { + 'To': ['to@pixelated.org', 'anotherto@pixelated.org'], + 'Cc': ['cc@pixelated.org', 'anothercc@pixelated.org'], + 'Bcc': ['bcc@pixelated.org', 'anotherbcc@pixelated.org'] + } - mail = PixelatedMail.from_dict(mail_dict) + mail = PixelatedMail.from_soledad(*test_helper.leap_mail(extra_headers=headers)) mail.to_smtp_format = lambda: "mail as smtp string" self.mail_sender.sendmail(mail) diff --git a/service/test/adapter/pixelated_mail_test.py b/service/test/adapter/pixelated_mail_test.py index 0a103cce..c8c23b8a 100644 --- a/service/test/adapter/pixelated_mail_test.py +++ b/service/test/adapter/pixelated_mail_test.py @@ -18,81 +18,83 @@ import os import pixelated.support.date import test_helper -from pixelated.adapter.pixelated_mail import PixelatedMail +from pixelated.adapter.pixelated_mail import PixelatedMail, InputMail from pixelated.adapter.tag_service import TagService from pixelated.adapter.tag_index import TagIndex from pixelated.adapter.tag import Tag -from mock import Mock - +from mockito import * class TestPixelatedMail(unittest.TestCase): - mail_dict = lambda x: { - 'body': 'Este \xe9 o corpo', - 'header': { - 'cc': ['cc@pixelated.org', 'anothercc@pixelated.org'], - 'to': ['to@pixelated.org', 'anotherto@pixelated.org'], - 'bcc': ['bcc@pixelated.org', 'anotherbcc@pixelated.org'], - 'subject': 'Oi' - }, - 'ident': '', - 'tags': ['sent'] - } - def test_parse_date_from_leap_mail_uses_date_header_if_available(self): + def setUp(self): + self.querier = mock() + + def test_parse_date_from_soledad_uses_date_header_if_available(self): leap_mail_date = 'Wed, 3 Sep 2014 12:36:17 -0300' leap_mail_date_in_iso_format = "2014-09-03T12:36:17-03:00" leap_mail = test_helper.leap_mail(headers={'date': leap_mail_date}) - mail = PixelatedMail.from_leap_mail(leap_mail) + mail = PixelatedMail.from_soledad(*leap_mail, soledad_querier=self.querier) - self.assertEqual(str(mail.headers['date']), leap_mail_date_in_iso_format) + self.assertEqual(str(mail.headers['Date']), leap_mail_date_in_iso_format) - def test_parse_date_from_leap_mail_fallback_to_received_header_if_date_header_isnt_available(self): + def test_parse_date_from_soledad_fallback_to_received_header_if_date_header_isnt_available(self): leap_mail_date = "Wed, 03 Sep 2014 13:11:15 -0300" leap_mail_date_in_iso_format = "2014-09-03T13:11:15-03:00" leap_mail_received_header = "by bitmask.local from 127.0.0.1 with ESMTP ;\n " + leap_mail_date leap_mail = test_helper.leap_mail(headers={'received': leap_mail_received_header}) - mail = PixelatedMail.from_leap_mail(leap_mail) + mail = PixelatedMail.from_soledad(*leap_mail, soledad_querier=self.querier) - self.assertEqual(str(mail.headers['date']), leap_mail_date_in_iso_format) + self.assertEqual(str(mail.headers['Date']), leap_mail_date_in_iso_format) - def test_from_dict(self): - mail = PixelatedMail.from_dict(self.mail_dict()) + def test_update_tags_return_a_set_with_the_current_tags(self): + soledad_docs = test_helper.leap_mail(extra_headers={'X-tags': '["custom_1", "custom_2"]'}) + pixelated_mail = PixelatedMail.from_soledad(*soledad_docs, soledad_querier=self.querier) - self.assertEqual(mail.headers['cc'], ['cc@pixelated.org', 'anothercc@pixelated.org']) - self.assertEqual(mail.headers['to'], ['to@pixelated.org', 'anotherto@pixelated.org']) - self.assertEqual(mail.headers['bcc'], ['bcc@pixelated.org', 'anotherbcc@pixelated.org']) - self.assertEqual(mail.headers['subject'], 'Oi') - self.assertEqual(mail.ident, None) - self.assertEqual(mail.tags, set(['sent'])) - self.assertEqual(mail.body, 'Este \xe9 o corpo') + current_tags = pixelated_mail.update_tags({'custom_1', 'custom_3'}) + self.assertEquals({'custom_3', 'custom_1'}, current_tags) - def test_from_dict_adds_current_date(self): - pixelated.support.date.iso_now = lambda: 'date now' + def test_mark_as_read(self): + mail = PixelatedMail.from_soledad(*test_helper.leap_mail(flags=[]), soledad_querier=self.querier) - mail = PixelatedMail.from_dict(self.mail_dict()) + mail.mark_as_read() - self.assertEqual('date now', mail.headers['date']) + self.assertEquals(mail.fdoc.content['flags'], ['\\Seen']) - def test_update_tags_return_a_set_with_the_current_tags(self): - pixelated_mail = PixelatedMail.from_leap_mail(test_helper.leap_mail(extra_headers={'X-tags': '["custom_1", "custom_2"]'}), Mock()) - current_tags = pixelated_mail.update_tags(set(['custom_1', 'custom_3'])) - self.assertEquals(set(['custom_3', 'custom_1']), current_tags) + def test_mark_as_not_recent(self): + mail = PixelatedMail.from_soledad(*test_helper.leap_mail(flags=['\\Recent']), soledad_querier=self.querier) - def test_to_mime_multipart(self): - pixelated.support.date.iso_now = lambda: 'date now' + mail.mark_as_not_recent() - mime_multipart = PixelatedMail.from_dict(self.mail_dict()).to_mime_multipart() + self.assertEquals(mail.fdoc.content['flags'], []) + + def test_update_tags_notifies_tag_service(self): + db_path = '/tmp/test_update_tags_notifies_tag_service' + tag_service = TagService(TagIndex(db_path)) + + mail = PixelatedMail.from_soledad(*test_helper.leap_mail(), soledad_querier=self.querier) + + mail.update_tags({'new_tag'}) + self.assertIn(Tag('new_tag'), tag_service.all_tags()) + + os.remove(db_path + '.db') + +class InputMailTest(unittest.TestCase): + mail_dict = lambda x: { + 'body': 'Este \xe9 o corpo', + 'header': { + 'cc': ['cc@pixelated.org', 'anothercc@pixelated.org'], + 'to': ['to@pixelated.org', 'anotherto@pixelated.org'], + 'bcc': ['bcc@pixelated.org', 'anotherbcc@pixelated.org'], + 'subject': 'Oi' + }, + 'ident': '', + 'tags': ['sent'] + } - self.assertRegexpMatches(mime_multipart.as_string(), "\nTo: to@pixelated.org, anotherto@pixelated.org\n") - self.assertRegexpMatches(mime_multipart.as_string(), "\nCc: cc@pixelated.org, anothercc@pixelated.org\n") - self.assertRegexpMatches(mime_multipart.as_string(), "\nBcc: bcc@pixelated.org, anotherbcc@pixelated.org\n") - self.assertRegexpMatches(mime_multipart.as_string(), "\nDate: date now\n") - self.assertRegexpMatches(mime_multipart.as_string(), "\nSubject: Oi\n") - self.assertRegexpMatches(mime_multipart.as_string(), "\nEste \xe9 o corpo") def test_to_mime_multipart_should_add_blank_fields(self): pixelated.support.date.iso_now = lambda: 'date now' @@ -103,66 +105,30 @@ class TestPixelatedMail(unittest.TestCase): mail_dict['header']['cc'] = '' mail_dict['header']['subject'] = '' - mime_multipart = PixelatedMail.from_dict(mail_dict).to_mime_multipart() + mime_multipart = InputMail.from_dict(mail_dict).to_mime_multipart() self.assertNotRegexpMatches(mime_multipart.as_string(), "\nTo: \n") self.assertNotRegexpMatches(mime_multipart.as_string(), "\nBcc: \n") self.assertNotRegexpMatches(mime_multipart.as_string(), "\nCc: \n") self.assertNotRegexpMatches(mime_multipart.as_string(), "\nSubject: \n") - def test_smtp_format(self): - PixelatedMail.from_email_address = 'pixelated@org' - mail = PixelatedMail.from_dict(self.mail_dict()) - - smtp_format = mail.to_smtp_format() - - self.assertRegexpMatches(smtp_format, "\nFrom: pixelated@org") - - def test_extract_headers_should_break_header_in_multiple_recipients(self): - headers = test_helper.DEFAULT_HEADERS.copy() - - headers['to'] = "nlima@example.com, Duda Dornelles " - headers['bcc'] = "ddornelles@example.com, Neissi Lima " - headers['cc'] = "nlima@example.com, Duda Dornelles " - - leap_mail = test_helper.leap_mail(headers=headers) - - pixelated_mail = PixelatedMail.from_leap_mail(leap_mail) - - self.assertEquals(pixelated_mail.headers['to'], ["nlima@example.com", "Duda Dornelles "]) - self.assertEquals(pixelated_mail.headers['bcc'], ["ddornelles@example.com", "Neissi Lima "]) - self.assertEquals(pixelated_mail.headers['cc'], ["nlima@example.com", "Duda Dornelles "]) - - def test_mark_as_read(self): - mail = PixelatedMail.from_leap_mail(test_helper.leap_mail(flags=[])) - - mail.mark_as_read() - - self.assertEquals(mail.leap_mail.setFlags.call_args[0], (('\\Seen',), 1)) - def test_mark_as_not_recent(self): - mail = PixelatedMail.from_leap_mail(test_helper.leap_mail(flags=[])) - - mail.mark_as_not_recent() - - self.assertEquals(mail.leap_mail.setFlags.call_args[0], (('\\Recent',), -1)) - - def test_mark_as_deleted(self): - mail = PixelatedMail.from_leap_mail(test_helper.leap_mail(extra_headers={'X-Tags': '["skinka", "altoids"]'}, flags=[]), Mock()) + def test_to_mime_multipart(self): + pixelated.support.date.iso_now = lambda: 'date now' - self.assertEquals(set(['skinka', 'altoids']), mail.tags) + mime_multipart = InputMail.from_dict(self.mail_dict()).to_mime_multipart() - mail.mark_as_deleted() + self.assertRegexpMatches(mime_multipart.as_string(), "\nTo: to@pixelated.org, anotherto@pixelated.org\n") + self.assertRegexpMatches(mime_multipart.as_string(), "\nCc: cc@pixelated.org, anothercc@pixelated.org\n") + self.assertRegexpMatches(mime_multipart.as_string(), "\nBcc: bcc@pixelated.org, anotherbcc@pixelated.org\n") + self.assertRegexpMatches(mime_multipart.as_string(), "\nDate: date now\n") + self.assertRegexpMatches(mime_multipart.as_string(), "\nSubject: Oi\n") + self.assertRegexpMatches(mime_multipart.as_string(), "\nEste \xe9 o corpo") - self.assertEquals(set([]), mail.tags) - self.assertEquals(mail.leap_mail.setFlags.call_args[0], ((u'\\Deleted',), 1)) - def test_update_tags_notifies_tag_service(self): - db_path = '/tmp/test_update_tags_notifies_tag_service' - tag_service = TagService(TagIndex(db_path)) - mail = PixelatedMail.from_leap_mail(test_helper.leap_mail(), tag_service) + def test_smtp_format(self): + PixelatedMail.from_email_address = 'pixelated@org' - mail.update_tags(set(['new_tag'])) - self.assertIn(Tag('new_tag'), tag_service.all_tags()) + smtp_format = InputMail.from_dict(self.mail_dict()).to_smtp_format() - os.remove(db_path + '.db') + self.assertRegexpMatches(smtp_format, "\nFrom: pixelated@org") \ No newline at end of file diff --git a/service/test/adapter/pixelated_mailbox_test.py b/service/test/adapter/pixelated_mailbox_test.py index 847ce20c..87f7b4f3 100644 --- a/service/test/adapter/pixelated_mailbox_test.py +++ b/service/test/adapter/pixelated_mailbox_test.py @@ -14,58 +14,35 @@ # You should have received a copy of the GNU Affero General Public License # along with Pixelated. If not, see . import unittest + from pixelated.adapter.pixelated_mail import PixelatedMail -from pixelated.adapter.status import Status -import test_helper from pixelated.adapter.pixelated_mailbox import PixelatedMailbox +import test_helper from mockito import * class PixelatedMailboxTest(unittest.TestCase): def setUp(self): - mail_one = test_helper.leap_mail(uid=0, mbox='SENT') - leap_mailbox = test_helper.leap_mailbox(messages=[mail_one], mailbox_name='SENT') - self.tag_service = mock() - self.mailbox = PixelatedMailbox(leap_mailbox, self.tag_service) + self.querier = mock() + self.mailbox = PixelatedMailbox('INBOX', self.querier, tag_service=self.tag_service) def test_mailbox_tag_is_added_when_recent_mail_arrives(self): - recent_leap_mail = test_helper.leap_mail(uid=0, mbox='SPAM', flags=['\\Recent']) - mailbox = PixelatedMailbox(test_helper.leap_mailbox(messages=[recent_leap_mail], mailbox_name='SPAM')) - self.assertIn('spam', mailbox.mails()[0].tags) - - def test_mailbox_tag_is_ignored_for_non_recent_mail(self): - recent_leap_mail = test_helper.leap_mail(uid=0, mbox='SPAM', flags=[]) - mailbox = PixelatedMailbox(test_helper.leap_mailbox(messages=[recent_leap_mail], mailbox_name='SPAM')) - self.assertNotIn('spam', mailbox.mails()[0].tags) + recent_leap_mail = test_helper.leap_mail(uid=0, mbox='INBOX', flags=['\\Recent']) + when(self.querier).all_mails_by_mailbox('INBOX').thenReturn([PixelatedMail.from_soledad(*recent_leap_mail, soledad_querier=self.querier)]) - def test_add_message_to_mailbox_with_raw_message(self): - mail = PixelatedMail.from_dict(test_helper.mail_dict()) - mail.raw_message = lambda: 'raw mail' + self.assertIn('inbox', self.mailbox.mails()[0].tags) - leap_mailbox_messages = mock() - self.mailbox.leap_mailbox.messages = leap_mailbox_messages - - self.mailbox._do_add_async.wrapped_function(self.mailbox, mail, use_smtp_format=False) - - verify(leap_mailbox_messages).add_msg('raw mail') - - def test_add_message_to_mailbox_with_smtp_format(self): - mail = PixelatedMail.from_dict(test_helper.mail_dict()) - mail.to_smtp_format = lambda: 'smtp format mail' - - leap_mailbox_messages = mock() - self.mailbox.leap_mailbox.messages = leap_mailbox_messages - - self.mailbox._do_add_async.wrapped_function(self.mailbox, mail, use_smtp_format=True) + def test_mailbox_tag_is_ignored_for_non_recent_mail(self): + recent_leap_mail = test_helper.leap_mail(uid=0, mbox='INBOX', flags=[]) + when(self.querier).all_mails_by_mailbox('INBOX').thenReturn([PixelatedMail.from_soledad(*recent_leap_mail, soledad_querier=self.querier)]) - verify(leap_mailbox_messages).add_msg('smtp format mail') + self.assertNotIn('spam', self.mailbox.mails()[0].tags) def test_remove_message_from_mailbox(self): - mail = mock() - self.mailbox.leap_mailbox = mock() + mail = PixelatedMail() + when(self.querier).mail(1).thenReturn(mail) - self.mailbox.remove(mail) + self.mailbox.remove(1) - verify(mail).mark_as_deleted() - verify(self.mailbox.leap_mailbox).expunge() + verify(self.querier).remove_mail(mail) diff --git a/service/test/adapter/pixelated_mailboxes_test.py b/service/test/adapter/pixelated_mailboxes_test.py index e188354e..e8f76e0f 100644 --- a/service/test/adapter/pixelated_mailboxes_test.py +++ b/service/test/adapter/pixelated_mailboxes_test.py @@ -14,15 +14,22 @@ # You should have received a copy of the GNU Affero General Public License # along with Pixelated. If not, see . import unittest -from pixelated.adapter.pixelated_mail import PixelatedMail +from test.adapter import test_helper +from mockito import * +import pixelated.adapter.soledad_querier +querier = mock() +global querier +pixelated.adapter.soledad_querier.get_soledad_querier_instance = lambda x, y: querier + +from pixelated.adapter.pixelated_mail import PixelatedMail from pixelated.adapter.pixelated_mailbox import PixelatedMailbox from pixelated.adapter.pixelated_mailboxes import PixelatedMailBoxes -from mockito import * class PixelatedMailboxesTest(unittest.TestCase): def setUp(self): + self.account = mock() self.drafts_mailbox = mock() self.drafts_mailbox.mailbox_name = 'drafts' @@ -34,7 +41,7 @@ class PixelatedMailboxesTest(unittest.TestCase): self.account.mailboxes = ['INBOX'] tags_to_search_for = {'tags': ['inbox', 'custom_tag']} - when(PixelatedMailbox).create(self.account, 'INBOX').thenReturn(mailbox) + when(PixelatedMailbox).create('INBOX').thenReturn(mailbox) when(mailbox).mails_by_tags(any(list)).thenReturn(["mail"]) mails = self.mailboxes.mails_by_tag(tags_to_search_for['tags']) @@ -44,22 +51,18 @@ class PixelatedMailboxesTest(unittest.TestCase): def test_add_draft(self): mail = PixelatedMail() - when(self.drafts_mailbox).add(mail, use_smtp_format=True).thenReturn(1) + when(self.drafts_mailbox).add(mail).thenReturn(1) self.mailboxes.add_draft(mail) - verify(self.drafts_mailbox).add(mail, use_smtp_format=True) - self.assertEqual('drafts', mail.mailbox_name) - self.assertEqual(1, mail.uid) + verify(self.drafts_mailbox).add(mail) def test_update_draft(self): - mail = PixelatedMail() - when(self.drafts_mailbox).add(mail, use_smtp_format=True).thenReturn(1) + mail = test_helper.input_mail() + when(self.drafts_mailbox).add(mail).thenReturn(mail) - self.mailboxes.update_draft(mail) + self.mailboxes.update_draft(mail.ident, mail) - inorder.verify(self.drafts_mailbox).add(mail, use_smtp_format=True) - inorder.verify(self.drafts_mailbox).remove(mail) + inorder.verify(self.drafts_mailbox).add(mail) + inorder.verify(self.drafts_mailbox).remove(mail.ident) - self.assertEqual('drafts', mail.mailbox_name) - self.assertEqual(1, mail.uid) diff --git a/service/test/adapter/test_helper.py b/service/test/adapter/test_helper.py index ad39f343..c8593fc1 100644 --- a/service/test/adapter/test_helper.py +++ b/service/test/adapter/test_helper.py @@ -15,6 +15,7 @@ # along with Pixelated. If not, see . from mock import Mock from datetime import datetime +from pixelated.adapter.pixelated_mail import InputMail LEAP_FLAGS = ['\\Seen', '\\Answered', @@ -41,16 +42,30 @@ def mail_dict(): } -def leap_mail(uid=0, flags=LEAP_FLAGS, headers=DEFAULT_HEADERS, extra_headers={}, mbox='INBOX'): - headers = dict(headers.items() + extra_headers.items()) - return Mock(getUID=Mock(return_value=uid), - _mbox=mbox, - getFlags=Mock(return_value=flags), - bdoc=Mock(content={'raw': 'test'}), - hdoc=Mock(content={'headers': headers})) +def doc(content): + class TestDoc: + def __init__(self, content): + self.content = content + return TestDoc(content) + + +def leap_mail(uid=0, flags=LEAP_FLAGS, headers=DEFAULT_HEADERS, extra_headers={}, mbox='INBOX', body='body', + chash='chash'): + fdoc = doc({'flags': flags, 'mbox': mbox, 'type': 'flags', 'uid': uid, 'chash': chash}) + + headers['headers'] = extra_headers + hdoc = doc(headers) + + bdoc = doc({'raw': body, 'type': 'cnt'}) + + return (fdoc, hdoc, bdoc) + + +def input_mail(): + mail = InputMail() + mail.fdoc = doc({}) + mail._chash = "123" + mail.as_dict = lambda: None + return mail -def leap_mailbox(messages=[leap_mail(uid=6)], mailbox_name='INBOX'): - return Mock(_get_mbox_doc=Mock(return_value=None), - mbox=mailbox_name, - messages=messages) diff --git a/service/test/adapter/test_tag_service.py b/service/test/adapter/test_tag_service.py index 027e6113..5a70e82b 100644 --- a/service/test/adapter/test_tag_service.py +++ b/service/test/adapter/test_tag_service.py @@ -30,8 +30,8 @@ class TagServiceTest(unittest.TestCase): self.tag_service = TagService(tag_index=self.tag_index) def test_index_is_initialized_with_mail_tags_if_empty(self): - mail_one = PixelatedMail.from_leap_mail(test_helper.leap_mail(uid=0, extra_headers={'X-Tags': '["tag_1"]'})) - mail_two = PixelatedMail.from_leap_mail(test_helper.leap_mail(uid=1, extra_headers={'X-Tags': '["tag_2"]'})) + mail_one = PixelatedMail.from_soledad(*test_helper.leap_mail(uid=0, extra_headers={'X-Tags': '["tag_1"]'})) + mail_two = PixelatedMail.from_soledad(*test_helper.leap_mail(uid=1, extra_headers={'X-Tags': '["tag_2"]'})) mails = [mail_one, mail_two] self.tag_service.load_index(mails) @@ -53,7 +53,7 @@ class TagServiceTest(unittest.TestCase): self.assertEquals(0, self.tag_service.tag_index.get('inbox').total) self.assertEquals(1, self.tag_service.tag_index.get('one_tag').total) - self.tag_service.notify_tags_updated(set(['inbox']), set(['one_tag']), mail_ident) + self.tag_service.notify_tags_updated({'inbox'}, {'one_tag'}, mail_ident) self.assertEquals(1, self.tag_service.tag_index.get('inbox').total) self.assertIsNone(self.tag_service.tag_index.get('one_tag')) -- cgit v1.2.3