From 352163eefb9c1e1281b618e357f7673b07a49eb8 Mon Sep 17 00:00:00 2001 From: Victor Shyba Date: Wed, 11 Nov 2015 12:40:35 -0300 Subject: unhandled errors were not being logged and generated no response back --- service/pixelated/resources/mails_resource.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) (limited to 'service/pixelated/resources/mails_resource.py') diff --git a/service/pixelated/resources/mails_resource.py b/service/pixelated/resources/mails_resource.py index 93a19a9b..499610de 100644 --- a/service/pixelated/resources/mails_resource.py +++ b/service/pixelated/resources/mails_resource.py @@ -160,21 +160,23 @@ class MailsResource(Resource): _mail = InputMail.from_dict(content_dict) draft_id = content_dict.get('ident') + def onError(error): + err(error, 'error saving draft') + respond_json_deferred("", request, status_code=422) + def defer_response(deferred): deferred.addCallback(lambda pixelated_mail: respond_json_deferred({'ident': pixelated_mail.ident}, request)) + deferred.addErrback(onError) if draft_id: deferred_check = self._mail_service.mail_exists(draft_id) - def handleDuplicatedDraftException(error): - respond_json_deferred("", request, status_code=422) - def return422otherwise(mail_exists): if not mail_exists: respond_json_deferred("", request, status_code=422) else: new_draft = self._draft_service.update_draft(draft_id, _mail) - new_draft.addErrback(handleDuplicatedDraftException) + new_draft.addErrback(onError) defer_response(new_draft) deferred_check.addCallback(return422otherwise) -- cgit v1.2.3