From a919d12ddb7c688c2e7fb01b8768dab8be9f5c39 Mon Sep 17 00:00:00 2001 From: Felix Hammerl Date: Wed, 13 Apr 2016 16:25:28 +0200 Subject: Issue #431: Review * Remove GenericDeferredErrorHandler class * Convert static method generic_error_handling to function instead --- service/pixelated/resources/__init__.py | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) (limited to 'service/pixelated/resources/__init__.py') diff --git a/service/pixelated/resources/__init__.py b/service/pixelated/resources/__init__.py index 02107364..95ebd115 100644 --- a/service/pixelated/resources/__init__.py +++ b/service/pixelated/resources/__init__.py @@ -49,17 +49,14 @@ def respond_json_deferred(entity, request, status_code=200): request.finish() -class GenericDeferredErrorHandler(object): - - @classmethod - def generic_error_handling(cls, e, request): - log.error(e) - request.setResponseCode(INTERNAL_SERVER_ERROR) - request.write('Something went wrong!') - request.finish() +def handle_error_deferred(e, request): + log.error(e) + request.setResponseCode(INTERNAL_SERVER_ERROR) + request.write('Something went wrong!') + request.finish() -class BaseResource(Resource, GenericDeferredErrorHandler): +class BaseResource(Resource): def __init__(self, services_factory): Resource.__init__(self) -- cgit v1.2.3