From 1c6614f80a3107003d88d9a66c8af19e69b52f6d Mon Sep 17 00:00:00 2001 From: Jefferson Stachelski Date: Wed, 25 Nov 2015 18:07:20 -0200 Subject: Isse #515 - Refactored bcc login on send mail --- service/pixelated/adapter/services/mail_sender.py | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) (limited to 'service/pixelated/adapter/services/mail_sender.py') diff --git a/service/pixelated/adapter/services/mail_sender.py b/service/pixelated/adapter/services/mail_sender.py index acd9f034..8ccfc5a2 100644 --- a/service/pixelated/adapter/services/mail_sender.py +++ b/service/pixelated/adapter/services/mail_sender.py @@ -64,16 +64,18 @@ class MailSender(object): deferreds = [] for recipient in recipients: - if recipient in bccs: - mail.headers['Bcc'] = [recipient] - else: - mail.headers['Bcc'] = [] - + self._define_bcc_field(mail, recipient, bccs) smtp_recipient = self._create_twisted_smtp_recipient(recipient) deferreds.append(outgoing_mail.send_message(mail.to_smtp_format(), smtp_recipient)) return defer.DeferredList(deferreds, fireOnOneErrback=False, consumeErrors=True) + def _define_bcc_field(self, mail, recipient, bccs): + if recipient in bccs: + mail.headers['Bcc'] = [recipient] + else: + mail.headers['Bcc'] = [] + def _build_error_map(self, recipients, results): error_map = {} for email, error in [(recipients[idx], r[1]) for idx, r in enumerate(results)]: -- cgit v1.2.3