From becd26b0bdf44b3625caaa7643914d0379a4fea5 Mon Sep 17 00:00:00 2001
From: Azul <azul@riseup.net>
Date: Mon, 29 Aug 2016 10:26:54 +0200
Subject: refactor: let handlers check if they are applicable

Instead of testing the preconditions for each handler in the dispatcher
the dispatcher hands a request to one handler after the other until one of
them responds.

This is similar to the Chain of Responsibility patter but we iterate over the
'handler_chain' array instead of a linked list.

To change the order of handlers or add other handlers change the array in the
handler_chain function.
---
 lib/nickserver/dispatcher.rb | 33 ++++++++++++++++++++++++---------
 1 file changed, 24 insertions(+), 9 deletions(-)

(limited to 'lib/nickserver/dispatcher.rb')

diff --git a/lib/nickserver/dispatcher.rb b/lib/nickserver/dispatcher.rb
index b818b98..833a2ad 100644
--- a/lib/nickserver/dispatcher.rb
+++ b/lib/nickserver/dispatcher.rb
@@ -1,3 +1,18 @@
+#
+# Dispatcher
+#
+# Dispatch a request so it get's handled by the correct handler.
+#
+# The dispatcher hands a request to one handler after the other until one of
+# them responds.
+#
+# This is similar to the Chain of Responsibility patter but we iterate over the
+# 'handler_chain' array instead of a linked list.
+#
+# To change the order of handlers or add other handlers change the array in the
+# handler_chain function.
+#
+
 require 'nickserver/request'
 require 'nickserver/request_handlers/email_handler'
 require 'nickserver/request_handlers/fingerprint_handler'
@@ -18,22 +33,22 @@ module Nickserver
     protected
 
     def handle(request)
-      handler = handler_for_request request
-      handler.call request
+      handler_chain.each do |handler|
+        response = handler.call request
+        return response if response
+      end
     rescue RuntimeError => exc
       puts "Error: #{exc}"
       puts exc.backtrace
       ErrorResponse.new(exc.to_s)
     end
 
-    def handler_for_request(request)
-      if request.email
-        RequestHandlers::EmailHandler.new
-      elsif request.fingerprint
-        RequestHandlers::FingerprintHandler.new
-      else
+    def handler_chain
+      [
+        RequestHandlers::EmailHandler.new,
+        RequestHandlers::FingerprintHandler.new,
         Proc.new { Nickserver::Response.new(404, "Not Found\n") }
-      end
+      ]
     end
 
     def send_response(status = 200, content = '')
-- 
cgit v1.2.3